I can't see my mistake?

Mike-2003

In the code below it works except it includes '</a' in the search for the employee id. I have tried using single and double quotes but it still doesn't help. I would appreciate it if someone could point it out to me and explain when to use single quotes and double ones.
Thanks.

 echo "<tr bgcolor='".$color."'>";
 echo"<td class='text9bold' width=8% align='center'><a href=$_SERVER[PHP_SELF]?action=empeditselect&f_employeeid=".$Emp_id."</a>".$Emp_id."</td>";

Large

I always use double quotes and just escape them I have been experimenting with PHP for the last 6 months, so I cant promise a miracle cure but try the code below :

echo "<tr bgcolor=\"".$color."\">";
echo"<td class=\"text9bold\" width=\"8%\" align=\"center\"><a href = $_SERVER[PHP_SELF]?action=empeditselect&f_employeeid=\".$Emp_id.\"</a>".$Emp_id."</td>";

Kind regards

Mordecai

Well, you're never ending your anchor tag, you're just placing the end in the middle.

Use a double quote around a string if you want all the variables inside to be treated as PHP variables. Use single quotes when you want to pass the variables as HTML.
Here are some examples:
"this is a test string" equals 'this is a test string'
"this is a $test string" does NOT equal 'this is a $test string'
"this is a $test string" equals 'this is a '.$test.' string'
"this is a ".$test." string" equals 'this is a '.$test.' string'

Hope this helps. All you need to do is close your tag.

Mike-2003

I'm not sure what is ment by closing the tag. Could you explain to this newbie?

Thanks.

sgoku01

Well, you're link looks like this:
<a href=blah</a>
A normal, good working link would look like this:
<a href=blah>text</a>

I think the script has to work now.

Mike-2003

I must be missing something😕
In inputted the below and now it is coming up with an error.

 echo"<td class='text9bold' width=8% align='center'><a href='"$_SERVER[PHP_SELF]"?action=empeditselect&f_employeeid='">.$Emp_id."</a>".$Emp_id."</td>";

jpmoriarty

you're getting really confused with your quotes. personally, I ALWAYS use double quotes, and escape out the ones that i want in HTML. Thus:

echo "<td class=\"text9bold\" width=\"8%\" align=\"center\">
<a href=\"".$_SERVER[PHP_SELF]."?action=empeditselect&f_employeeid=$Emp_id\">$Emp_id</td>";

A few points to notice:

You can use variables in your echo, just so long as that's it (ie it's not too keen on arrays, but a standard variable you can use and it'll be okay (ie echo "This is my variable: $variable"; will be fine.))

If you break out of your echo to use a variable, you must separate the variable and the echo text with a "." - see how that's used above.

At least try and understand what you've written. You've put the </a> before you've echoed the variable that you want as your link.

It's always a good idea to start simple and build up. Check that you know how to make a hyperlink in good old html. Then try to make one in php. Then try to make the text for the link a variable. Then try to make the location a variable too. Do it one stage at a time and you'll find it a lot easier to spot your mistakes.

Mike-2003

Thank you :p

It works great. Being new to this is there a certain editor I should use?

I'm currently using a free one.

Mordecai

Try looking here.