Delete Account Script

[batman]

Hello,

I have this code:

function delete()
{
mysql_query(DELETE FROM users WHERE userid='$id');
}

I know there is something wrong with the mysql_query part, but can't figure it out.

Thanks for any help,
-Blake

[cgraz]

there are a few things wrong with that code. Firstly, the syntax. It should look like this:

function delete()
{
mysql_query("DELETE FROM users WHERE userid='$id'");
}

Secondly, you're within a function. $id isn't defined anywhere within that function, which means your function won't work. Where is $id coming from? Do you have it in the url? If so, then you can use $_GET (a superglobal) to access the value of $id.

mysql_query(DELET FROM users WHERE userid='" . $_GET["id"] . "');

If $id isn't in the url (or being passed using POST method, which is also a superglobal and may be accessed using $_POST["id"]), then you have two options. Pass $id as a parameter in your function, or, define it as global within your function.

// define as parameter
function delete($id)
{
mysql_query("DELETE FROM users WHERE userid='$id'");
}

// or make global within function (if defined in script but outside of function)

function delete()
{
global $id;
mysql_query("DELETE FROM users WHERE userid='$id'");
}

Now if you used the first method, you'd have ot call the function like this

$id = "7";
delete($id);

or

delete("7");

For more reading, have a look here then here

Hope this helps.

Cgraz

[batman]

Ok, thank you for your reply. Here is all of my code:

$id = $_SEESION ['userid'];
function delete()
{

mysql_query("DELETE FROM users WHERE userid='$id'");
}
	echo "<center>Are you sure you want to delete your account?</center><br />";
	echo "<input type=\"button\" name=\"Button\" value=\"YES\" onClick=\"delete()\"> | <input type=\"button\" name=\"Button\" value=\"NO\" onClick=\"javascript:history.back()\">";

[cgraz]

you misspelled $_SESSION 😉

Anyways, $_SESSION is a superglobal, meaning you can just call it within your function. Use this:

function delete() {
   mysql_query("DELETE FROM users WHERE userid='" . $_SESSION["userid"] . "'");
}

Cgraz

[batman]

LOL 😃

I know that most the time it's the little mistakes like that one that always mess a script up. I just got so cought up in it I didn't really look at that part.

Now that I have that working, how would I go about making it to where it say Your account has been successfully removed and would also take them to a certain page?

Thanks a bunch!
-Blake

[cgraz]

What i usually do is have a delete.php page for example. Then make a link

<a href="delete.php" onclick="return confirm('Are you sure you want to delete your Account?')">Delete Account</a>

That will give them a javascript popup. They can click ok or cancel. Then on delete.php, you call your function:

delete();

echo "your account has been deleted";

There are plenty of ways of doign this, it all depends on how your code/site is setup. You could use header() for example to redirect, but only if you haven't outputted anything to the visitor. The first method should work nicely for you.

Cgraz

[batman]

Thank you so much! I'm sorry to bother you with this, but now everything works but now it won't delete the user.
Here is the code for the delete page:

<?

function delete() {
   mysql_query("DELETE FROM users WHERE userid='" . $_SESSION["userid"] . "'");
}
delete();

echo "your account has been successfully deleted";
include 'login_form.html';
?>

[cgraz]

do you have access to $_SESSION['userid'] on the php script that you're trying to delete with?

Cgraz

[batman]

Yes,

I have a page checkuser.php that makes sure the person is a registered user. If they are then I have this:
session_register('userid');

Then I call it on the delete page. Oh I just found out why! LOL 'nother stupid mistake, can't believe you didn't catch it though. I have no kind of database connection on the delete page!
So new code will look like this:

<?
include 'db.php';
session_start();

   mysql_query("DELETE FROM users WHERE userid='" . $_SESSION["userid"] . "'");


echo "<font color=red><b>Your account has been successfully deleted!</b></font>";
include 'login_form.html';
?>