whats wrong with this?

[stuworx]

heres is the code:

function chooser() {
/ puts up a form to choose from a list of products
The products have to be stored in a comma-separated file
with the structure (Product,Product URL, Description,Price).
The form posts to a page "addToBasket.php3".
$fname is the name of the file.
/

global $table_products, $table_basket;

?> <!-- output the column headers -->
	<FORM METHOD="POST" ACTION="<?php echo("addToBasket.php3"); ?>">
	<TABLE border = 1> <TR> 
  	<TD ALIGN="center"> <em>Product</TD>
  	<TD ALIGN="center"> <em>Description</TD>
  	<TD ALIGN="center"> <em>Price</TD>
  	<TD ALIGN="center"> <em>URL</TD>
	<TD ALIGN="center"> <em>Image</TD>
  	<TD ALIGN="center"> <em>Qty ordered</TD>
</em></TR>
<?php 
/* now work through the products file, creating a table with a
   data entry field to contain the quantity ordered */
$dbcnx = myConnect();
$query = "SELECT PROD_ID, PROD_NAME, PROD_PRICE, PROD_URL, PROD_IMAGE FROM $table_products";
$result=mysql_query($query);
if (! $result) printf ("Error: %s<br>", mysql_error ());
for ($i = 0; $i < mysql_num_rows ($result); $i++) {
	$row = mysql_fetch_row($result);
	echo("<tr>");
	for($j = 0 ; $j<mysql_num_fields($result); $j++) {
		echo("<td>");
		if($j==3) echo "<a href=\"".$row[$j]."\" target=\"_blank\">".$row[$j]."</a>";
    else  echo($row[$j]); 
	echo("</td>");
		echo("<td>");
		if($j==4) echo "<img src=\"".$row[$j]."\">";
    else  echo($row[$j]); 
	echo("</td>");
	};
	echo("<TD><INPUT TYPE=TEXT NAME=QUANTITY[");
	echo($row[0]);
	echo("] SIZE=3></tr>");
};

?>
</TABLE>
<INPUT TYPE=SUBMIT VALUE="Submit Form">
<INPUT TYPE=RESET VALUE="Reset Form">

</FORM>

and here is the link to what it is producing:
click here

[dalecosp]

Try:

<?
function chooser() { 
/* puts up a form to choose from a list of products 
The products have to be stored in a comma-separated file 
with the structure (Product,Product URL, Description,Price). 
The form posts to a page "addToBasket.php3". 
$fname is the name of the file. 
*/ 

global $table_products, $table_basket; 
#-- output the column headers --> 
?>
<FORM METHOD="POST" ACTION="addToBasket.php3"> 
<TABLE border = 1> <TR> 
<TD ALIGN="center"> <em>Product</TD> 
<TD ALIGN="center"> <em>Description</TD> 
<TD ALIGN="center"> <em>Price</TD> 
<TD ALIGN="center"> <em>URL</TD> 
<TD ALIGN="center"> <em>Image</TD> 
<TD ALIGN="center"> <em>Qty ordered</TD> 
</em></TR> 
<?php 
/* now work through the products file, creating a table with a 
data entry field to contain the quantity ordered */ 
$dbcnx = myConnect(); 
$query = "SELECT PROD_ID, PROD_NAME, PROD_PRICE, PROD_URL, PROD_IMAGE FROM $table_products"; 
$result=mysql_query($query); 
if (! $result) { 
    printf ("Error: %s<br>", mysql_error ()); 
    exit;
    }
for ($i = 0; $i < mysql_num_rows ($result); $i++) { 
    $row = mysql_fetch_row($result); 
    echo("<tr>"); 
    for($j = 0 ; $j<mysql_num_fields($result); $j++) { 
        echo("\n<td>"); 
        // a newline right there will make source more readable...
        if($j==3) { echo "<a href=\"".$row[$j]."\" target=\"_blank\">".$row[$j]."</a>"; 
        }
        elseif($j==4) {
        echo "<img src=\"".$row[$j]."\">"; 
        }
        elseif ($j==6) {
            // take the <tr> and <td> out of here, already being done...
            echo("<INPUT TYPE=TEXT NAME=QUANTITY["); 
            echo($row[0]); 
            // I can't see what you're trying to do right there...?
            echo("] SIZE=3>"); 
            }
        else { 
        echo($row[$j]); 
        }
    echo("</td>"); 
    }
  echo "</tr>";
}

?> 
</TABLE> 
<INPUT TYPE=SUBMIT VALUE="Submit Form"> 
<INPUT TYPE=RESET VALUE="Reset Form"> 
</FORM>

I always wish I wrote cleaner code when debug times comes around...Is $row[0] the quantity?

[batman]

Just a hunch, but why don't you try changing this:

$query = "SELECT PROD_ID, PROD_NAME, PROD_PRICE, PROD_URL, PROD_IMAGE FROM $table_products"; 

To this:

$query = "SELECT PROD_ID, PROD_NAME, PROD_PRICE, PROD_URL, PROD_IMAGE FROM the actual name of the table here"; 

Also, I see only the $dbcnx = myConnect(); Shouldn't there be some kinda of database host, username, and password?

Like I said I could be totally wrong, so if I sound stupid, it's because I am. LOL

-Blake

[dalecosp]

Well, his myConnect() is a user function he (or someone) wrote so that he wouldn't have to type all that stuff every time he wants to access the db...

As for the query string, it doesn't appear to be the problem to me. I assumed he was talking about the fact that everything was echoed to the browser twice (ChamPhoneChamPhone) which was caused by the fact that he did two "if's" and two "else's" in each $j loop. He needed if-elseif-elseif-else...but I couldn't see that until I cleaned up the code with the brackets....

So, stuworx, the brackets are optional, I suppose, but your logic was slightly faulty. I hope you get it working right now....

And, batman, I liked your movies, even if you are a bit of a newb. We all were once, you know (not so long ago AAMOF). Keep hangin' around here ( 😃 pun intended) and you won't be for long either....

[batman]

Yes I figured that's what the myConnect was for, I use somrthing similar. Was just giving it a whack, who know's I could've been right. 😉 Thanks for supporting, and liking my movies!

-Blake

[stuworx]

elseif ($j==6) {
echo("<TD><INPUT TYPE=TEXT NAME=QUANTITY[");
echo($row[0]);
// I can't see what you're trying to do right there...?
echo("] SIZE=3></tr>");
}
else {
echo($row[$j]);
}

it did make an input box for the user to enter the amount of the product they want. this doesnt work now?

thanks for resolveing the other problem though, it works fine apart from now i dont have an input box, how can i get this to work?

[dalecosp]

Hmm, from what I'm seeing, you don't have a product 'description' any longer, either.

I went back up to the second post and edited the code hoping to resolve the issue. Take the <tr> and <td> statement out of the 'elseif' for j==6; I believe that's already being done by the loop. Then we just have to figure out where your description went <?>