File does not get uploaded at all, no error returned

martinkuria

I have a script which am trying to use to upload files but nothing seems to be happening no file is uploaded no error, nothing happens what could be wrong here is the script: I have adjusted file size changing the upload_max_filesize attribute.

<?php

if ($HTTP_POST_VARS['submit']) {
print_r($HTTP_POST_FILES);
if (!is_uploaded_file($HTTP_POST_FILES['file']['tmp_name'])) {
$error = "You did not upload a file!";
unlink($HTTP_POST_FILES['file']['tmp_name']);
// assign error message, remove uploaded file, redisplay form.
} else {
//a file was uploaded
$maxfilesize=10240;

if ($HTTP_POST_FILES['file']['size'] > $maxfilesize) {
  $error = "file is too large";
  unlink($HTTP_POST_FILES['file']['tmp_name']);
  // assign error message, remove uploaded file, redisplay form.
} else {
  if ($HTTP_POST_FILES['file']['type'] != "image/gif" AND $HTTP_POST_FILES['file']['type'] != "image/pjpeg") {
    $error = "This file type is not allowed";
    unlink($HTTP_POST_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
   //File has passed all validation, copy it to the final destination and remove the temporary file:
   copy($HTTP_POST_FILES['file']['tmp_name'],"/finallocation/".$HTTP_POST_FILES['file']['name']);
   unlink($HTTP_POST_FILES['file']['tmp_name']);
   print "File has been successfully uploaded!";
   exit;
 }
}

}
}
?>

<html>
<head></head>
<body>
<form action="<?=$PHP_SELF?>" method="post" enctype="multipart/form-data">
<?=$error?>
<br><br>
Choose a file to upload:<br>
<input type="file" name="file"><br>
<input type="submit" name="submit" value="submit">
</form>
</body>
</html>

Please do assist

glence

$HTTP_POST_FILES['file'] is enough no need of

$HTTP_POST_FILES['file'] ['tmp_n
ame']

martinkuria

I have tried using $HTTP_POST_FILES['file'] instead of $HTTP_POST_FILES['file']['tmp_name'] still the same problem

crowezr

I had what sounds like similar problems getting the file upload to work in the past. What I discovered is that my generic Web server user didn't have permissions to copy files to the location I was trying to get to. In order to work around this, I used the PHP FTP functions to take the file and FTP it to the correct location. I'm sure there are some security issues, but my function already lies in an authenticated admin area so this wasn't a major concern. Also, it may be a bit slower, but this solution has worked great overall for me. If you would like some code examples, I can provide them.

jabba_29

Hi crowezr,

COuld you post some sample code - I have been searching for easy to understand upload script for ages 😉

Thanks in advance.

Jamie

martinkuria

<?php

$my_max_file_size = "102400"; # in bytes
$image_max_width = "2"; # in pixels
$image_max_height = "2"; # in pixels

#$MAX_FILE_SIZE = $POST['MAX_FILE_SIZE'];
#task = $POST['task'];
#$the_file = $_POST['the_file'];

#---path where the resulting file will sit on your server, this should be absolute and PHP needs 'write' permissions to that directory.----#
$the_path = "/var/www/html/uploader/uploads";

#---Now, we want to list a number of file-types so we can give sensible error messages later on in the script. ----#
#---This is simply an array indexed by 'content-types' with a value that is human readable ------------------------#

$registered_types = array(
"application/x-gzip-compressed" => ".tar.gz, .tgz",
"application/x-zip-compressed" => ".zip",
"application/x-tar" => ".tar",
"text/plain" => ".html, .php, .txt, .inc (etc)",
"image/bmp" => ".bmp, .ico",
"image/gif" => ".gif",
"image/pjpeg" => ".jpg, .jpeg",
"image/jpeg" => ".jpg, .jpeg",
"application/x-shockwave-flash" => ".swf",
"application/msword" => ".doc",
"application/vnd.ms-excel" => ".xls",
"application/octet-stream" => ".exe, .fla (etc)"
); # these are only a few examples, you can add as many as you like

#---Finally, we want to specify what type of file the user is allowed to upload, for this example, it's an image that we might want to ----#
#---embed in a web page, so we build up an array of related 'image' content-types. --------------------------------------------------------#

$allowed_types = array("image/bmp","image/gif","image/pjpeg","image/jpeg");

function form($error=false) {

global $PHP_SELF,$my_max_file_size;

if ($error) print $error . "<br><br>";

print "\n<form ENCTYPE=\"multipart/form-data\"  action=\"" . $PHP_SELF . "\" method=\"post\">";
print "\n<INPUT TYPE=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"" . $my_max_file_size . "\">";
print "\n<INPUT TYPE=\"hidden\" name=\"task\" value=\"upload\">";
print "\n<P>Upload a file";
print "\n<BR>NOTE: Max file size is " . ($my_max_file_size / 1024) . "KB";
print "\n<br><INPUT NAME=\"the_file\" TYPE=\"file\" SIZE=\"35\"><br>";
print "\n<input type=\"submit\" Value=\"Upload\">";
print "\n</form>";

$yn = $my_max_file_size / 1024;

print "<br><br>$my_max_file_size ::: $yn KB<br><br>";

print "<br><br>$my_max_file_size :::: $the_file KB<br><br>";

} # END form

if (!ereg("^{4",phpversion()))} {
function in_array($needle,$haystack) { # we have this function in PHP4, so for you PHP3 people
for ($i=0; $i < count($haystack); $i++) {
if ($haystack[$i] == $needle) {

return true;
}
}
}
}

function validate_upload($the_file) {

global $my_max_file_size, $image_max_width, $image_max_height,$allowed_types,$the_file_type,$registered_types;

$start_error = "\n<b>Error:</b>\n<ul>";

if ($the_file == "none") { # do we even have a file?

    $error .= "\n<li>You did not upload anything!</li>";

} else { # check if we are allowed to upload this file_type

    if (!in_array($the_file_type,$allowed_types)) {
        $error .= "\n<li>The file that you uploaded was of a ".
            "type that is not allowed, you are only
            allowed to upload files of the type:\n<ul>";
        while ($type = current($allowed_types)) {
            $error .= "\n<li>" . $registered_types[$type] . " (" . $type . ")</li>";
            next($allowed_types);
        }
        $error .= "\n</ul>";
    }

    if (ereg("image",$the_file_type) && (in_array($the_file_type,$allowed_types))) {

        $size = GetImageSize($the_file);
        list($foo,$width,$bar,$height) = explode("\"",$size[3]);

        if ($width > $image_max_width) {
            $error .= "\n<li>Your image should be no wider than " . 
                $image_max_width . " Pixels</li>";
        }

        if ($height > $image_max_height) {    
            $error .= "\n<li>Your image should be no higher than " . 
                $image_max_height . " Pixels</li>";
        }

    }

    if ($error) {
        $error = $start_error . $error . "\n</ul>";
        return $error;
    } else {
        return false;
    }
}

} # END validate_upload

function list_files() {

global $the_path;

$handle = dir($the_path);
print "\n<b>Uploaded files:</b><br>";
while ($file = $handle->read()) {
    if (($file != ".") && ($file != "..")) {
        print "\n" . $file . "<br>";
       }
}
print "<hr>";

}

function upload($the_file) {

global $the_path,$the_file_name;

$error = validate_upload($the_file);
if ($error) {
    form($error);
} else { # cool, we can continue
    if (!@copy($the_file, $the_path . "/home/martin" . $the_file_name)) {
        form("\n<b>Something barfed, check the path to and ".
        "the permissions for the upload directory</b>");
    } else {
        list_files();
        form();
    }
}

} # END upload

print "<html>\n<head>\n<title>Upload fffexample</title>\n</head>\n<body>";

switch($task) {
case 'upload':
upload($the_file);
break;
default:
form();
}

print "\n</body>\n</html>";