for loop help

Phoenix_Down

I'm having problems deleting entries from my guestbook using checkboxes. Here is my code:

        for($x=1; $x<sizeof($del); $x++) { // line taken from another scrpt
			mysql_query("delete from guestbook_entries where id='$id'", $dbi);
		}

My checkbox code is as follows: <input type=\"checkbox\" name=\"del[]\" value=\"$id\">

Can someone please fix it.

Thanks in advance. 🙂

sijis

i'm not very good with arrays, but the loop you have will delete the wrong id because if the checkbox picks 3 values, the loop would execute 3 times.
what you want to do is delete the specified values checked on, not the amount of items chosen.

try this:

// can't guarantee it will work.
foreach ($del as $id) {
    mysql_query("delete from guestbook_entries where id='$id'", $dbi);
}

resources:
http://www.php.net/manual/en/control-structures.foreach.php

Phoenix_Down

heh. Can't believe I didn't realize that before.

Thankks! 😉

cgraz

You don't need a loop to do this. You can do it all in one query using implode()

   $query = "DELETE FROM guestbook_entries WHERE id IN ('" . implode("','", $_POST['del']) . "')";

Cgraz