Passing Hidden Form Values With Spaces

olygolfer

Hi all i need some advice.

I have created a (form) buy button on my site which passes the
hidden variable $product - $product is the full name of the product.

The problem is that when you press the buy button the actual information that is sent in the variable $product is shortened to one word.

I have a running example if you want to test it. Press the buy button then look at the cart details on the left you will notice that the name is shortened to one word.

http:www.globallifeline.com/testindex.php

what i am looking for is a way to code the buy button or script so that the hidden value passed is actually the full name.

Here's The Actual Code

  echo "<form name=\"form2\" method=\"post\" action=\"productadd.php\">";
echo "<input name=\"Submit2\" type=\"submit\" class=\"BuyButton\" value=\" Buy Item\">";
echo "<input name=\"product\" type=\"hidden\" value=".$myrow["product"].">";
echo "<input name=\"price\" type=\"hidden\" value=".$myrow["price"].">";
echo "<input name=\"productnumber\" type=\"hidden\" value=".$myrow["productnumber"].">";
echo "<input name=\"rewardpoints\" type=\"hidden\" value=".$myrow["rewardpoints"].">";
echo "</form></td>"; 

# The Fields Are Sent To The  Add To Cart Script Is Below


if (isset($HTTP_SESSION_VARS['orderid']))
{

$orderid =  $HTTP_SESSION_VARS['orderid']; 
$product =  $HTTP_POST_VARS['product']; 
$price =  $HTTP_POST_VARS['price'];
$productnumber =  $HTTP_POST_VARS['productnumber'];
$rewardpoints =  $HTTP_POST_VARS['rewardpoints'];

echo $orderid;
echo $product;

$db = mysql_connect ('', '', '');
mysql_select_db ('');
$sql = "INSERT INTO productsordered VALUES ('".$orderid."','".$product."', '".$price."', '".$productnumber."', '".$rewardpoints."')";
$result = mysql_query($sql);

echo "Your Product Has Been Added To Your Cart";
}


if (!isset($HTTP_SESSION_VARS['orderid']))
{
} ?>

Any Help Would Be Great. (Oh and an opinion on the look of the site would be great also)

Thanks

xblue

the server is not responding, but:

html tags may have attributes. if an attribute value contains spaces, you need to enclose it in quotes or the rest of it will be ignored.

echo "<input name=\"product\" type=\"hidden\" value=\"".$myrow["product"]."\">";

alanzhao

Yea, any values pass as string will be truncated to the first word. Don't know why though:p

I suggest that you don't pass the full product name to the cart, that's not a good way to design a web application. What if the product name changes after the order has been made. You would have no way to reference the order to the inventory.

I suggest that pass the product ID instead of its name, and pull out all the information from database using product ID when order is made. Then, not only the product name will be shown, all its relative information also will be given.

jpmoriarty

took so long to view the web page that two people had responded by the time i had!
i concurr that you just need to enclose the value field in escaped quotes, that will sort you out.

As for the site layout it's very pretty, but tables is not the way to do it at all: it makes it so complicated to code that i'm surprised you havent had a hernia yet.

If you have a look at my site (www.j-moriarty.co.uk) you'll see i use much the same layout (albeit two cols instead of three) but if you look at the source you'll see that it's much less complicated. Just through using CSS's properly it can lighten your workload considerably, and it makes it so much clearer to code. not to mention the fact that it's bad coding practice to use tables for layout (i know a lot of people do, but that doesnt mean we should all follow!).

This is taken from the HTML4.01 specification: (http://www.w3.org/TR/html4/struct/tables.html#h-11.1)

Tables should not be used purely as a means to layout document content as this may present problems when rendering to non-visual media. Additionally, when used with graphics, these tables may force users to scroll horizontally to view a table designed on a system with a larger display. To minimize these problems, authors should use style sheets to control layout rather than tables.

and as i say, once you've started you'll find that it's so much easier to code and to understand, then i'm sure you'll use it more and more!