loops + substr

tomwerner

Why doesn't this script work:?


<?php
// Set $p and $i
$p = 0;
$i = 0;

// Put the contents of log.txt into an array
$array1 = file('log.txt');

// Count the number of array items
$n = count($array1);

// Process lopp while auto increment $i, is smaller than or equal to the amount of entries in $array1
while($i <= $n);
{

// 
$visit['hour'] = substr($array1[$p], 0, 2);

print($visit['hour']);
 if($visit['hour'] == 0)
 {
 $time[0]++;
 }
  elseif($visit['hour'] == 1)
  {
  $time[1]++;
  }
   elseif($visit['hour'] == 2)
   {
   $time[2]++;
   }
    elseif($visit['hour'] == 3)
    {
    $time[3]++;
    }
     elseif($visit['hour'] == 4)
     {
     $time[4]++;
     }
      elseif($visit['hour'] == 5)
      {
      $time[5]++;
      }
       elseif($visit['hour'] == 6)
       {
       $time[6]++;
       }
        elseif($visit['hour'] == 7)
        {
        $time[7]++;
        }
         elseif($visit['hour'] == 8)
         {
         $time[8]++;
         }
          elseif($visit['hour'] == 9)
          {
          $time[9]++;
          }
           elseif($visit['hour'] == 10)
           {
           $time[10]++;
           }
            elseif($visit['hour'] == 11)
            {
            $time[11]++;
            }
             elseif($visit['hour'] == 12)
             {
             $time[12]++;
             }
              elseif($visit['hour'] == 13)
              {
              $time[13]++;
              }
 elseif($visit['hour'] == 14)
 {
 $time[14]++;
  }
  elseif($visit['hour'] == 15)
  {
  $time[15]++;
  }
   elseif($visit['hour'] == 16)
   {
   $time[16]++;
   }
    elseif($visit['hour'] == 17)
    {
    $time[17]++;
    }
     elseif($visit['hour'] == 18)
     {
     $time[18]++;
     }
      elseif($visit['hour'] == 19)
      {
      $time[19]++;
      }
       elseif($visit['hour'] == 20)
       {
       $time[20]++;
       }
        elseif($visit['hour'] == 21)
        {
        $time[21]++;
        }
         elseif($visit['hour'] == 22)
         {
         $time[22]++;
         }
          elseif($visit['hour'] == 23)
          {
          $time[23]++;
          }
           elseif($visit['hour'] == 24)
           {
           $time[24]++;
           }

$p++;
$i++;

}

$Z = 0;
$c = 0;
while($c <= 24)
{

$length = $time[$c];
	while($z <= $length)
	{
	print("<TR><TD><img src=\"bar.gif\" border=\"0\" align=\"middle\"> - $c</Tr></TD>");
	$z++;
	}
$c++;
print("<br>");
}
?>

I'm guessing there is a problem with a loop because it carries on loading then comes out with 30 second time out. There is no need to increase the timeout because this script used to complete in a second or two. Here is an example of the data that is being read out of log.txt:

18:44:54 18 March 2003 : Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0) : http://localhost/tests/

18:44:55 18 March 2003 : Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0) : http://localhost/tests/

18:44:56 18 March 2003 : Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0) : http://localhost/tests/

Thanks for any help.

devinemke

what exactly are you trying to do with this code? you are reformatting the first 2 characters of your log file (the hours)?

Jother

Try taking away the (=) equal sign so that it just checks if $n is smaller than $i
e.i:

while($i < $n);
{

tomwerner

I have had a go at re-writing the script. The errors have gone but now no input is displayed!

<?php

// Get the log
$log_entries = file('log.txt');
// Set vars
$a = 0;
$b = 0;
// How many entries are there in the log?
$log_count = count($log_entries);

// While loop, registers each log entry for the appropriate hour
while($a <= $log_count)
{
// Chop the first two digits for the hour
$substr[] = substr($log_entries['$a'], 0 , 2);

    // Check to see whether it is a 1 digit hour (as 2 digit format is not compatiable with ++)
    if($substr['$a'] == "0:|1:|2:|3:|4:|5:|6:|7:|8:|9:")
    {
    // Yes it is a 1 digit, chop it down to one character
    $time['$a'] = substr($log_entries['$a'], 0 , 1); 
    }
    else
    {
    // No, chop it to 2 still
    $time['$a'] = substr($log_entries['$a'], 0 , 2); 
    }
            // Put the times in the correct array bits
            if($time['$a'] == 0)
            {
            $hour['0']++;
            }
            elseif($time['$a'] == 1)
            {
            $hour['1']++;
            }
            elseif($time['$a'] == 2)
            {
            $hour['2']++;
            }
            elseif($time['$a'] == 3)
            {
            $hour['3']++;
            }
            elseif($time['$a'] == 4)
            {
            $hour['4']++;
            }
            elseif($time['$a'] == 5)
            {
            $hour['5']++;
            }
            elseif($time['$a'] == 6)
            {
            $hour['6']++;
            }
            elseif($time['$a'] == 7)
            {
            $hour['7']++;
            }
            elseif($time['$a'] == 8)
            {
            $hour['8']++;
            }
            elseif($time['$a'] == 9)
            {
            $hour['9']++;
            }
            elseif($time['$a'] == 10)
            {
            $hour['10']++;
            }
            elseif($time['$a'] == 11)
            {
            $hour['11']++;
            }
            elseif($time['$a'] == 12)
            {
            $hour['12']++;
            }
            elseif($time['$a'] == 13)
            {
            $hour['13']++;
            }
            elseif($time['$a'] == 14)
            {
            $hour['14']++;
            }
            elseif($time['$a'] == 15)
            {
            $hour['15']++;
            }
            elseif($time['$a'] == 16)
            {
            $hour['16']++;
            }
            elseif($time['$a'] == 17)
            {
            $hour['17']++;
            }
            elseif($time['$a'] == 18)
            {
            $hour['18']++;
            }
            elseif($time['$a'] == 19)
            {
            $hour['19']++;
            }
            elseif($time['$a'] == 20)
            {
            $hour['20']++;
            }
            elseif($time['$a'] == 21)
            {
            $hour['21']++;
            }
            elseif($time['$a'] == 22)
            {
            $hour['22']++;
            }
            elseif($time['$a'] == 23)
            {
            $hour['23']++;
            }
            elseif($time['$a'] == 24)
            {
            $hour['24']++;

// Auto-increment                }
$a++;
}

$c = 0;
while($c <= 24)
{
PRINT("$c : 00 - ");
PRINT("$hour[$c]");
print("<br>");
$c++;
}

?>

Any more suggestions?

buck2bcr

I'm not sure exactly what your trying to do here. If you could give a little background on the use I may be able to assist some. I took a quick look at the code and a couple of things I would do would be instead of this (which I couldn't get to work):

// Check to see whether it is a 1 digit hour (as 2 digit format is not compatiable with ++)
        if($substr['$a'] == "0:|1:|2:|3:|4:|5:|6:|7:|8:|9:")
        {
        // Yes it is a 1 digit, chop it down to one character
        $time['$a'] = substr($log_entries['$a'], 0 , 1); 
        }
        else
        {
        // No, chop it to 2 still
        $time['$a'] = substr($log_entries['$a'], 0 , 2); 
        }

I would use this:

 $time[$a] = ereg_replace(":", "", $substr[$a]);

Then I don't really get your if / else stuff, I would try going with a switch statement. A little more background may help.

Buck

tomwerner

basically I am trying to create graphical site statistics that don't require the image libraries. I have never heard of the switch statement I'll look it up on php.net.

buck2bcr

Here's what I got for you. Let me know if this helps or have any questions (or if this is even what you want)

HTH

<?php

// Get the log
$log_entries = file('log.txt');

// Set vars
$a = 0;
$b = 0;
// How many entries are there in the log?
$log_count = count($log_entries);

// For loop loop, initializes $hour array sets all to zero
for ($i = 0; $i < 24; $i++)
{
    $hour[] = 0;
}

while($a < $log_count)
{
    // Chop the first two digits for the hour
    $substr[] = substr($log_entries[$a], 0 , 2);

//remove any colons at the end of the numbers
$time[$a] = ereg_replace(":", "", $substr[$a]);

// switch to incriment $hour array
switch ($time[$a])
{
    case "0":
        $hour[0]++;
        break;
    case "1":
        $hour[1]++;
        break;
    case "2":
        $hour[2]++;
        break;
    case "3":
        $hour[3]++;
        break;
    case "4":
        $hour[4]++;
        break;
    case "5":
        $hour[5]++;
        break;
    case "6":
        $hour[6]++;
        break;
    case "7":
        $hour[7]++;
        break;
    case "8":
        $hour[8]++;
        break;
    case "9":
        $hour[9]++;
        break;
    case "10":
        $hour[10]++;
        break;
    case "11":
        $hour[11]++;
        break;
    case "12":
        $hour[12]++;
        break;
    case "13":
        $hour[13]++;
        break;
    case "14":
        $hour[14]++;
        break;
    case "15":
        $hour[15]++;
        break;
    case "16":
        $hour[16]++;
        break;
    case "17":
        $hour[17]++;
        break;
    case "18":
        $hour[18]++;
        break;
    case "19":
        $hour[19]++;
        break;
    case "20":
        $hour[20]++;
        break;
    case "21":
        $hour[21]++;
        break;
    case "22":
        $hour[22]++;
        break;
    case "23":
        $hour[23]++;
        break;
}
// Auto-increment
    $a++;
}


// shows how nany of each hour are in log
$c = 0;
while($c < 24)
{
PRINT("$c : 00 - ");
PRINT("$hour[$c]");
print("<br>");
$c++;
}

?>

buck2bcr

I've thought about it a little more and you could get away with just this code (I think 🙂 )

<?php

// Get the log
$log_entries = file('log.txt');

// Set vars
$a = 0;
$b = 0;

// How many entries are there in the log?
$log_count = count($log_entries);

// For loop to initializes $hour array sets all to zero 0 - 23
for ($i = 0; $i < 24; $i++)
{
    $hour[] = 0;
}

while($a < $log_count)
{
    // Chop the first two digits for the hour
    $substr[] = substr($log_entries[$a], 0 , 2);

//remove any colons at the end of the numbers
$time[$a] = ereg_replace(":", "", $substr[$a]);

// Increment specific hour in array
$hour[$time[$a]]++;

// Auto-increment
$a++;
}


// shows how nany of each hour are in log
$c = 0;
while($c < 24)
{
PRINT("$c : 00 - ");
PRINT("$hour[$c]");
print("<br>");
$c++;
}

?>

HTH

Buck

tomwerner

Thanks very much, thanks for replying, PHP hasn't been my priority over the last few days. I'll give the code a try, thanks agian everyone thanks for your help.