function variables?

[inkfish]

Hi =)

I've done this function:

function listusers ($user_status) {
	$query = "SELECT login,member_id FROM member_data WHERE status="$user_status" ORDER BY login desc";
	$result = mysql_query($query) or die (mysql_error());
	while ($row = mysql_fetch_array($result)) {
		echo "<a href=\"showuser.php?id=$row[member_id]\">$row[login]</a><br>";
	}	
}

but when i use it like this

<? listusers('Founder'); ?>

i get this:
Parse error: parse error, unexpected T_VARIABLE in e:\webdesign\mysgos\require\funcs.php on line 35

line 35 is this one: $query = "SELECT login,member_id FROM member_data WHERE status="$user_status" ORDER BY login desc";

What is that is wrong? the $user_status should be Founder right?

I don't get it!

[AndyB40]

Try this line instead:

$query = "SELECT login,member_id FROM member_data WHERE status='$user_status' ORDER BY login desc";

Note the single quotes around $user_status. By using the double quotes you created a parse error.

[devinemke]

your quotes are screwing up your query

assuming $user_status is a string:

function listusers ($user_status) {
    $query = "SELECT login,member_id FROM member_data WHERE status = '$user_status' ORDER BY login desc";
    $result = mysql_query($query) or die (mysql_error());
    while ($row = mysql_fetch_array($result)) {
        echo '<a href="showuser.php?id=' . $row['member_id'] . '">' . $row['login'] . '</a><br>';
    }    

}

if $user_status is an integer then you can lose the single quotes around it in the query