File Upload fail

hkucsis

Hi,

I just want to create a form and let the user to upload files to a pre-fined directory but I failded..

upload.php // the web form

<HTML>
<HEAD>
<TITLE>File Uploading Tool</TITLE>
</HEAD>
<BODY>
<h3>File Uploading Tool</h3>
<FORM ACTION="uploading.php" METHOD="post" ENCTYPE="multipart/form-data">
File : <INPUT TYPE="file" NAME="userfile">  <INPUT TYPE="submit" VALUE="upload">
</FORM>
</BODY>
</HTML>

uploading.php

<html>
<HEAD>
<TITLE>File Uploading Tool</TITLE>
</HEAD>
<BODY>
<?php

$uploaddir = '/web/docs/law/temp_upload' ;

if (move_uploaded_file($FILES["file"]["tmp_name"], $uploaddir . $FILES["file"]["name"]))
{
echo "good" ;
}
else
{
echo "bad" ;
}
?>
</body>
</html>

Actually I just copy the code from php manual but it doesn't work. I am using PHP4.2.3 . I am sure I have done "chmod 777" for the directory "temp_upload". Also, register_globals is turned off.

Thanks for you help.

Weedpacket

First thing I see is that you've named the file "userfile" in the first page, and "file" in the second... try using $FILES["userfile"] instead of $FILES["file"] and see what happens.

sleepingdanny

Why don't you use =>

copy($userfile, $uploaddir . $userfile_name);

And not move_uploaded_file 😕

Fix the first mistake that "Weedpacket" told you and replace the "move_uploaded_file" to copy() if it still shows an error
:p

Weedpacket

The reason that move_uploaded_file() is recommended over copy() in this case is that it's safer: copy() won't check to ensure that the file being copied really was an uploaded file, and will quite happily copy any file on the system if , e.g., someone manages to forge a suitably bogus name for the file.