Something wrong...but don't know what :/

[muitine]

here's my whole code:

<?php
$dbhost="localhost";
$dbuser="user";
$dbname="name";
$db = mysql_connect("$dbhost", "$dbuser");
mysql_select_db("$dbname");

$login=$_POST['login'];
$passwd=$_POST['passwd'];

if (!$login) {
echo "Something's wrong with the user name field";
} elseif (!$passwd) {
echo "Something's wrong with the user name";
} elseif {
check_logina($login, $passwd)) {
print_mb();  

) else {
echo "mistake";
}
mysql_close($db);
?>

<?php
function check_logina($login, $passwd)
{
  $failas = "/var/where/file/passwd";
    $duomenys = fopen ($failas, "r");
    $index=0;
    while (!feof($duomenys)) {
	$eilute[$index] = fgetss($duomenys, 100);
	list($useris, $slaptazodis, $workdyra, $kazkas) = explode("*", $eilute[$index]);
	if ($login==$useris && $passwd==$slaptazodis) {
	    return 1;
	}
	$index++;
    }
fclose ($duomenys);
    } else {
    return 0;
}
?>

<?php
function print_mb() {
global $dbhost, $dbname, $dbuser, $login, $kazkas;
$rezult = mysql_query("SELECT round(sum(issiusta)/1024/1024) from statistika where vardas='".$login."' and HOUR(laikas) > 9 and HOUR(laikas) < 21");
while ($row = mysql_fetch_row($rezult))
echo $row[0].'<br />';
mysql_free_result($rezult);
}
?>

the main idea is to print uout the number of Mbytes a user has used up during DAY (9-21) hours.
the login and passwd come from another php file, from a form.
the function function print_mb works fine alone, but i think sonething's wrong with the function check_logina or at the begining of my code:

if (!$login) {
echo "Something's wrong with the user name field";
} elseif (!$passwd) {
echo "Something's wrong with the user name";
} elseif {
check_logina($login, $passwd)) {
print_mb();  

) else {
echo "mistake";
}
mysql_close($db);

please help... i've been working on THIS code for about a week now, and just can't figure it out myself 🙁

[jpmoriarty]

you've got a rogue { at the end of your check_logina line

[crowezr]

It looks like there might be a problem with your while loop. It looks like you are closing the while loop right after you increment the index by 1. You also have an else statement that is not closed out. Here is how I'm interpreting the code. I may be off since I don't know the exact functionality desired.

function check_logina($login, $passwd)
{
$failas = "/var/where/file/passwd";
$duomenys = fopen ($failas, "r");
$index=0;
while (!feof($duomenys)) {
$eilute[$index] = fgetss($duomenys, 100);
list($useris, $slaptazodis, $workdyra, $kazkas) = explode("*", $eilute[$index]);
if ($login==$useris && $passwd==$slaptazodis) {
return 1;
} else {
return 0; }
}
fclose ($duomenys);
$index++;
}

[muitine]

if (!$login) {
echo "Something's wrong with the user name field";
} elseif (!$passwd) {
echo "Something's wrong with the user name";
} elseif {
check_logina($login, $passwd)) {
print_mb();  

) else {
echo "mistake";
}

is everything ok here? coz i even don't get the rezult i should get when i don't enter a username or a password :/

[jpmoriarty]

i still think you've got a rogue { after the check_logina.

try if(empty($login)) instead

[onlinegs]

Originally posted by jpmoriarty
i still think you've got a rogue { after the check_logina.

Agreed, thay { shouldn't be there.

[Hiccup]

) else {

should be

}else{

it's a round bracket-squint-yer-eyes-for-an-hour error!

damn curly and curved brackets!

[Hiccup]

Originally posted by muitine

if (!$login) {
echo "Something's wrong with the user name field";
} //close of first if statement 
elseif (!$passwd) {
echo "Something's wrong with the user name";
} // close of second if statement 
else{ // you had elseif should read else?
 check_logina($login, $passwd)) {
 print_mb();  

 }// curly bracket replaced here
 else{
 echo "mistake";
 }
}// added your missing } sucker...close of else statement

is everything ok here? coz i even don't get the rezult i should get when i don't enter a username or a password :/ [/B]

I re read my post and saw more errors so I fixed them I think...