mysql update other help, please

kashmirekat

EDIT: I've gotten it to update, but just not the records I want. The value of watson (found via ex.php?teacher=watson) isn't pulling through into the update and thus only values with nothing in the teacher field are being updated. //end edit

I have been looking at this for hours now and thought I would ask for some help, if you don't mind. This is a prototype (so it's sufficing for now) for teachers to select an Announcement image on their own website, where they just select an image and it updates right into the db field and displays on their page. Now the problem I'm having is that it won't update. When I run the echo of my sql update, I get that teacher=$teacher where the $teacher is supposed to be replace with the teachers name that is in the url. ie ex.php?teacher=watson, it's not pulling the 'watson' out. This is probably something stupid I'm doing on my part, but after hours of looking at it, I'm so frustrated and was hoping that one of you wonderful people could help me.
Thanks!

<?php
if ($submit) {
  // process form
    $DBhost = "localhost";
	$DBuser = "dbuser";
	$DBpass = "dbpass";
	$DBName = "dbname";
  $db = mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable to connect to database");
  mysql_select_db("dbname",$db);
  $sql = "UPDATE images SET image='$image' WHERE teacher='$teacher'";
  $result = mysql_query($sql); 
  echo "Record Updated.\n";
} else{
  // display form
  ?>

My form element:

<form name="selection" method="post" action="<?php echo $PHP_SELF?>">
Announcements<p><input type="hidden" name="category" value="announcements">
<input value="a001.gif" type="radio" name="image"><img src="image.gif" width="109" height="73" alt="" border="0" align="center">
| <input value="a002.gif" type="radio" name="image"><img src="image.gif" width="109" height="73" alt="" border="0" align="center">
| <input value="a003.gif" type="radio" name="image"><img src="image.gif" width="109" height="73" alt="" border="0" align="center">
<p>
<input value="a004.gif" type="radio" name="image"><img src="image.gif" width="109" height="73" alt="" border="0" align="center">
| <input value="a005.gif" type="radio" name="image"><img src="image.gif" width="109" height="73" alt="" border="0" align="center">
| <input value="a006.gif" type="radio" name="image"><img src="image.gif" width="109" height="73" alt="" border="0" align="center">
<p><input type="hidden" name="teacher" value="$teacher">
<input type="submit" value="Submit" name="submit">
</form>

  <?php

} // end if
?>

cgraz

Sounds like you have globals set to off. Try this

  $sql = "UPDATE images SET image='" . $_POST["image"] . "' WHERE teacher='" . $_GET["teacher"] . "'";
  $result = mysql_query($sql) or die(mysql_error());

Actually looking over your post again, I don't see where you pass $teacher in the url. You have it set as a hidden input field (which would be method POST), but in your post you say it's in the url (which would be method GET). Two different things. When you submit the form, is the teacher=watson in the url? Or is it in the url before you submit the form? If that's the case, then view the source. You have a hidden input field that has the value set to $teacher. View your html source (meaning after your .php file is parsed) and see if there is a value in that hidden input field. If there is no value, and the $teacher value is up in the url, then you have to do

In your form, i see you call $teacher but you aren't within php tags. There are a lot of confusing things with your code making it hard to help you. Figure out what it is you want to do, think of the logic behind it, and give it a shot. The suggestions I made here should help you. If you get stuck, post back and I or someone else will help you out some more.

Cgraz

kashmirekat

I'm not exactly the best at explaining things. :p But unfortunately it still doesn't work. The teacher field is still not pulling from the url using the get method. It's in the url before I post. When I echo the $sql, I get UPDATE images SET image='a003.gif' WHERE teacher=''. I'm going to examine my code again and if I can't get it to work, I'll have to come back to it later.

Thanks for your help! 😃

cgraz

in your form make your hidden input look like this

<input type="hidden" name="teacher" value="<?= $_GET["teacher"] ?>">

And your query like this:

$sql = "UPDATE images SET image='" . $_POST["image"] . "' WHERE teacher='" . $_POST["teacher"] . "'";
$result = mysql_query($sql) or die(mysql_error());

Cgraz

kashmirekat

It works!!!! Thank you very much. 😃 I should have asked for help two hours ago. :p

Thank you again and have a wonderful evening!!