Trying to update an older script to use superglobals, but don't know correct syntax

hurricaneone

Hi there,

So I have this code,

<?

switch ($ENum) {

case '1':
$goto = "Ecard1.swf?EcardText=".$EcardText;
$gotoFooter = "EcardFooter.swf?EcardText=".$EcardText."&EcardSelect=1";
$Dimensions = "WIDTH=700 HEIGHT=525";
$DimensionsFooter = "WIDTH=700 HEIGHT=250";
break;

case '2':
$goto = "Ecard2.swf?EcardText=".$EcardText;
$gotoFooter = "EcardFooter.swf?EcardText=".$EcardText."&EcardSelect=2";
$Dimensions = "WIDTH=700 HEIGHT=525";
$DimensionsFooter = "WIDTH=700 HEIGHT=250";
break;

case '3':
$goto = "Ecard3.swf?EcardText=".$EcardText;
$gotoFooter = "EcardFooter.swf?EcardText=".$EcardText."&EcardSelect=3";
$Dimensions = "WIDTH=700 HEIGHT=525";
$DimensionsFooter = "WIDTH=700 HEIGHT=250";
break;

case '4':
$goto = "Ecard4.swf?EcardText=".$EcardText;
$gotoFooter = "EcardFooter.swf?EcardText=".$EcardText."&EcardSelect=4";
$Dimensions = "WIDTH=700 HEIGHT=525";
$DimensionsFooter = "WIDTH=700 HEIGHT=250";
break;

case '5':
$goto = "Ecard5.swf?EcardText=".$EcardText;
$gotoFooter = "EcardFooter.swf?EcardText=".$EcardText."&EcardSelect=5";
$Dimensions = "WIDTH=700 HEIGHT=525";
$DimensionsFooter = "WIDTH=700 HEIGHT=250";
break;
}

?>
</head>

<body bgcolor="#FFFFFF" topmargin="0" leftmargin="0" rightmargin="0" marginheight="0" marginwidth="0">

<center>

<OBJECT classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000"
 codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=5,0,0,0"
 <? print "$Dimensions";?>>
 <PARAM NAME=movie VALUE="<? print "$goto";?>"> <PARAM NAME=quality VALUE=high> <PARAM NAME=bgcolor VALUE=#FFFFFF> <EMBED src="<? print "$goto";?>" quality=high bgcolor=#FFFFFF  <? print "$Dimensions";?> TYPE="application/x-shockwave-flash" PLUGINSPAGE="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash"></EMBED>
</OBJECT>

<OBJECT classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000"
 codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=5,0,0,0"
 <? print "$DimensionsFooter";?>>
 <PARAM NAME=movie VALUE="<? print "$gotoFooter";?>"> <PARAM NAME=quality VALUE=high> <PARAM NAME=bgcolor VALUE=#FFFFFF> <EMBED src="<? print "$gotoFooter";?>" quality=high bgcolor=#FFFFFF  <? print "$DimensionsFooter";?> TYPE="application/x-shockwave-flash" PLUGINSPAGE="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash"></EMBED>
</OBJECT>
</center>
</BODY>
</HTML>

which came with an flash/php Ecards tutorial.

Now, as far as I'm aware, this is pre-4.1 release code. I'm running 4.3.x on my local install (with the register_globals set to 'on'), but it still won't fly.

I thought that maybe a kind person might help me by demonstrating the correct way to declare variables in a later-than-4.1 release way, 'cause I've tried to add stuff like this under the $ENum line:

$goto = $_POST["goto"];

to try and get it going, but where the original script won't parse the names of the swf files, there is at least something (the <object> tags, etc) within the <body> tags. With my weak attempt to declare variables, not only are the swf names being left out, the <body> tags are completely empty, I guess showing a complete breakdown of the script.

Please, any help is greatly appreciated.

Cheers

keith73

What is the value of $ENum??

add this before the switch:

echo "<!-- $ENum -->\n";

that will output a comment tag to your html code. view the source to see what you get. if it isn't set to one of the values in your switch, then that's you're problem.

Also, have a default in the switch statement. If all else fails, the default could give you an error message so you know what went wrong.

keith

PS - use PHP not CODE when posting php code. code still interprets smileys, PHP doesn't.

hurricaneone

Hi Keith,

I was wondering as well what $ENum was referring to.

😕

As you said, I tried putting the line of code in before the switch - the only change was this

before the <head> tag of the generated html page.

You don't think I need to declare all the variables with $_POST between the switch and the rest of the script? I thought that was what was needed to make a script 4.1.x and later compliant, to the degree that you wouldn't need to turn the register_globals to 'on'.

Hmm, I also tried taking out the switch (that's basically the 'if' of an 'if, then' statement, right?) and I went back to an html page of <body>
</body>

Can you suggest anything else?

keith73

Originally posted by hurricaneone
Hi Keith,

I was wondering as well what $ENum was referring to.

😕

As you said, I tried putting the line of code in before the switch - the only change was this



before the <head> tag of the generated html page.

You don't think I need to declare all the variables with $_POST between the switch and the rest of the script? I thought that was what was needed to make a script 4.1.x and later compliant, to the degree that you wouldn't need to turn the register_globals to 'on'.

Hmm, I also tried taking out the switch (that's basically the 'if' of an 'if, then' statement, right?) and I went back to an html page of <body>
</body>

Can you suggest anything else?

http://www.php.net/manual/en/function.import-request-variables.php

Call this function at the top of the script. It will read all values from GET,POST or COOKIE into the global namespace when register_globals is off.

where I work, we are in the process of upgrading to a new server with 4.3 and want to turn globals off. We will be using this function to import all of the GET and POST values. Some poorly written scripts by the person I replaced used globals everywhere. Next revision I'm doing away with that.

Keith

hurricaneone

Hi Keith, I appreciate your suggestions and I'll give em a try.

I discovered that the $ENum variable refers directly to the EcardSelect variables handed out by the included Flash movies. I'm pretty decent with Flash, but not so great with php, as you might see.

I have one last question, if you have a chance to read this. The original code seems to be working OK with the register_globals 'on' (I want to change that later, but first I'd like to see this work) - but the html doesn't want to parse the names of the swf movies.

<PARAM NAME=movie VALUE="<? print "$goto";?>">

In the generated html, it's simply VALUE="". Can you figure why this wouldn't be working?

Thanks again for any help
Cheers