parsich url function

8701

hi everyone,

i got a lil`problem with a function that i wrote. it´s very easy but it´s still not working as it should.

first heres the code and after that i´ll describe the problem.

function parseurl($url)
	{
	$urlstring = strchr($url, "?");
	$urlstring = substr($urlstring, 1);
	$dataarray = explode("&", $urlstring);
	for ($i=0; $i < $arraycount = count($dataarray); $i++)
		{
		$variables = explode("=",$dataarray[$i]);
		return $$variables[0] = $variables[1]; 
		}
	}

$value = "ims/serverdoku/serv.php?item1=value1&item2=value2&item3=value3";
echo $done = parseurl($value);

echo $item1;
echo $item2;
echo $item3;

What i was tryin´ is parsing the given url and create variables out of itself like:
$item1 <--name of the 1st variable
value1 <--value of the 1st variable
$item2 <--name of the 2nd variable
value2 <--value of the 2nd variable
...

It works fine for $item1 but all the other variables are not set.

codeDV

You have the return statment in the middle of a loop. As soon as a return satement is encountered PHP exits the function. So it will return the first value and then exit:

<?php
function parseurl($url)
    {
    $urlstring = strchr($url, "?");
    $urlstring = substr($urlstring, 1);
    $dataarray = explode("&", $urlstring);
    for ($i=0; $i < $arraycount = count($dataarray); $i++)
        {
        $variables = explode("=",$dataarray[$i]);
        $ret[$variables[0]] =  $variables[1];
        }
    return $ret;
    }

$value = "ims/serverdoku/serv.php?item1=value1&item2=value2&item3=value3";

print_r (parseurl($value));
?>

This will return an array with keys set to the variable name and values set to its value.

8701

thx for your help. works great.
theres still so much that i have to learn.

8701