is my code faulty? it keeps cutting off my html

[pigness]

i've got my index.php file which is just one table cell with 5 rows and 2 columns, and in the right column i;ve inserted an empty table with the following php code in it.

Code:
<?php @ include($_GET["file"] . "home.html"); @ require_once ("$file.html");?>

but when i look at it online the last row in my index.php file is cut off completely? is this peice of code faulty the way i've set it up? Please help!

[stolzyboy]

what is the get file for, are you trying to append that to home.html to make whatever get file is, like if get file is maniac, you want to include maniachome.html?

try this, btw why are you using include and require_once, just use include //there may be parse errors, didn't check, but just use include instead of require_once for best results

<?
include '$_GET[file] . "home.html"';
include '$file.html';
?>

[pigness]

it didn't work i got errors on the page, two of them actually.

Warning: Failed opening '$_GET[file] . "home.html"' for inclusion (include_path='.:/usr/lib/php')

Warning: Failed opening '$file.html' for inclusion (include_path='.:/usr/lib/php')

www.vrj.ca/test2

[Inkybro]

can't you just use

include("home.html")

or is that just for other php files...
even if it was you could just rename your file home.php
and then do

include("home.php")

and i think it would work fine.

[BuzzLY]

First of all, require() will result in a fatal error if it doesn't find the file. That may be why the last line doesn't show up -- PHP immediately halts processing of the page. Try using include() instead, and see if your page loads completely.

Second... your warnings are occuring because you are using single quotes. PHP expects to load what's between the single quotes literally. If you typed

include('$file.php')

then it expects to find a file called "$file.php."

Now... I am assuming that you have two files -- one called whateverhome.html and whatever.html, right? Then I recommend you use this code:

<?php
// never assume that register_globals is ON.  So:
$file = $_GET["file"];
// to prevent errors in case "file" was not included in the URL:
if ($file != "") {
   // we must use concatenation outside quotes since $file is only part of the name:
   include($file . "home.html");
   // but not here, since it's the whole name:
   include("$file.html");
}
?>

Once you have determined that everything is working correctly, and you are getting no warnings, then change the appropriate include()s to require() or require_once().

As a side note, you CAN include files other than PHP, as we are here. You can even use an URL to refer to the file, as long as allow_url_fopen is enabled in php.ini (which it is by default). Of course, more info on this is available in TFM. 😉

Hope that helps!