iterating over arrays from file()

stephen2002

I have a really odd problem where if I try foreach() on an array created by file() it just returns the last element of the array. So what we have is a text file:

test1
test2
test3

And this code:

$filedata = file(test.txt);
reset($filedata);
while (list($linenum, $line) = each ($filedata))
	{
    print "$linenum: $line";
	}
print "<br>";

foreach ($filedata as $linenum => $line);
	{
    print "$linenum: $line";
	}

And the output ends up being:

0: test1 1: test2 2: test3
2: test3

What's up with this? Am I doing something horbily wrong? I am using PHP 4.3.0 with Apache 1.3.x on Windows.

amchargue

I would think you need another reset($filedata) after the while(list=each) loop. That while loop moves the pointer as it iterates.

intenz

Try...

$arrFile = file( 'test.txt' );
foreach( $arrFile as $linenum => $line )
{
     echo $linenum . ': ' . $line . '<br>';
}

This should work.

stephen2002

Originally all I had was the foreach() loop (essentially identical to intenz's example), but then I added the while loop for compairson when it kept only returning the final line. That's what I don't understand. I also tried (even though one shouldn't have to) re-setting the array pointer before the foreach() with no luck.

Weedpacket

Nothing to do with array position pointers (foreach resets those), nothing to do with string format (why should it?); everything to do with punctuation.

foreach ($filedata as $linenum => $line) /* ; */
	{
    print "$linenum: $line";
	}

stephen2002

Hummm...STUPID SEMICOLONS! I always forget to put them in where needed, and sometimes they sneak their way in where they don't belong :rolleyes:

Thanks!