I turn Register globals off and JUST Detail pages break.

Fritz

I want to turn reg. globals off and this morning I did...

all of our list sql selects seem to work fine...

BUT when I try to hit a detail page ... I get a can't execute query.

this seems to effect all pages where I am doing an '?id=xxx' extention to a url...

Example.

$sql = "SELECT * FROM " . $table_name . " WHERE record_no = $id";

Does this mean that I can't carry a variable VIA a url with reg. globals OFF?

or is there another way I write the above select to work?

hkucsis

You can use

$sql = "SELECT * FROM " . $HTTP_GET_VARS["table_name"] . " WHERE record_no = $id";

Fritz

Originally posted by hkucsis
You can use

$sql = "SELECT * FROM " . $HTTP_GET_VARS["table_name"] . " WHERE record_no = $id";

Soo... the problem is specifically HOW I am calling the table

so I just always use " . $HTTP_GET_VARS["table_name"] . "

the reason I ask is because hundreds of my non detail pages (we will call them lists) ... simply call

"FROM tablename" and they do work with Reg. Globals turned off.

ir4z0r

hkucsis probably meant

$sql = "SELECT * FROM " . $table_name . " WHERE record_no = " . $_GET['id'];

all vars via ? are retrieved now with $GET['var'],
all forms-vars with $POST['var']

BuzzLY

ir4z0r is correct... if you turn off register_globals (which I recommend you do) then any code that uses variables passed by GET or POST must be fixed. I recommend that you fix it by setting the appropriate variables at the top of your page, rather than by substituting the $GET() statement directly in your SQL. Simply add:

$id = $_GET("id");
$blah = $_GET("blah");
//...etc

to the top of each page, and you should be OK.

Incidentally, you should code your pages like this all the time, regardless of whether register_globals is turned ON or OFF. This way, if it IS turned off, your pages won't break. It's a good habit to get into.