Boxxnews - opening on a _blank page

Siggles

Hi,

I'm trying to edit a PHP thing called Boxxnews that prints news onto your page and stores all the stories in a MySql database.

In the piece of code that runs the script there is a file called ubb.php included. In this .php page can be found:

// This is my link

$story1 = preg_replace('#[url=([a-z]+?://){1}(.?)](.?)[/url]#', '<a href="\1\2" target="$blankpage">\3</a>', $story1);

I added the target="$blankpage" to the piece of code as I wanted all the headlines to open in a seperate window

At the top of this page I have added code saying:

if($blank=="Y") {
$blankpage = "_blank";
}

Basically from the mysql database, a field called blank passses either a Y or a N to the page which has incliuded the ubb.php page.

At the bottom of the ubb.php page I have also added:

return $blankpage;

However when you view source of the page which displays the news it still says:

It hasn't changed the $blankpage to _blank.

What am I doing wrong?

Please help!!

cgraz

If you ever see a variable appear in your html source as you typed it, that means you didn't put it within php tags. The following two examples are different


<html>

<head>

<body>

$five = "5";

echo $five;

</body>

</html>

This example will literally print

$five = "5";echo $five;

because I didn't use PHP Tags.


<html>

<head>

<body>

<?

$five = "5";

echo $five;

?>

</body>

</html>

This example will actually print

because I put PHP within PHP tags. Take a look at your code and make sure you drop the PHP tags in the proper places.

Cgraz

Siggles

The whole ubb.php page is surrounded by the <?php tags as this is a behind the scenes page. There is no HTML in the page.

$story1 = preg_replace('#[url=([a-z]+?://){1}(.?)](.?)[/url]#', '<a href="\1\2" target=" $blankpage ">\3</a>', $story1);

Is it the preg_replace function that doesn't allow me to add a variable assigned higher up the page?

Even if I just write

$blankpage = "_blank";

at the top of the ubb.php page it still shows $blankpage on the on the resulting news page.

cgraz

I'm not sure if you can add the variable withing the reg exp. I'd just workaround it like this. Change your if to this:

if($blank=="Y") { 
   $blankpage = "_blank"; 
} else {
   $blankpage = "_self"; // keep in same window (i believe it's _self)
}

Then, in your reg exp

$story1 = preg_replace('#\http://([a-z/+?://){1}(.*?)\](.*?)\#', '<a href="\1\2" target="location">\3</a>', $story1); 

// then replace the word location with $blankpage
$story1 = str_replace("location", $blankpage, $story1);

Cgraz

Siggles

cgraz, you are a star. It worked. Thank you very much!!

See it at work on www.tlotr.com :-)

cgraz

looks good!

Cgraz