Uploading pic, change name to user id and put in folder.

[inkfish]

Hi,

I want to make so the users can upload their pictures, the pictures should be renamed to their user id.s (for example: 4.jpg) and be putted in the photos folder.

Thank you very much for helping me! =)

M. Lundberg

[chekote]

You need to supply WAY more information.

Where is the user ID coming from? A DB?

How much do you know?

Do you know how to upload the image?
Do you know how to save the image?

Give as much info as possible and people will be able to help...

[inkfish]

Hello agian,

okey sorry, here is alittle more information:

what i've got so far is:

if ($submit) {
	$tmpfile = $_FILES['userfile']['tmp_name'];
	$file = $_FILES['userfile']['name'];
	move_uploaded_file("tmpfile","$rootpath2/uploads/$file");
}

and the form:

<form action="<? print $PHP_SELF ?>" method="post" enctype="multipart/form-data">
  	<input name="MAX_FILE_SIZE" type="hidden" value="300000">
	<input type="file" name="userfile">
	<input name="submit" type="submit" value="Ladda upp mitt foto!">
  </form>

the user_id comes from a database and lies in the variable: $user_row['id']

Right now the file isn't even uploaded to the path i've selected.

Thanks again!

[chekote]

if ($submit) {
    $tmpfile = $_FILES['userfile']['tmp_name'];
    $file = $_FILES['userfile']['name'];
    move_uploaded_file("tmpfile","$rootpath2/uploads/$file");
}

You need to change the "tmpfile" to $tmpfile, because its a variable not a string. e.g."

move_uploaded_file($tmpfile,"$rootpath2/uploads/$file");

Try that first and tell me how it goes.

[inkfish]

hehe, that was easy =P Thanks!

BUT still... ...how do i change the name of the uploaded file to $row['id].jpg ??? =) (ex. 5.jpg)

[chekote]

Assuming you have a valid SQL result row in $row an associative array (Using mysql_fetch_array), you would do it as follows:

if ($submit) {
    $tmpfile = $_FILES['userfile']['tmp_name'];
    $file = $_FILES['userfile']['name'];
    move_uploaded_file($tmpfile,"$rootpath2/uploads/".$row['id'].".jpg");
}

I removed:

    $file = $_FILES['userfile']['name'];

because since you are renaming the file you dont really need that anymore.

[inkfish]

okey, i made it work but now when i want to check so that the file they upload is a .jpg file and that the size isn't bigger then 300kb i tried this (i said $row[id] before but it is $user_id[member_id]):

if ($submit) {
		if ($_FILES['userfile']['type'] == "image/jpeg") {
			if ($_FILES['userfile']['size'] <= 300000) {
				$user_info = mysql_fetch_array(mysql_db_query($db_name, "SELECT member_id FROM $tbl_member WHERE login='$login'"));
				$tmpfile = $_FILES['userfile']['tmp_name'];
				$file = "$user_info[member_id].jpg";
				move_uploaded_file("$tmpfile","$rootpath/uploads/$file");
				showmessage('Sådär, du kan folk se hur du ser ut också (förhoppningsvis)');
			} else { showmessage('Filen du laddar upp får inte vara större än 300Kb.'); } 
		} else { showmessage('Filen du laddar upp måste vara en jpeg fil.'); }
	}

okey i can change the renaming thing to what u wrote, but why doesn't this work now when i added the checks if it is a jpeg file and if the size is or smaller then 300kb? before i added the 2 extra if's this worked.

[chekote]

You say it isnt working but you didnt say what it did exactly?

Does it say the file is too big? or does it act like everything is ok but still doest work?

There are a couple of things I would change, but I dont know if they are causing a problem since you didnt realy specify what was happening.

I never use arrays inside a string e.g. "$user_info[member_id].jpg" I always anchor them to the string like so:

$user_info[member_id].".jpg"

Seems to work a lot more reliably that way.

I have changed your code accordingly:

if ($submit) {
        if ($_FILES['userfile']['type'] == "image/jpeg") {
            if ($_FILES['userfile']['size'] <= 300000) {
                $user_info = mysql_fetch_array(mysql_db_query($db_name, "SELECT member_id FROM $tbl_member WHERE login='$login'"));
                $tmpfile = $_FILES['userfile']['tmp_name'];
                $file = $user_info[member_id].".jpg";
                move_uploaded_file($tmpfile,"$rootpath/uploads/$file");
                showmessage('Sådär, du kan folk se hur du ser ut också (förhoppningsvis)');
            } else { showmessage('Filen du laddar upp får inte vara större än 300Kb.'); } 
        } else { showmessage('Filen du laddar upp måste vara en jpeg fil.'); }
    }

[inkfish]

Okey i changed it but it still doesn't work, it goes on like nothing is wrong but no file gets uploaded... i worked greate before i added the:

if ($FILES['userfile']['type'] == "image/jpeg") {
if ($FILES['userfile']['size'] <= 300000) {

hmmmmmmm........

[chekote]

You have a few "showmessage" in there. Which ones are being shown when you run the script?

Preferably translated, I cant read swedish =0).

[inkfish]

No one of the showmessage is being run, the page just work as the pic has been uploaded, but it hasn't.

the language is swedish =P

[chekote]

I cant see any obvious errors in your code.

Just throw some more error traps and debug statements in there. I would recommend splitting up your MySQL Query and the MySQL Fetch Array into seperate statements and then test them seperately with echo or showmessage to make sure they are doing what they are supposed to.

You should also do a echo/showmessage of all your variables just before you do the move_uploaded_file.

See if you notice anything thats wrong.

btw, I said swedish!

Really, I did. I swear....

[rheroux]

Well, here's a script I use for uploading files and checking filesize and image type. Take from it what you will. 🙂

Oh, and the teamcontentpanel() calls are just a user defined function I use for a table that is consistently displayed.

<?php

if($_POST['upload'])
{

// The directory that the uploaded file will be placed.

$dir = "images";

// The name of the uploaded file.

$upfile_name = $_FILES['upfile']['name'];

//Getting the extension

$excheck = substr($upfile_name,-3,3);

// Getting the file size of the image

$filesize = filesize($upfile);

// Validating the extension

if($excheck != "jpg" && $excheck != "gif" && $excheck != "png")
{
teamcontentpanel();
?>
<br>
</td>
<td valign="top" colspan="6" width="95%">
<table height="100%" cellspacing="0" cellpadding="0" width="100%" border="0">
<tbody>
<tr>
<td background="images/index_14.gif" height="27" colspan="5">&nbsp;&nbsp;
<span class="header">Upload New Image</span>
</td>
</tr>
<tr>
<td class="body" style="padding-left: 4px; padding-right: 4px; padding-bottom: 10px" valign="top" width="100%" bgcolor="#ffffff"><br>
<br>
Wrong file extension!  Only jpg, gif and png are allowed.
<td style="padding-top: 4px" valign="top" align="middle" bgcolor="#ffffff" colspan="4" rowspan="2">
</td>
<?php
exit;
}

// Validating filesize of image

if($filesize > 307200)
{
teamcontentpanel();
?>
<br>
</td>
<td valign="top" colspan="6" width="95%">
<table height="100%" cellspacing="0" cellpadding="0" width="100%" border="0">
<tbody>
<tr>
<td background="images/index_14.gif" height="27" colspan="5">&nbsp;&nbsp;
<span class="header">Upload New Image</span>
</td>
</tr>
<tr>
<td class="body" style="padding-left: 4px; padding-right: 4px; padding-bottom: 10px" valign="top" width="100%" bgcolor="#ffffff"><br>
<br>
Filesize is too big!  It has to be less than 300K.
<td style="padding-top: 4px" valign="top" align="middle" bgcolor="#ffffff" colspan="4" rowspan="2">
</td>
<?php
footerpage();
exit;
}


// if no file was uploaded

if (($_FILES['upfile']['name'] == ""))
{
teamcontentpanel();
?>
<br>
</td>
<td valign="top" colspan="6" width="95%">
<table height="100%" cellspacing="0" cellpadding="0" width="100%" border="0">
<tbody>
<tr>
<td background="images/index_14.gif" height="27" colspan="5">&nbsp;&nbsp;
<span class="header">Upload New Image</span>
</td>
</tr>
<tr>
<td class="body" style="padding-left: 4px; padding-right: 4px; padding-bottom: 10px" valign="top" width="100%" bgcolor="#ffffff"><br>
<br>
No file Uploaded. Please go back and try again.
<td style="padding-top: 4px" valign="top" align="middle" bgcolor="#ffffff" colspan="4" rowspan="2">
</td>
<?php
exit;
}

// if a file with that name already exists on server

if (file_exists($dir."/".$upfile_name))
{
teamcontentpanel();
?>
<br>
</td>
<td valign="top" colspan="6" width="95%">
<table height="100%" cellspacing="0" cellpadding="0" width="100%" border="0">
<tbody>
<tr>
<td background="images/index_14.gif" height="27" colspan="5">&nbsp;&nbsp;
<span class="header">Upload New Image</span>
</td>
</tr>
<tr>
<td class="body" style="padding-left: 4px; padding-right: 4px; padding-bottom: 10px" valign="top" width="100%" bgcolor="#ffffff"><br>
<br>
A file with that name already exists on server. Please go back and try again.
<td style="padding-top: 4px" valign="top" align="middle" bgcolor="#ffffff" colspan="4" rowspan="2">
</td>
<?php
}

else
{

// upload file

if (is_uploaded_file($upfile)) 
{

// set directory where you will be uploading (CHMOD to 777 first.)

chmod($dir,777);

// Copy the uploaded file to the directory.

copy($_FILES['upfile']['tmp_name'], $dir."/".$upfile_name);

// Change the directory back for security.  (Usually 744, or 644.)

chmod($dir,744);

teamcontentpanel();
?>
<br>
</td>
<td valign="top" colspan="6" width="95%">
<table height="100%" cellspacing="0" cellpadding="0" width="100%" border="0">
<tbody>
<tr>
<td background="images/index_14.gif" height="27" colspan="5">&nbsp;&nbsp;
<span class="header">Upload New Image</span>
</td>
</tr>
<tr>
<td class="body" style="padding-left: 4px; padding-right: 4px; padding-bottom: 10px" valign="top" width="100%" bgcolor="#ffffff"><br>
<br>
File Uploaded Successfully.
<td style="padding-top: 4px" valign="top" align="middle" bgcolor="#ffffff" colspan="4" rowspan="2">
</td>
<?php
}
}
}


// Show the initial upload form.

else
{
teamcontentpanel();
?>
<br>
</td>
<td valign="top" colspan="6" width="95%">
<table height="100%" cellspacing="0" cellpadding="0" width="100%" border="0">
<tbody>
<tr>
<td background="images/index_14.gif" height="27" colspan="5">&nbsp;&nbsp;
<span class="header">Upload New Image</span>
</td>
</tr>
<tr>
<td class="body" style="padding-left: 4px; padding-right: 4px; padding-bottom: 10px" valign="top" width="100%" bgcolor="#ffffff"><br>
<br>
Browse for a file below to upload a new file.<br>
<br>
File size must be less than or equal to 300K.<br>
<br>
Only jpg, gif and png image format are allowed.<br>
<br>
<strong>Note:</strong> Once you have successfully uploaded a new image, your old image will be deleted!<br>
<br>
<table width="400" border="0" cellpadding="5" cellspacing="0">
<form method="post" action="?page=content/team/upload" enctype="multipart/form-data">
<tr>
<td class="body">
File:
</td>
<td class="body">
<input type="file" name="upfile">
</td>
</tr>
<tr>
<td colspan="2" class="body">
<input type="submit" name="upload" value="Upload">
</td>
</tr>
</form>
</table>
<td style="padding-top: 4px" valign="top" align="middle" bgcolor="#ffffff" colspan="4" rowspan="2">
</td>
<?php
}
?>

[Ma7bob]

actually i am trying your script on my web .. i just removed the teamcontentpanel() from the script ... but when i try to upload the files it will say that it uploaded them successfuly but i can find nothing in the uploaded folder .. all i did is remove the teamcontentpanel() function and change $dir = "testDir"; .. do i need to do something else to make it work ?

Thank you for providing your script 🙂