Login Error...

[buddysal]

$user = "buddysal_admin";
$pass = "3585835";
$db = "buddysal_MEMBERS";
$link = mysql_connect( "localhost", $user, $pass );
mysql_select_db( $db );
$login = mysql_query( SELECT * FROM MEMBERS WHERE 
username=['$username'] AND password=['$password'] );
if (! $login ) {
echo redirect_page(Login was a success!<br />You are 
being redirected to the members area!', 'members.php');
}else{
echo redirect_page('Wrong Username or 
Password.<br />Please try and again', 'index.php');
}

parse error line 7

[buddysal]

$user = "buddysal_admin";
$pass = "3585835";
$db = "buddysal_MEMBERS";
$link = mysql_connect( "localhost", $user, $pass );
mysql_select_db( $db );
$login = mysql_query( SELECT * FROM MEMBERS WHERE 
username=['$username'] AND password=['$password'] );
if (! $login ) {
echo redirect_page(highlight('Login was a success, you are being redirected to the members area!.'), 'members.php');
}else{
redirect_page(highlight('Username or password was wrong, please try again.'), 'index.php');
}

fixed the redirect's but i still get the line 7 error.

[rIkLuNd]

Firstly, you can't just do username=['username']. Where do you get username from?

[buddysal]

yikes i forgot to $GET['$username']; and $GET['$password'];

[rIkLuNd]

I would do like this:

$login = mysql_query("SELECT * FROM MEMBERS WHERE 
username='" . $_GET['$username'] . "' AND password='" . ['$password'] . "'");

[buddysal]

ok got everything fixed exept its not giving me the error message when i tpye a wrong user name in... i always get the Login Success

[buddysal]

<?PHP
function validate_user ($username, $password)
{
return true;
}

$errors = array();
$p =& $_POST;

if (count ($errors) == 0)
{
$user = "buddysal_admin";
$pass = "3585835";
$db = "buddysal_MEMBERS";
$link = mysql_connect( "localhost", $user, $pass );
mysql_select_db( $db, $link );

$query = mysql_query("SELECT * FROM MEMBERS WHERE username=['$username'] AND password=['$password']");
if (! $query ) {
print "<font size=2>Login Failed. Try again.</font>";
}
else 
{
print "<font size=2>Login was a success!</font>";
}
}
?>
<form action="<?PHP print($PHP_SELF); ?>" method="POST">
                            <p><font size="2">Enter Username</font><br>
                            <input type="text" size="15"
                            name="username"
                            style="background-color: #DFDFDF"
                            style="border: thin solid #CDCDCD"
                            style="color: #626262"
                            style="letter-spacing: -1px"
value="<?PHP if (isset($p['$username'])) print $p['username']; ?>"><br>
                            <font size="2">Enter Password</font><br>
                            <input type="password" size="15"
                            name="password"
                            style="background-color: #DFDFDF"
                            style="border: thin solid #CDCDCD"
                            style="color: #626262"
                            style="letter-spacing: -1px"><br>
                            <input type="submit" name="B1"
                            value="Login Now"
                            style="background-color: #DFDFDF"
                            style="border: thin solid #CDCDCD"
value="<?PHP if (isset($p['$password'])) print $p['password']; ?>"></p>
                        </form>

thats my whole freaking login script, its not validating user anems and passwords for some reason.. any ideas?