Insert issue.

[pinehead18]

<form method="post" action="<?php echo $PHP_SELF; ?>">

First name:<input type="Text" name="Author"><br>

Comment:<input type="Text" name="subject"><br>

Address:<input type="Text" name="body"><br>

<input type="Submit" name="submit" value="Submit">

</form>

<?php

if ($submit) {
$id = $_GET[id];

$con = mysql_connect();
$db = mysql_select_db("pinehead", $con) or die(mysql_error());

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$author','$subject', $id)";

$result = mysql_query($sql);

mysql_close($con);
?>

Ok the point of this is, if the submit botton on the form is pushed. THEN post the data. But it doens't work.. and when it did work all i got was 0 that posted into the db. So its not working to its intnded use wich is if the submit button is pushed then enter the TEXT data in the form into the db. Which if it enters anything is just a 0.

Thanks for your help.

PiNeHeAd

[khaldryck]

$id=$GET[id] ...
your form is in POST method ...
so $GET[id] is 0
by the way, $_POST[id] would have the same value, you never submit any id in your form.

i suppose your table is indexed on id which must be unique.
so when it tries to insert again, it can't as 0 is already in the DB
remove this id thing, and put the id of your table as auto_increment.
that should resolve things

[Radon3k]

<form method="post" action="<?php echo $PHP_SELF; ?>"> 

First name:<input type="Text" name="Author"><br> 

Comment:<input type="Text" name="subject"><br> 

Address:<input type="Text" name="body"><br> 

<input type="Submit" name="submit" value="Submit"> 

</form> 

<?php 

if ($submit == $Submit) { 
$id = $_POST[id]; 

$con = mysql_connect("localhost", "username", "password"); 
$db = mysql_select_db("pinehead", $con) or die(mysql_error()); 

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$author','$subject', $id)"; 

$result = mysql_query($sql); 


mysql_close($con); 
?>

You were missing (unless you purposely didn't put it there) the db connection info. I also added a bit in the if statement. See if that works.

[cgraz]

radon: wouldn't your if statement need to be

if($submit == "Submit")

$submit is always going to equal itself. Another way (more common) of checking if the form has been submitted is using the isset() function

if(isset($_POST['submit'])) {

Also, $GET['id'] should be $POST['id'] as khaldryck mentioned. (just a note to pinehead18 in case he ends up using your code). Little things like that can seem impossible to find sometimes.

Cgraz

[Radon3k]

oops, didn't even notice that. Thanks cgraz. 🙂

[pinehead18]

<form method="post" action="<?php echo $PHP_SELF; ?>">

First name:<input type="Text" name="Author"><br>

Comment:<input type="Text" name="subject"><br>

Address:<input type="Text" name="body"><br>

<input type="Submit" name="submit" value="Submit">

</form>

<?php

if($submit == "submit") {
$id = $get[id];
// i tried $id = $post[id]; and it still did not work

$con = mysql_connect(i took the info here out);
$db = mysql_select_db("pinehead", $con) or die(mysql_error());

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$author','$subject', $id)";

$result = mysql_query($sql);

mysql_close($con);

echo "poop";
}

Well this is my code, and for some reason when i click on the submit button it does nothing.

Any new suggestions for me?

Thanks
Anthony

[Radon3k]

if($submit == "submit")

// Should be

if($submit == "Submit")

🙂

[cgraz]

echo "poop";

C'mon now. Don't you have anything better to echo than that? :mad:

Cgraz

[pinehead18]

I tried it with the capital s as well it didn't do anything.

Anthony

[Radon3k]

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$author','$subject', $id)";

// Shouldn't this be:

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$author','$subject', '$id')";

// ?

[pinehead18]

Well I made those changes too. But, its not even echoing poop so could it be that its not reading the if submit?

if($submit == "Submit") {
$id = $_get[id];

$con = mysql_connect();
$db = mysql_select_db("pinehead", $con) or die(mysql_error());

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$author','$subject', '$id')";

$result = mysql_query($sql);

mysql_close($con);

echo "poop";
}

That is the code i'm now using and what happens is the page does re-set becuase of the form $php_self item, but nothen happens but the form just clears. It wont even echo poop.. So isn't it sounding sql isn't even getting a chance to insert the info?

[Radon3k]

<form method="post" action="<?PHP_SELF?>">
First name:<input type="Text" name="Author"><br> 
Comment:<input type="Text" name="subject"><br> 
Address:<input type="Text" name="body"><br> 
<input type="Submit" name="submit" value="Submit"> 
</form> 

<?php 

if ($_POST['submit'] == "Submit") { 
$id = $_POST['id']; 

$con = mysql_connect("server", "username", "password"); 
$db = mysql_select_db("pinehead", $con) or die(mysql_error()); 

$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$Author','$subject', '$id')"; 

$result = mysql_query($sql);
if(!$result) {
echo("Query failed.");
exit();
}
}

mysql_close($con); 
?>

I made a few changes in the code, try this.

[pinehead18]

Still doens't post anything even with the if (!result) only thing is though didn't you leave that in the if loop, as if submit==true? I still don't think its doing anything with the idea , if submit was pushed then do this.

[Radon3k]

Did you change the action like I had in my post as well as the $Author? I changed some more things, see the example above.

[pinehead18]

yes, i changed everything.. But get this.. I created just an if statement for the page. no sql no anything. and nothing happens. So it has to be our if statement for some reason.

<form method="post" action="<?PHP_SELF?>">
First name:<input type="Text" name="Author"><br>
Comment:<input type="Text" name="subject"><br>
Address:<input type="Text" name="body"><br>

<input type="Submit" name="submit" value="Submit">

</form>

<?php

if ($submit == "Submit") {

	echo "The submit button works!";
}else{
	echo "Damnit";
}


include('footer1.php');

?>

Now take a look, what i think i have it set to, is if the submit button is clicked. Then echo the submit button works. else damnit.

Well just when i load the page for the first time, it goes strait to damnit. verses not posting anything until the button is clicked.

Any idea?

[Radon3k]

Just for grins and giggles, try making your input types either all caps or all lower case, not "Text", but "text" or "TEXT". That's probably not it, but it never hurts to at least check it.

[cgraz]

<form method="post" action="<?PHP_SELF?>">

$PHP_SELF is a predefined variable, you need to use the dollar sign before it so that it's treated as a variable, and you also need to echo it.

<?= $PHP_SELF ?>

or

<? echo $PHP_SELF; ?>

Also, I'd suggest using the superglobal $_POST (since php does set globals to off by default). And instead of checking if the form was submitted the way you are, try using isset()

if (isset($_POST['submit'])) {

Cgraz

[pinehead18]

Ok, well now we fixed the if statement issue. Now the only problem is when i go to echo $body from the form, it does not echo anything. Now it is not reading the form. My code is as follows.

I would also like to say thank you for those of you who are helping me with this issue.

<?php
include('functions.inc');
include('header1.php');

?>

<form method="post" action="<? echo $PHP_SELF; ?>">
First name:<input type="Text" name="Author"><br>
Comment:<input type="Text" name="subject"><br>
Address:<input type="Text" name="body"><br>

<input type="Submit" name="submit" value="Submit">

</form>

<?php

if (isset($_POST['submit'])) { 


$con = mysql_connect();
$sql = mysql_select_db("pinehead", $con);	
$sql = "INSERT INTO comments (body,author,subject,id) VALUES ('$body','$Author','$subject', '$id')"; 
$result = mysql_query($sql);
echo "POOOOP";
echo $subject;
echo $body;

\ It will echo poop but it will not echo $subject or $body nor will it post anything in the db.

}else{
	echo "Damnit";
}


include('footer1.php');

?>

[cgraz]

You have globals set to off. Use $_POST for all form variables passed with a method of post.

$con = mysql_connect(); 
$sql = mysql_select_db("pinehead", $con);

$sql = "INSERT INTO comments (body,author,subject) VALUES ('" . $_POST["body"] . "',
'" . $_POST["Author"] . "','" . $_POST["subject"] . "')"; 
print $sql . "<br>"; // for error checking
$result = mysql_query($sql) or die(mysql_error()); // also for error checking 

Cgraz

[pinehead18]

INSERT INTO comments (body,author,subject) VALUES ('a', 'a','a','')
Column count doesn't match value count at row 1

???

a a a was the info i entered into the 3 txt box's.

I coded all these insert statements about a year ago, and they actually worked. I don't remember it being this hard.

Any ideas on this error?