UPDATE (mysql_query)

Chris_Evans

Hi - I appear to have a slight problem with this mysql query.... when I use this code below I get a "Could not connect to database."...

$sql = mysql_query("UPDATE news WHERE id='$id' SET title='$newstitle' AND body='$newsbody'")
	or die("Could not connect to the database.");

header("location: $siteurl/admin/update.php?type=news&way=edited");

and when I use this code below it changes my titles to 0 and doesn't do anything with the body...

$sql = mysql_query("UPDATE news SET title='$newstitle' AND body='$newsbody' WHERE id='$id'")
	or die("Could not connect to the database.");

header("location: $siteurl/admin/update.php?type=news&way=edited");

Does anybody have any ideas? All of the variables do exist.

Thanks.

cool-palace-ceo

This may sound a little dumb but, did you make a connection to the database in the first place and pick the database that, that table is in???

the query looks okay

Chris_Evans

yes - but the strange thing is that the query does exactly the same thing as I stated above in phpmyadmin yet when you use "Insert" link in phpmyadmin it works fine.

sarahk

the second snippet looks to be in the better format but don't know if there are hard and fast rules about this. I'd echo out the line and see what it looks like, then paste into phpMyAdmin and see if it gives an error message. It might just be that something unpredicatable is in there that you can't see until it's run.

$sqlstring = "UPDATE `news` SET `title`='$newstitle' AND `body`='$newsbody' WHERE `id`='$id'";
echo "$sqlstring<br>";
$sql = mysql_query($sqlstring)
    or die("Could not connect to the database.");

//header won't work until the echo is removed. 
//header("location: $siteurl/admin/update.php?type=news&way=edited");

and finally, are you THE Chris Evans, the radio star?

sarahk

Chris, we must have been posting at the same time. If you update isn't working from phpMyAdmin then it won't work from php - so get it straight there first.

maybe post an example of an insert statement that works and an update that doesn't.

Chris_Evans

Without showing off to much, no I'm not but I was on the UK national news in the newspapers and TV for being the youngest PC technician in the world and youngest networking technician..

A+, Network+, INET+, CIW Master, CIW E-Commerce, CIW Designer, MCP Professional, MCP Server, getting MCSA.

😃 lol I'm not that interested in music so I wouldn't be. 🙂

Thanks for your help, I'm just about to try your query now.

Chris

Chris_Evans

Originally posted by sarahk
Chris, we must have been posting at the same time. If you update isn't working from phpMyAdmin then it won't work from php - so get it straight there first.

maybe post an example of an insert statement that works and an update that doesn't.

Sure - this INSERT statement works, but the strange thing about this is that I haven't changed it and it worked about an hour ago.

Maybe I'll try a restart.

$sql = mysql_query("INSERT INTO news (title,body,date,postby) values ('$newstitle','$newsbody',now(),'$username')")
	or die("Could not connect to the database.");

Chris_Evans

Ok - well that didn't work. he he. 🙂 What's worse is that this is the same as the query used in the mysql manual and it doesn't work in phpmyadmin "sql" code.

mwichmann4

This is how I structure my connection and statments

$db_conn = mysql_connect("localhost","root","");
mysql_select_db("bids",$db_conn);

$query = mysql_query("select * from table",$db_conn);

That could be your problem forgetting to put the connection at the end.

sarahk

there are also some excellent classes which you could use to manage this stuff seamlessley. Simpler code as your scripts can focus on what they do (including formatting sql statements), not database handling.

Chris_Evans

Classes, haven't done them yet. :S - Also, I looked a phpfreaks.com and found an example of an update query, there's nothing different about it so I can't see why it refuses to work.