Smarty + Javascript = Trouble

[agent_mandarin]

Hi I’ve been using the smarty template engine to separate my presentation code from my logic code. It all worked well until I decided to incorporate a dropdown menu using Javascript as soon as I did this I got the following error message.

Fatal error: Smarty: [in about.tpl line 9]: syntax error: unbalanced parenthesis in if statement (Smarty_Compiler.class.php, line 1110) in c:\PHP\includes\Smarty_Compiler.class.php on line 1857

I’ve tried adding and removing parenthesis in logical places to fix the problem but nothing seems to work. Here is a snippet of the offending code any suggestions?

<script language="JavaScript" type="text/JavaScript">
function mmLoadMenus() {
if (window.mm_menu_0302213734_0) return;
window.mm_menu_0302213734_0 = new Menu("root",184,18,"Verdana, Arial, Helvetica, sans-serif",12,"#000000","#666666","#B1B2B1","#FFFFFF","left","middle",3,0,300,-5,7,true,true,true,0,true,true);
mm_menu_0302213734_0.addMenuItem("Our&nbsp;Background","window.open('background.php', 'self');");
mm_menu_0302213734_0.addMenuItem("Our&nbsp;Philosophy","window.open('philosophy.php', 'self');");
mm_menu_0302213734_0.addMenuItem("Our&nbsp;Core&nbsp;Values","window.open('values.php', 'self');");
mm_menu_0302213734_0.addMenuItem("Our&nbsp;Corporate&nbsp;Objectives","window.open('objectives.php', 'self');");
mm_menu_0302213734_0.addMenuItem("Our&nbsp;Team","window.open('team.php', '_self');");
mm_menu_0302213734_0.hideOnMouseOut=true;
mm_menu_0302213734_0.bgColor='#666666';
mm_menu_0302213734_0.menuBorder=0;

[sarahk]

I don't know about smarty but most of the templates use {} to define the fields they will replace.

So, what do you think they are going to do when they hit a javascript function?

They are ok with javascript calls but not the definition of javascript functions.

Therefore you need to follow the "best practice" guidelines of any webpage and
move styles to a separate file (they use {} also)
move javascript functions to a separate file

The main benefits of this are
code is cached so loads faster the second time
code is less visible to a curious visitor
* search engines can get to your real code more quickly and are more likely to find what your site is really about.

[PHPThorsten]

Thats because you use the Smarty delimiters in your JS.

Have a look at this: http://smarty.php.net/manual/en/language.function.literal.php

You just have to put jour JS in these {literal} tags to tell Smarty not to parse these part.

[JF1980]

Could you create a plugin module out of the javascript?