sending mail in php

[d99kg]

Here is my code can anyone see any problems as I keep getting "Bad" echoed to the screen, I want to send an e-mail if the user had forgotton their password:

<?php

if($submit)
{
$db = mysql_connect("localhost", "d99kg", "password");
mysql_select_db("d99kg",$db);
$dbQuery="SELECT * FROM users where username='$theusername'";
$result = mysql_query($dbQuery,$db);

    $userInfo=mysql_fetch_array($result);
    $username=$userInfo["username"];
    $password=$userInfo["password"];
    $userFunctions=$userInfo["userFunctions"];
    $firstName=$userInfo["firstName"];
    $lastName=$userInfo["lastName"];
    $emailAddress=$userInfo["emailAddress"];


 $mailsubject = "Your password";
 $mailbody = "Your Password is $password";

 //if(mail($emailAddress, $mailsubject, $mailbody))
 //{  echo "XXX good";
 //}

$myname = "gk"; 
$myemail = "[e-mail]"; 


$message = "Your password is $password - Don't forget it again!"; 
$subject = "Your Password"; 

$headers .= "MIME-Version: 1.0\r\n"; 
$headers .= "Content-type: text/html; charset=iso-8859-1\r\n"; 
$headers .= "From: ".$myname." <".$myemail.">\r\n"; 
$headers .= "To: ".$firstName.$lastName." <".$firstName.$lastName.">\r\n"; 
$headers .= "Reply-To: ".$myname." <$myreplyemail>\r\n"; 
$headers .= "X-Priority: 1\r\n"; 
$headers .= "X-MSMail-Priority: High\r\n"; 
$headers .= "X-Mailer: Just My Server"; 

if (mail($emailAddress, $subject, $message, $headers))
{
echo "Good";
}
else echo "Bad"; 

}

?>

Cheers

[BuzzLY]

There could be a number of reasons it's not working.

First of all, is your SQL working? You are using $theusername -- is it set correctly? If not, and it's coming from a previous form, then register_globals is probably OFF, and you need to use $_POST['theusername'].

If that's not the problem, then echo your variables to the screen to make sure they are being set properly. If not, then there is your problem, and you can investigate.

Lastly, does the mail() command work if you hard code values into it? If not, then you have an issue with your mail server.

As far as your code goes, it seems ok, but I question the To: header. I don't think it's necessary, since you are using $emailaddress to specify the recipient. Try commenting out that line.

Hope this helps. Good Luck!