While loops and arrays

[Chris_Evans]

Hi there, I'm trying to get a while loop and array working.

Very simply the user starts on page1.php and types the number of links he/she would like to add to the database. Once typed in, it's passed through the use of a form to page2.php which very simply is designed to use a while loop and array to write the correct number of input tags (text) into the main page..

				$num = '0';
				$lnum = $_POST['rlinks'];
				While ($linput = array($lnum))
					{
					$num++
					echo '<input type="text" name="link $num" id="link $num">';
					}

But unfortunately, it doesn't work, any suggestions?

Thanks,

Chris

[Weedpacket]

All
$linput = array($lnum)
does is create an array called $linput containing a single element $lnum.

Fact is, there's no array involved (except for $_POST) anyway.

Why use a while loop when there is already a language construct for this job?

for($num=1; $num<=$lnum; $num++)
{ echo '<input type="text" name="link$num" id="link$num">';
}

If you want an array $POST['link'][] on the next page after this (which would be easier to work with than $POST['link1'], $POST['link2'], ..., 'specially since you'd have to figure out how high the numbers go (don't forget that empty fields aren't returned, so just 'cos there's no $POST['link5'] doesn't mean there's no $_POST['link6']...)):

echo '<input type="text" name="link[$num]" id="link[$num]">';

[Chris_Evans]

Hi there, thanks for that... I've got that working, but would you mind explaining the array you talked about for the mysql_insert query?

I got a little stuck on that... I've never done arrays before. he he. 🙂

Thanks,

Chris

[Chris_Evans]

Any help on what weedpacket suggested for the "mysql_query" would be greatly appreciated since I haven't done arrays yet..

I just need the two bits of coding for that query rather urgently..😕 thanks.. 🙂 Chris.

[dalecosp]

I don't see that he mentioned any mysql functions....

You did mention "the number of links the [user] wants to add to the database."

Probably you want a generic query string that contains the proper SQL syntax and identifies the appropriate array element; iterate through the array and do one query for each element to be inserted....

for $x=0; $x<count($WhateverArray); $x++) {
    $query="insert into table_name values '".$WhateverArray[$x]."'";
// insert statement goes here
    }

etc.....

Arrays aren't too difficult. A variable is one thing; an array is a bunch of things, and they each have a number ("key").... 🙂

[Chris_Evans]

Great, thanks for that! I'm learning more php by the day thanks to a friend and phpbuilder.. and everyone that's hear, which I believe is what this place is about.

Thanks,

Chris

[Chris_Evans]

Hi! 🙂 I've changed it slightly because I'm not used to that type of sql query... so I've done the following below, but I now have a parse error.. I've got rid of two of them already but I can't seem to find this one, any help would be appreciated.

for ($x=0; $x<count($link); $x++) {
    $sql = mysql_query("INSERT INTO links (sectionid,link) values ("$id",".$link[$x].")")
		or die("Could not connect to the database.");
    }

echo $sql;

Thanks,

Chris

[cgraz]

Use single quotes around the variables.

for ($x=0; $x<count($link); $x++) {
    $sql = mysql_query("INSERT INTO links (sectionid,link) VALUES('" . $id . "','" . $link[$x] . "')") or die(mysql_error());
    }

echo $sql;

Oh, and on a side note, you're printing $sql outside the for loop, rather than after it's executed each time.

Cgraz

[Chris_Evans]

hmm - to questions, firstly I can't tell but have I made a mistake in one of these two scripts?

This script submits the form:

<?php
Include("includes/confstring.php");
Include("includes/variables.php");
$link = "options.php";
Include("includes/sessions.php");
			If (!$_GET['id'])
				{
				header("location: $siteurl/admin/index.php");
				}
			else
				{
					$id = $_GET['id'];
				}
			If (!$_POST['rlinks'] AND $_POST['images'])
				{
				header("location: $siteurl/admin/index.php");
				}
			elseif ($_POST['rlinks'] == '0' AND $_POST['images'] == '0')
				{
				header("location: $siteurl/admin/index.php");
				}
			If (!$_POST['rlinks'])
				{
				}
			else
				{
					$lnum = $_POST['rlinks'];
				}
			If (!$_POST['images'])
				{
				}
			else
				{
					$imgnum = $_POST['images'];
				}

Include("templates/header.php");
Include("templates/fateam.css");
?>
			<table width="620" align="right">
			<tr>
				<td class="main">
				<form name="addparts" action="<? echo $siteurl ?>/admin/templates/insertil.php?id=<? echo $id ?>" method="post">
				Please add your related links and upload your images here.<br \n><br \n>
				<?
				echo 'Related links: <br \n>';
				for($num=1; $num<=$lnum; $num++)
				{ echo 'Link: <input type="text" name="link[$num]" id="link[$num]"><br \n>';
				}
				echo '<br \n> Images: <br \n>';
				for($fnum=1; $fnum<=$imgnum; $fnum++)
				{ echo 'Image: <input type="file" name="img[$fnum]" id="img[$fnum]"><br \n>';
				}
				?>
				<br \n><input type="submit" name="submit" value="Submit"><input type="reset" name="reset" value="Reset">
				</form>
				</td>
			</tr>
			</table>
<?
Include("templates/footer.php");
?>

and this bit is the bit with the for statement.

<?php
Include("../includes/confstring.php");
Include("../includes/variables.php");
$link = "insertil.php";
Include("../includes/sessions.php");

		If (!$_GET['id'])
			{
			header("location: $siteurl/admin/index.php");
			}
		else
			{
				$id = $_GET['id'];
			}

$username = $_SESSION['username'];
$rank = $_SESSION['user_rank'];
$link = $_POST['link'];
$image = $_POST['images'];



//Stripslashes
$newstitle = stripslashes($newstitle);
$newsbody = stripslashes($newsbody);

//Submit to mysql
for ($x=0; $x<count($link); $x++) {
    $sql = mysql_query("INSERT INTO links (sectionid,link) values ('" . $id . "','" . $link[$x] . "')")
		or die("Could not connect to the database.");
		echo $sql;
    }
?>

My echo $sql only show's '1' so I've done something wrong I presume.

Also, why do you use the . $id . instead of just '$id'?

Thanks,

Chris

[Chris_Evans]

to do with the way I've written the:

<input type="text" name="link[$num]" id="link[$num]">

and the...

$link = $_POST['link'];

Tags?