help with some if statments

[amarafzal]

Hi
I got some code and i cant get it working from below onwards. Also i dont know what error im getting even though i removed @ sign. Its something to do with some if statment i think. Can anyone help please?

<?
STOPS WORKING FROM HERE ONWARDS

$numofpages = $totalrows / $limit;  

for($i = 1; $i <= $numofpages; $i++){ 
    if($i == $page) 
        echo($i."&nbsp;"); 
    }else{
        echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;");  


if(($totalrows % $limit) != 0){ 
    if($i == $page) 
        echo($i."&nbsp;"); 
    }else{
        echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;"); 

if(($totalrows - ($limit * $page)) > 0){ 
    $pagenext     = $page++; 

    echo("<a href=\"$PHP_SELF&page=$pageprev\">NEXT</a>");  
}else{
    echo("&nbsp; NEXT ".$limit);  

mysql_free_result($result); 
}	[COLOR=red]STOPS WORKING FROM HERE ONWARDS[/COLOR]

[Tekron-X]

try using the php forum tags to color code next time it is above the " Insert a hyperlink into your message"

to me it looks like you are missing some { } in your if's

u got 8 places that need 2 curly and htat means u need 16 currly braces in all you only got 10 so you are missing 6 curly braces.

[sn0n]

shouldn't

if($i == $page)
echo($i." ");
}else{

look more like

if($i == $page) {
echo($i." ");
} else {

just a newbie programmer tryin to help.

also a word of GREAT advice (which is helping me ALOT), use a editor that show's 'lines' and read the error's they help you pinpoint the line that error'd and 9/10 tell you exactly whats wrong.

[jpmoriarty]

it is very difficult to see which braces are opening things, which ones are closing things, and which ones are in the wrong place.

My advice is to start braces on a new line and indent - that way you can clearly see what's going on:

instead of

for($i = 1; $i <= $numofpages; $i++){ 
if($i == $page) 
echo($i." "); 
}else{ 
echo("<a href=\"$PHP_SELF&page=$i\">$i</a> "); 


if(($totalrows % $limit) != 0){ 
if($i == $page) 
echo($i." "); 
}else{ 
echo("<a href=\"$PHP_SELF&page=$i\">$i</a> "); 

i would do:

for($i = 1; $i <= $numofpages; $i++)
{ 
   if($i == $page) 
      echo($i." "); 
}
else
{ 
   echo("<a href=\"$PHP_SELF&page=$i\">$i</a> "); 
   if(($totalrows % $limit) != 0)
   {
      if($i == $page)
         echo($i." ");
   }
   else
   { 
      echo("<a href=\"$PHP_SELF&page=$i\">$i</a> ");

etc etc

Makes it much easier to see where one starts if it's on the next line than if it's hidden at the end of a line.

and dont forget that if your if only contains one line then you dont need the braces:

if(this==that)
{
   then do this;
}
next do this;
// is the same as
if(this==that)
   then do this;
next do this;