Function not processing in an included file

[enfz]

Hey there,
Let me explain my problem. 🙂
This is my "main" function :

//Main function

function show_content($page) {
  show_header();
  include("content/$page.inc");
  show_review();
  show_footer();
}
?>

When it calls the file $page.inc..eg when ?page=test, then it will call test.inc for example. Inside the included file ( $page.inc ), it has all my html codes like tables etc. In there, I have:

 <?
 require("ads/config.inc.php3");
 require("ads/view.inc.php3");
 require("ads/acl.inc.php3");
 ?>

<?
view();
?>

It calls the banner and displays it. The problem is, it is not displaying the banner. If I put the above banner calling code in a php file (eg. banner.php) on its own, it will work no problem. I tried declaring $view as a global as well, and that didnt do much. Any ideas why when the code is within a file included in my "main" function doesnt show?
I've also try to include a text file, echo a line, all that works in my file. But not view().
Thanks.

[planetsim]

Never include a File that has includes/requires in it. You tend to get never ending loops or worse a server crash

[Codewarrior123]

I'm having the exact same problem... someone save us...

[BuzzLY]

Hmmm.... it's possible that it's having trouble with the file name. I am not sure how PHP handles variables when they are part of a file name (with the ".inc" extension).

Try this and see if it works correctly:

//Main function

function show_content($page) {
  show_header();
  $filename = "content/" . $page . ".inc";
  include($filename);
  show_review();
  show_footer();
}
?>

[laserlight]

hmm... in that case, wouldnt it be better to simply use:

//Main function

function show_content($page) {
  show_header();
  include('content/' . $page . '.inc');
  show_review();
  show_footer();
}

It will probably be a good idea to use .inc.php rather than just .inc extensions, or ensure .inc files are parsed as PHP files.

[enfz]

Thanks all, will try it and let you all know! 🙂

[BuzzLY]

Originally posted by laserlight
hmm... in that case, wouldnt it be better to simply use:
...
include('content/' . $page . '.inc');

Simpler, yes, of course. Better? I'm not so sure. In this particular instance, the PHP code is quite simple. However, most of the time PHP code is much more complex.

I have a tendency to use variables most of the time, even if it's only used once. You never know when you might need to modify the code and use the same string again elsewhere, and it's much more accessible if it's in a variable.

If I need to use a string anywhere in my PHP code, 99% of the time I will put it in a variable.

[Codewarrior123]

Still no luck on my end, but I know it's parsing the include in that It will properly execute 'echo' commands, and even recognize the global variables defined in the includes, ie:

(globals.php)

<?php

global $DBServer;
global $DBLogin;
global $DBPassword;

$DBServer = 'localhost';
$DBLogin = 'mylogin';
$DBPassword = '1234';

function DBConnect() { ... }

// REF: Echo Statment 1:
echo "$DBServer $DBLogin $DBPassword <BR>";

?>

(main.php)

<?

include 'globals.php';

// REF: Echo Statment 2:
echo "Database Server: DBServer <BR>";

DBConnect();
?>

Include and executes the 'echo' statement in the include file, outputting the values assigned to the globals, but fails to properly execute the second 'echo' statment, and reports a call to an undefined function when trying to executue 'DBConnect()' from main.php.

Despite what the PHP manual says, 'include' dosn't seem to be working. Anyone have any idea why this is happening?

[Codewarrior123]

No one has any witty comments?

[Codewarrior123]

Renaming the file with the '.inc' extention worked... I'd still like to know why this is the case -- anyone?