Sql insert error

klavis

Hey I am having some trouble inserting data into my sql database...really simple stuff...any idea whats wrong??

if ($roomNum <> 0) {
	@ $db = mysql_pconnect("acidburn.rit.edu", "gcr-klavis", "govrel");
if (!$db) {
	echo "Error: Could not connect to database.";
	exit;
}
		mysql_select_db("gcr-specialEvents");
		$sql = "INSERT INTO requests VALUES ('','$title','$organization','$contact','$phone','$fax','$address','$city','$state','$zip','$email','$dates','$dates','$startTime','$endTime','$setupTime','$roomNum','$roomStyle','$attending','$objective','$eventType','$fee','$feeAmount','$publicized','$parking','$cars','$handicapped','$security','$other','$ref1Name','$ref1Address','$ref1Phone','$ref2Name','$ref2Address,'$ref2Phone','$food','$foodNum','$alcohol','$foodType','$foodNeeds','$overnight','$overnightMax','$overnightMin','$airCond','$smoking','$linen','$checkIn','$checkOut','$early','$earlyWhen','$earlyNum','$late','$lateWhen','$lateNum','$roomSetup','$tables,'$draped','$chairs','$flipChairs','$podiums','$overheadPro','$microphones','$tvVcr','$slidePro','$chalk','$tape','$otherSetup')";		
		echo $sql;
		$result = mysql_query($sql);
		}

Thanks

Frederick

An insert query must be formated as such. This is just one method.

$sql = mysql_query("INSERT INTO requests (field1,field2) VALUES ('$field1','$field2')",$db)
or die(mysql_error());

You should not use mysql_pconnect for database connection because if not coded correctly, it keeps a connection alive to your MySQL. You want to disconnect connection after retrieving data. You need to include mysql_close( ) at the end of a mysql_pconnect( ).

Use mysql_connect( );

cgraz

An insert query must be formated as such.

That's not true. Although I also use this format, you can leave out the fields to input in. Mysql will input the values in order (except for the primary key).

As for your problem, you could be missing a quote, a comma, etc. use mysql_error() along with mysql_query to see what your problem is. If you have all your form fields matching the names of your database fields, then use a loop. It would be a lot easier and eliminate comma and quote mistakes.

foreach($_POST as $key => $value) {
   $keys[] = $key;
}

$sql = "INSERT INTO requests (" . implode(",", $keys) . ")";
$sql .= " VALUES('" . implode("','", $_POST) . "')";

$result = mysql_query($sql) or die(mysql_error());

Cgraz

Frederick

didn't know that. I have used the method as shown above as a standard and never tried it without.

klavis

well i am using php3 does that have any effect on anything???

cgraz

change $_POST to $HTTP_POST_VARS in the code I gave you.

Cgraz

pete_bisby

The variable $tables is missing the right-hand single quote.

Also make sure that the number of variables you are inserting matches the number of fields/attributes in your table - one extra or one less and your query won't work.