Why is this simple interbase update script not working?

bloomoon

i have this script within my submit.php page:

<?php
if ($clientname==""){
echo "The client name field must not be left blank. Click the BACK button on the browser toolbar to return to the form.";
}
else{
$tr = ibase_trans(IBASE_COMMITTED + IBASENOWAIT);
$sql="UPDATE CLIENT SET CLIENT_NAME='$clientname' WHERE CLIENT_ID='$clientid'";
$result=ibase_query($databasepath, $sql);
echo "The record has been altered successfully. Click here to return to the database.";
ibase_commit($tr);
ibase_free_result($result);
}
?>

The success message appears but my CLIENT table has not been updated. I have run an echo command on the variables $clientname and $clientid to make sure they are OK. i can also confirm that CLIENT_NAME and CLIENT_ID are valid columns within my table. Sorry but I dont understand where I am going wrong. Please can someone tell me what code I need to make it work?

barand

You are always printing the success message without checking it worked.

What happens if

if ($result=ibase_query($databasepath, $sql)) {
echo "The record has been altered successfully. Click here to return to the database."; 
ibase_commit($tr); 
}
else die ( ibase_errmsg());

bloomoon

i am getting the following 2 error messages:

Warning: ibase_query(): Dynamic SQL Error SQL error code = -104 Token unknown - line 1, char 1 localhost in /var/www/html/intranet/content/versioncontrol/submitediteddata.php on line 108

Warning: ibase_query(): Dynamic SQL Error SQL error code = -104 Token unknown - line 1, char 1 localhost in /var/www/html/intranet/content/versioncontrol/submitediteddata.php on line 109
Dynamic SQL Error SQL error code = -104 Token unknown - line 1, char 1 localhost

These refer to the following 2 lines:

$sql="UPDATE CLIENT SET CLIENT_NAME='$clientname' WHERE CLIENT_ID='$clientid'";
$result=ibase_query($databasepath, $sql);

my $databasepath must be OK because I can view data.
I have echoed $clientname and $clientid which show correct values.
I have manually ran this sql on my database:
UPDATE CLIENT SET CLIENT_NAME="Alison Field" WHERE CLIENT_ID=1 and this works.

Is it my SQL syntax? have you any ideas please?

bloomoon

i have fixed the problem barnard by replacing

$ibase_query($databasepath,$sql);
with
$ibase_query($sql);

is it possible i can get ur email adrres in case i have any more problems? 🙂