File upload

[Chris_Evans]

Hi there, I've just written a new script and it sort of works... the links section adds the links correctly (by the way since that works its not included 😉 ) but the following does not.

If (!$_POST['caption'])
	{
	}
	else
	{
	$cpt = $_POST['caption'];
	$cpt = stripslashes($cpt);
	$cpt = mysql_escape_string($cpt);
	}
If (!$_FILES['image'])
	{
	}
	else
	{
	$img = $_FILES['image'];
	$img = stripslashes($img);
	$img = mysql_escape_string($img);
	}

if ($_FILES['image']['type'] == "image/gif" OR "image/jpeg" OR "image/jpg"){
    copy ($_FILES['image']['tmp_name'], "files/images/".$_FILES['image']['name'])  

    or die ("Could not copy");
	$aimg = mysql_query("INSERT INTO images (sectionid,caption,image) VALUES ('" . $id . "','" . $cpt . "','" . $_FILES['name'] . "')")
		or die(mysql_error());
	}

I belive its something to do with the permissions but at the same time its not because I changed the permissions to write and its not working either... is it to do with my first line of the if ($_FILES..) statement?

Thanks,

Chris

[ir4z0r]

if a user doesn't choose a file $_FILES contains sometimes 'none'

uhmm, WHAT does not work?

[Chris_Evans]

It doesn't do anything at all, doesn't upload a file, nothing. I've even tried removing the jpeg and jpg allowed extensions and now I don't get an error message but nothing is uploaded either.

Thanks,

Chris

[cgraz]

what's your form look like? You do have enctype=multipart/form-data in the form tag, don't you?

Also, I'd drop your if statement to check the filetype until this is working. Once you get it working, then you can worry about adding that in. Also, echoing variables always helps.

Cgraz

[Chris_Evans]

Hi - no I didn't write that in my form, that might explain something! 🙂

Thanks,

Chris --- Also I'll show you some more code in a bit but I've got to go somewhere first. 😉

[Chris_Evans]

I've changed the form and it now uploads the image, the trouble is that it doesn't go in any folder and the page literally does nothing except add the links.

<?php
Include("../includes/confstring.php");
Include("../includes/variables.php");
$link = "insertil.php";
Include("../includes/sessions.php");

		If (!$_GET['id'])
			{
			header("location: $siteurl/admin/index.php");
			}
		else
			{
				$id = $_GET['id'];
			}

$username = $_SESSION['username'];
$rank = $_SESSION['user_rank'];

//Submit to mysql
	$link = $_POST['rlink'];
	$link = stripslashes($link);
	$link = mysql_escape_string($link);
$alink = mysql_query("INSERT INTO links (sectionid,link) VALUES ('" . $id . "','" . $link . "')")
	or die(mysql_error());

$cpt = $_POST['caption'];
$cpt = stripslashes($cpt);
$cpt = mysql_escape_string($cpt);

$img = $_FILES['image'];
$img = stripslashes($img);
$img = mysql_escape_string($img);

copy ($_FILES['image']['tmp_name'], "files/images/".$_FILES['image']['name'])  
or die(mysql_error());
$aimg = mysql_query("INSERT INTO images (sectionid,caption,image) VALUES ('" . $id . "','" . $cpt . "','" . $_FILES['name'] . "')")
	or die(mysql_error());

echo $alink;
echo $aimg;
echo $img

header("location: $siteurl/admin/addparts.php?id=$id");
?>

This is the last script I need to do and it doesn't work. 🙁

Any ideas?

Thanks in advance,

Chris

[ir4z0r]

I don't know about the folders, but your header() isn't working because you're echoing your variables.
header() doesn't allow output to come first

[Chris_Evans]

Hi - I got rid of that and I changed the file upload to the correct location :o 😃 and I got rid of the die mysql_error for inserting a picture! 😃 lol.

Now I've done that I get a "11Array"? Any ideas?

[Chris_Evans]

Hi - I haven't got any further with this.. it's getting a bit of a pain really. Any help would be greatly appreciated, or is it just not going to work?

Thanks in advance,

Chris

[cgraz]

I'm confused. What do you mean it uploads but it doesn't go in any folder? If it doesn't go in any folder, how do you know it's been uploaded. Also, on your INSERT, you try to insert

$_FILES['name']

should be

$_FILES['image']['name']

Cgraz

[Chris_Evans]

Hi, ok what I meant was that it loads the page but doesn't do anything and now I've finished changing it I've got

"11Array" written from the echo's... so basically:

1
1
Array

Is that correct? That's the output I get.. but basically only the links are inserted, nothing else happens.

I've changed the code:

<?php
Include("../includes/confstring.php");
Include("../includes/variables.php");
$link = "insertil.php";
Include("../includes/sessions.php");

		If (!$_GET['id'])
			{
			header("location: $siteurl/admin/index.php");
			}
		else
			{
				$id = $_GET['id'];
			}

$username = $_SESSION['username'];
$rank = $_SESSION['user_rank'];

//Submit to mysql
	$link = $_POST['rlink'];
	$link = stripslashes($link);
	$link = mysql_escape_string($link);
$alink = mysql_query("INSERT INTO links (sectionid,link) VALUES ('" . $id . "','" . $link . "')")
	or die(mysql_error());

$cpt = $_POST['caption'];
$cpt = stripslashes($cpt);
$cpt = mysql_escape_string($cpt);

$img = $_FILES['image']['name'];
$img = stripslashes($img);
$img = mysql_escape_string($img);

move_uploaded_file ($_FILES['image']['tmp_name'], "$siteurl/files/images/".$_FILES['image']['name']);
$aimg = mysql_query("INSERT INTO images (sectionid,caption,image) VALUES ('" . $id . "','" . $cpt . "','" . $img . "')")
	or die(mysql_error());

echo $alink;
echo $aimg;
echo $img;
?>

Hmm, now I get this message:

1
1
Image name.gif or whatever

But it doesn't upload anything.

So it's got to be something to do with this line:

    move_uploaded_file ($_FILES['image']['tmp_name'], "$siteurl/files/images/".$_FILES['image']['name']);

It also inserts the image name correctly into the database.. it just does not copy. :@ lol. 😃

Anything? Thanks in advance, Chris.

[cgraz]

how can $img insert properly into the database if when you echo it, it prints the word Array? I wouldn't create a new variable for the image name, I'd just use $FILES['image']['name']. I'd try changing the move_uploaded_file() to

 move_uploaded_file ($_FILES['image'], $siteurl . "/files/images/" . $_FILES["image"]["name"]);

you don't get any errors? I'd also echo out all your variables to see what values they have.

Cgraz

BTW, you say nothign else happens, but have you actually checked your server to see if the file was uploaded? (make sure to refresh your ftp client).

[Chris_Evans]

I thought I mentioned in my other post that I now had a name.gif inserted in the database...

No, it never worked before, it didn't write anything but "Array" into the database which wasn't good but the code I wrote above does work correctly.

It works correctly but it doesn't upload a file.

Thanks,

Chris

[Chris_Evans]

I should also point out that I have given full permission to the folder known as images and that's to the public. 😉

[Chris_Evans]

Ok, for the sake of it, I've tried using another method, and instead of using the url you can see I used:

/930549135139859035903285/htdocs bla bla - lol its fake but you know what I mean (the real url).

But it won't work that way either..
weird. Nobody has any ideas on this either. 🙁