$id=$_GET['id'];

jonathen

Hi,

OK, this is driving me nuts, and I know it's simple enough, but I cannot get my head round it.

I have a very simple script that displays my db entries on a while loop. Beneath each entry I have a "delete" link to delete just that entry from the db. However, I cannot get it to input the id at <a href=\"$PHP_SELF?id=$id\">Delete</a>

Above that line, I have specified the following line:
$id=$_GET['id']; in order for the script to get the particular id in the loop so that I can specify it on the delete link and remove it from db. But the link becomes: myscript.php?id= without specifying the id to be deleted.

What am I missing?

TIA

Jonathen

planetsim

Try chaning the $id in the url to $GET['id'] just to make sure that $GET['id'] has something. You should be able to tell because the url should be

myscript.php?id=1

If you dont have id in the url before that page thats why its not working.

jonathen

Yeah, I had tried that previously, and got the error:
Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING

jabi

Had one of those that drove me nuts! Finally solved it by applying the trim() function to the id and quoting the variable.

Try this:
$id=trim($_GET['id']);
And change the link to this:
<a href=\"$PHP_SELF?id='$id'\">Delete</a>

planetsim

get rid of the quotes on the $_GET['id'] so it displays like this

$_GET[id]

jonathen

Thank you both - however, I am still getting a url of myscript.php?id= with no actual id mentioned.

Madness!

matt_4013

Try this:

echo "<a href=\"".$_SERVER['PHP_SELF']."?id=".$_GET['id']."\">Linkname</a>";

jabi

OK. Back to start. You said

I have a very simple script that displays my db entries on a while loop.
Beneath each entry I have a "delete" link to delete just that entry from the db.

So, where is the $_GET['id'] coming from? Shouldn't this be the variable that you got from your select statement? Or am I missing something else here?

jonathen

OK, here is a snippet from my code:

$strSQL = mysql_query("SELECT * FROM $table ORDER BY id DESC");   

$num=mysql_numrows($strSQL);

mysql_close();

$i=0;
while ($i < $num) {
$col1=mysql_result($strSQL,$i,"col1");
$col2=mysql_result($strSQL,$i,"col2");       

$col3=mysql_result($strSQL,$i,"col3"); 
$id=mysql_result($strSQL,$i,"id");

...then echo the results, and one of the loops under the results is:

echo "<a href=\"delete.php?id=".$_GET['id']."\">Delete</a>";

As I said, something is missing here. Also, I have had to resort to calling a delete file which does the delete from mysql as I cannot figure out where to put the delete array.

Any ideas?

jabi

The $_Get['id'] is only used if the variable is retrieved from a url. It appears that you should be using just the $id (the name you assigned to the value when retrieving it from your database.

Since it hasn't been sent yet, there is nothing to GET.

jonathen

Just as you said that I tried it and it worked, lol - how stupid was I being, doh!

Thanks for your help!