sql to csv problem

[micmac]

Hi all,
Can anyone tell me how to fix the following problem.
Below in a section of a sql to csv script i am working on:

if (($go) && ($sql2csv)) { 
   mysql_pconnect($db_host, $user_nm, $password) or die( "Unable to connect to SQL server"); 
   @mysql_select_db($database) or die( "Unable to select database");
if($table == 'approved'){
   $sqlcont = "SELECT * FROM company_details WHERE type_email = 'accepted' AND client_update='yes'";
} else if($table == 'payment_details'){ 
   $sqlcont = "select * from payment_details";
} 
   $result = mysql_query($sqlcont);
   echo mysql_error(); 

   function make_csv_happy($string,$seperator) { 
      $string = trim($string); 
      if (eregi("\$seperator",$string)) { 
        $string = ereg_replace("\"", "\"\"", $string);
        $string = "\"".$string."\"";

  } 
  $string = ereg_replace(10, "", $string); 
  $string = ereg_replace("\r", "", $string); 
  return $string; 
   } 

   if (mysql_fieldname($result, 0) == "id") $first_field = "iD"; 

   while($col < mysql_numfields($result)) { 
      $fname  = mysql_fieldname($result, $col); 
      if ($col < mysql_numfields($result)-1)$comma = $seperator; 
      else $comma = ""; 
      if (($col == 0) && ($first_field)) 
         $names .= $first_field.$comma; 
      else 
         $names .= make_csv_happy(strtoupper($fname),$seperator).$comma; 
      $col++; 
   } 
   $final = $names."\n"; 
   while($row < mysql_numrows($result)) { 
      $col=0; 
      $line = ""; 
      while($col < mysql_numfields($result)) { 
         $fname = mysql_fieldname($result, $col); 
         if ($col < mysql_numfields($result)-1)$comma = $seperator; 
         else $comma = ""; 
         $line .= make_csv_happy(mysql_result($result,$row,$fname),$seperator).$comma; 
         $col++; 
      } 
      $final .= $line."\n"; 
      $row++; 
   } 
   if ($send) { 
      header("Content-disposition: filename=$table.csv"); 
      header("Content-type: application/octetstream"); 
      header("Pragma: no-cache"); 
      header("Expires: 0"); 
      $client=getenv("HTTP_USER_AGENT"); 
      if (ereg('[^(]*\((.*)\)[^)]*',$client,$regs)) { 
         $os = $regs[1]; 
         if (eregi("Win",$os)) $crlf="\r\n"; 
      } 
   } else { 
      echo "</center><p align=\"left\"><pre>"; 
   } 

   echo $final; 
   if (!$send) echo "</pre></p>"; 
}

Everything works fine except if a field in the database contains a "," it produces another column in the csv file.
Because i am using the "," as my seperator how can i get my csv results to display correctly?
I have tried ereg_replace(),preg_replace() to no avail.
Can any help me out on this one.

Cheers,
micmac

[cyclops]

you first need to detect if there is a comma in the current field
if a comma is found, surround the field by quotes
example
"12,23",44,222,"34,2",2

[micmac]

Thanks for the reply cyclops.

Can you explain where i should be detecting for a comma(s) and how?
Do i use str_replace?

Regards,
micmac

[cyclops]

use preg_match to detect if there is a comma in the current field
if there is a comma then $var = "\"$var\"";
else the $var is just $var

[cyclops]

lemme be nice and give u a start...
incorporate this where u check your var$

if (preg_match ("/\,/", $var)) {
    $var = "\"$var\"";
}

[micmac]

Thanks cyclops.

That will get me going.....thanks for your time 🙂

[micmac]

Can i ask one more question.
I got the preg_match to work successfully 😉

I have noticed that if the data, (from one of the database fields) contains a comma after a double line break then the same thing as before occurs.
My question to you is how can i check for a double line break in the field?

Cheers again,
micmac

[cyclops]

fiddle around with this example

<?php

$var = <<<END


,
END;

if (preg_match ("/(\r\n\r\n)/", $var)) {
    echo "there is a double linebreak";
    } else {
    echo "there is no double linebreak";
    }

?>

[micmac]

Thanks for your help cyclops.
All works great!

Cheers,
micmac

[cyclops]

😉 NP and Happy Coding !