Load inline images?

Gizzy

Hello, I'm making a webpage for my fiancee as a wedding presant (since it happens on the 11th I don't have too much longer to go!)

Well, I'm attempting to load an image inline (i have a photo album of sorts) and i'd liek to have it so that if you click on the image link (such as photos.php?img=/sam/001.jpg) it'll load in the page...

The best example that I have for this would be:
http://design.undergroundnews.com/sam/poetry.php?id=poetry/james/samantha.htm

When I attempt to use the same code for an image on the site I get:
error: parse error, unexpected '=' in /home/virtual/site5/fst/home/design/public_html/sam/photos/03282003/bigimages/untitled1.jpg on line 120
on:
http://design.undergroundnews.com/sam/poetry.php?id=photos/03282003/bigimages/untitled1.jpg

Anyone have any ideas? The code that I'm using to load the poetry inline is:

<?php
if(!$id)
{
        // Whatever you want to show if there's not a poem specified.
        // Maybe an error message, maybe a graphic, maybe a menu.
        include ("includes/include.poetry.htm");
}
else
{
        // Include the poem if it's specified, and do whatever else
        // you want if a poem is specified
	$http = strpos($id, "http");
	$ftp = strpos($id, "ftp");
	$https = strpos($id, "https");
	$dds = strpos($id, "../");
	if(is_integer($http) || is_integer($ftp) || is_integer($https) || is_integer($dds))
	{
		print "I'm sorry, your path has been filtered.";
		exit;
	}
        include($id);
}
?>

Thank you to everyone for your assistance.

matto

got it!

here:

{ 
// Whatever you want to show if there's not a poem specified. 
// Maybe an error message, maybe a graphic, maybe a menu. 
include ("includes/include.poetry.htm"); 
}

you are including html code into php! that code contains a = and php can't interpret it. do:

{ 
// Whatever you want to show if there's not a poem specified. 
// Maybe an error message, maybe a graphic, maybe a menu. 
$html = implode('', file("includes/include.poetry.htm")); 
echo $html;
}

Gizzy

Yeh we finally ended up with:

<?php
if(!$id)
{
        // Whatever you want to show if there's not a poem specified.
        // Maybe an error message, maybe a graphic, maybe a menu.
        include ("includes/include.galleries.htm");
}
else
{
        // Include the poem if it's specified, and do whatever else
        // you want if a poem is specified
	$http = strpos($id, "http");
	$ftp = strpos($id, "ftp");
	$https = strpos($id, "https");
	$dds = strpos($id, "../");
	if(is_integer($http) || is_integer($ftp) || is_integer($https) || is_integer($dds))
	{
		print "I'm sorry, your path has been filtered.";
		exit;
	}
        print "<img src=\"$id\">";
}
?>

Thanks though 🙂. We sat there for a few hours trying to figure out how to make it work with the less code and the fastest structure lol... Had to ban specific types (see the $http lines) so that people couldn't link elsewhere...

sarahk

your link is

http://design.undergroundnews.com/sam/poetry.php?id=photos/03282003/bigimages/untitled1.jpg

Now, assuming that you have something there for untitled1.jpg you can't just include it. You need something like:

<?
$image = $id;
$title="Whatever";
list($width, $height) = GetImageSize($image);
echo "<IMG SRC='$image' HEIGHT='$height' WIDTH='$width' ALT=\"$title\" BORDER='0'>";
?>

Gizzy

We ended with:
http://design.undergroundnews.com/sam/photos.php?id=photos/03282003/bigimages/untitled1.jpg

Gizzy

Ok, i have both of the scripts working perfectly (the one for text and the other for images), I'm curious though, is there anyway to have it specify an error message when something isn't found, other than:

Warning: Failed opening 'poetry/james/samantha.html' for inclusion (include_path='.:/php/includes:/usr/share/php:/usr/share/pear') in /home/virtual/site5/fst/home/design/public_html/sam/poetry.php on line 65

Examples:
Text: http://design.undergroundnews.com/sam/poetry.php?id=poetry/james/samantha.html
Image: http://design.undergroundnews.com/sam/photos.php?id=photos/03282003/bigimages/untitled11.jpeg

Thanks 🙂.

sarahk

check out file_exists()