if-elseif-logic too long???

[mabans]

/ Some of the evaluations for a five digit zip code always
go into the first if-statement ($zone = 8), allthough they shouldn't
Why?
Any help very much appreciated.
.

<?php

echo "<form method=post name=zipcodeinput id=zipcodeinput> <input name=zipcode type=text id=zipcode> </form>";

$HTTP_POST_VARS ['zipcode'];

if(strlen($zipcode) == 5)
{
	$zip = substr($zipcode, 0, 3);
	echo $zip;
	if(($zip >= 5 AND $zip <= 98) OR ($zip >= 100 AND $zip <= 212) OR
		($zip >= 214 AND $zip <= 268) OR ($zip >= 270 AND $zip <= 324) OR
		($zip >= 326 AND $zip <= 342) OR $zip == 344 OR ($zip >= 346 AND $zip <= 347) OR
		$zip <= 349	OR ($zip >= 362 AND $zip <= 363) OR ($zip >= 373 AND $zip <= 374) OR
		($zip >= 376 AND $zip <= 379) OR ($zip >= 398 AND $zip <= 399) OR 
		($zip >= 403 AND $zip <= 418) OR ($zip >= 425 AND $zip <= 426) OR
		($zip >= 430 AND $zip <= 459) OR ($zip >= 467 AND $zip <= 468) OR $zip == 470 OR
		$zip == 473 OR ($zip >= 480 AND $zip <= 497) OR ($zip >= 967 AND $zip <= 969) OR
		($zip >= 995 AND $zip <= 998))
		$zone = 8;
	elseif($zip == 325 OR ($zip >= 350 AND $zip <= 352) OR ($zip >= 354 AND $zip <= 361) OR
		($zip >= 364 AND $zip <= 372) OR $zip == 375 OR ($zip >= 380 AND $zip <= 397) OR
		($zip >= 400 AND $zip <= 402) OR	($zip >= 420 AND $zip <= 424) OR $zip == 427 OR
		($zip >= 460 AND $zip <= 466) OR $zip == 469 OR ($zip >= 471 AND $zip <= 472) OR
		($zip >= 474 AND $zip <= 479) OR ($zip >= 498 AND $zip <= 507) OR $zip == 509 OR
		($zip >= 520 AND $zip <= 528) OR ($zip >= 530 AND $zip <= 532) OR
		($zip >= 534 AND $zip <= 535) OR ($zip >= 537 AND $zip <= 567) OR
		($zip >= 580 AND $zip <= 583) OR ($zip >= 600 AND $zip <= 620) OR
		($zip >= 622 AND $zip <= 639) OR ($zip >= 650 AND $zip <= 653) OR
		($zip >= 700 AND $zip <= 701) OR ($zip >= 703 AND $zip <= 708) OR
		($zip >= 712 AND $zip <= 714) OR $zip == 716 OR ($zip >= 720 AND $zip <= 725) OR
		$zip == 999)
		$zone = 7;
	elseif($zip == 508 OR ($zip >= 510 AND $zip <= 516) OR ($zip >= 570 AND $zip <= 577) OR
		($zip >= 584 AND $zip <= 588) OR ($zip >= 592 AND $zip <= 595) OR $zip == 599 OR
		($zip >= 640 AND $zip <= 642) OR ($zip >= 644 AND $zip <= 649) OR
		($zip >= 654 AND $zip <= 658) OR ($zip >= 660 AND $zip <= 676) OR
		($zip >= 680 AND $zip <= 681) OR ($zip >= 683 AND $zip <= 693) OR
		($zip >= 710 AND $zip <= 711) OR ($zip >= 717 AND $zip <= 719) OR
		($zip >= 726 AND $zip <= 731) OR ($zip >= 733 AND $zip <= 738) OR
		($zip >= 740 AND $zip <= 741) OR ($zip >= 743 AND $zip <= 768) OR
		($zip >= 770 AND $zip <= 789) OR ($zip >= 795 AND $zip <= 796) OR $zip == 838 OR
		($zip >= 980 AND $zip <= 985) OR ($zip >= 990 AND $zip <= 992))
		$zone = 6;
	elseif(($zip >= 590 AND $zip <= 591) OR ($zip >= 596 AND $zip <= 598) OR
		($zip >= 677 AND $zip <= 679) OR $zip == 739 OR $zip == 769 OR
		($zip >= 790 AND $zip <= 794) OR ($zip >= 797 AND $zip <= 812) OR
		($zip >= 814 AND $zip <= 816) OR ($zip >= 820 AND $zip <= 837) OR
		($zip >= 840 AND $zip <= 844) OR ($zip >= 870 AND $zip <= 872) OR $zip == 875 OR
		$zip == 877 OR ($zip >= 881 AND $zip <= 885) OR $zip == 955 OR
		($zip >= 970 AND $zip <= 979) OR $zip == 986 OR ($zip >= 988 AND $zip <= 989) OR
		($zip >= 993 AND $zip <= 994))
		$zone = 5;
	elseif($zip == 813 OR ($zip >= 845 AND $zip <= 847) OR $zip == 850 OR
		($zip >= 852 AND $zip <= 853) OR ($zip >= 855 AND $zip <= 857) OR
		($zip >= 859 AND $zip <= 860) OR $zip == 865 OR ($zip >= 873 AND $zip <= 874) OR
		($zip >= 878 AND $zip <= 880) OR $zip == 893 OR ($zip >= 894 AND $zip <= 895) OR
		($zip >= 897 AND $zip <= 898) OR ($zip >= 939 AND $zip <= 954) OR
		($zip >= 956 AND $zip <= 966))
		$zone = 4;
	elseif(($zip >= 863 AND $zip <= 864) OR ($zip >= 889 AND $zip <= 891) OR
		($zip >= 931 AND $zip <= 938))
		$zone = 3;
	elseif(($zip >= 900 AND $zip <= 908) OR ($zip >= 910 AND $zip <= 918) OR
		($zip >= 922 AND $zip <= 928) OR $zip == 930)
		$zone = 2;
	elseif(($zip >= 919 AND $zip <= 921))
		$zone = 1;
	else
			$zone = 0;
	echo $zone;
}
else
	echo "Invalid Zipcode!";

?>

[ahundiak]

Yikes!

Build a function. Use && in place of AND.

function getZipCodeZone($zipcode)
{
  if (strlen($zipcode) != 5) return 0;

  $zip = (integer) substr($zipcode, 0, 3);

  if ($zip >= 5     && $zip <= 98) return 8;
  if ($zip >= 100 && $zip <= 212) return 8;

  /* And so on an so forth */

  return 0;
}

$zone = getZipCodeZone($zipcode);

Actually, since it look like zone is mainly a function of a range then you might try using an array of arrays with each entry containing a min and a max value.

[Weedpacket]

I had a look at it and figured it was a lot of hassle to go to every time you wanted to do what amounts to a table lookup.

Dunno if it's too long to run properly, but certainly looks too long to debug by eye... It's a lot of stuff to go through every time as well; it might be better to do it once (each time the mapping changes) and store the results in an array which can be included when needed.

I'll call the array $zone_mappings. It contains 1000 elements, numbered 0 to 999.

First, create it and fill it in; like I say, this only needs to be done once, by some sort of administration script.

for($zip=0; $zip<1000; $zip++) $zone_mappings[$zip]=0;
for($zip=5; $zip<=98; $zip++) $zone_mappings[$zip]=8;
for($zip=100; $zip<=212; $zip++) $zone_mappings[$zip]=8;
for($zip=214; $zip<=268; $zip++) $zone_mappings[$zip]=8;
....
...
..
.
for($zip=919; $zip<=921; $zip++) $zone_mappings[$zip]=1;

And so on and so forth for the whole thing.

Now the administration script writes it out. Easiest is to create a PHP file which can be included whenever $zone_mappings is needed.

fwrite($zm_file, '$zone_mappings = array(';
foreach($zip=0; $zip<1000; $zip++)
{	fwrite($zm_file,$zone_mappings[$zip].',');
	if($zip%10==9)
		fwrite($zm_file,"\n");
}
fwrite($zm_file, ");\n");

Yes, it leaves a trailing comma on the end of the array; PHP doesn't appear to mind.

Finally, use it.

include('zone_mappings.php');
$zipcode=$_POST['zipcode'];
if(strlen($zipcode)==5)
{	$zip = substr($zipcode,0,3);
	$zone = $zone_mappings[$zip];
}

Now I haven't run or tested any of that - I'm not on my own time right now 😉