problem with news and images

Jarod

I am having a probelm with my code when updating news without a image. I can do it with a image and without but i get errors when i dont put in a picture. Here is the page

http://www.tjshafer.com/clients/projects/baintown/admin/index.php?page=news

Feel free to test.

Heres the error.

Warning: getimagesize: Unable to open '' for reading. in /usr/www/users/shafey7s/clients/projects/baintown/admin/newsadd.php on line 18

Here is the code

News and news Image Upload: All Done
<?
mt_srand((double)microtime() * 1000000);
$randomKey = (mt_rand(1,5000));
$date = date('Y-m-d',mktime($hour,$minute,0,$month,$day,$year));

if($image='')
{
$haveimage=1;//yes
}
if($haveimage!='1');
{
$dest='';
$uploadpath = "../dynamic_content/news/";
$image1= $FILES['image']['name'];
$source = $FILES['image']['tmp_name'];
$imagesize = getimagesize($source);
switch($imagesize[2])
{
case 0:
echo ' ERROR: Image is not a JPG. ';
break;
case 1:
echo ' ERROR: Image is a GIF. It must be a JPG. ';
break;
case 2:
$dest = "$uploadpath/$image1";
break;
case 3:
echo ' ERROR: Image is a PNG. It must be a JPG. ';
break;
}
if ( $imagesize[0] > 800 )
{
echo' ERROR: Image is '.$imagesize[0].' pixels wide. Images must not be more than 800 pixels wide and 600 pixels high. ';
$denied = 1;
}
if ( $imagesize[1] > 600 )
{
echo' ERROR: Image is '.$imagesize[0].' pixels wide. Images must not be more than 800 pixels wide and 600 pixels high. ';
$denied = 1;
}
if($dest!='' && $denied != 1)
{
if(move_uploaded_file($source,$dest))
{
$showimage='1';
}
else
{
echo' ERROR: File could not be stored due to file system error. ';
}
}
}
$text = addslashes($text);
$teaser = addslashes($teaser);
$title = addslashes($title);
$result =mysql_query("INSERT INTO news (template,date_status,name,title,teaser,text,date) VALUES ('$template','$dateoff','$image1','$title','$teaser','$text','$date')") or die ("Couldnt Execute query".mysql_error());?>
<? echo" Template id:$template Image Name:"?>
<? echo $_FILES['image']['name'];?>
 
<?
if($turndateoff=='')
{
echo"Date:$date ";
}
echo"Title:$title Teaser$teaser News:$text";
if( $showimage='1')
{?>
<IMG SRC="../dynamic_content/news/<? echo "$image1?$randomKey";?>" WIDTH="375" HEIGHT="281" BORDER="0"> 
<?
}
?>

Thanks a lot everyone. 🙂

cgraz

I didn't even look at your code for logic.

When testing for equality, you have to use two equal signs, not one. If you only use one equal sign within an if statement, it will always return true. For example:

if($image == '') {

rather than

if($image = '') {

Cgraz

Jarod

thanks man, but that didnt help. Thatnks for the input though.

cgraz

You're going to need to modify your if statement. First of all, drop the value='' in your file field.

Basically, you only want to run the getimagesize() if they actually uploaded a file. So you can test this with an if statement. Right now you're using if($image == ''). Change it to something like this:

   if($_FILES['image']['size'] == '0') {
      echo "no file specified";
   } else {
      $imagesize = getimagesize($source);
   }

Cgraz

EDIT: By the way, I like your Bainbridge header image. Looks good.

Jarod

dude u are awesome...thanks a lot

Thanks about the header. I created the site with some friends a couple months ago for a high school project. Im adding a few more features now. Heres the site that live now..

http://www.bainbridgetwp.com

cgraz

That looks really good. Only suggestion would be to drop in a 1px border around all your images (using that dark green or black color) that is behind the links area and behind the date and telephone.

But i really like the design on this. Nice work.

Cgraz

Jarod

il give it a shot, thanks