Code Tidy-up

baffled_in_UK

Hi,

I try and be thorough with any coding I do and this has had me confused for some time, so I thought I'd get some help.

The following "INSERT" writes a record to the table but I also get an error message (as shown below).

$sql=mysql_query("INSERT INTO pagehits (page,hits) VALUES ('$ads_page','1')"); 
if (!mysql_query($sql)) { echo "insert error:<br>".mysql_error(); die;  }

insert error:
You have an error in your SQL syntax near '1' at line 1

Why do I get this error
Why does the record still get written if there is an error ?

Thanks

ahundiak

Add the $sql statement to your error message so you can see what is being submitted. Is it possible that $ads_page contains a quote mark or some other unfriendly character?

baffled_in_UK

$ads_page will contain values like :

index.php
coaching.php

will the "dot" cause this do you think ?

ahundiak

Dots are fine. It's single quotes and back slashes that can sometimes cause problems. Did you echo out the $sql statement?

You might try removing the quotes around the hits value (assuming hits is an integer field). It really should not make a difference to mysql but standard sql frowns on using quotes around numeric data.

And I am assuming that the page column is defined to be some sort of character data.

baffled_in_UK

Yeah I echoed it and nothing outstanding to report. The error message seems to confirm your suggestion about the quotes around numeric data. I'll give that a go.

Thanks.

sarahk

have you tried pasting the echo'd output into phpMyAdmin. You should get the same error but also have a chance to play around with fixing it.

baffled_in_UK

I don't know phpMyAdmin. I use MySQL-Front for my db maintenance. Would you advise I try it bearing in mind what I currently use is excellent and free.

diego25

phpMyAdmin is also excellent and free 🙂

Diego