Alter not insert

zingbats

Having read the article http://www.oxyscripts.com/view_tutorial.php?id=3, I made a script to add links as the tutorial did.

How could I change the process script so that it EDITS (alters) the MySQL table via another form.

The form would echo the current settings withing the form fields (yes, I know how to do that now! 😃) I know how to do that. I am just wondering how I would change the query

nnichols

You need to run an UPDATE query, something like this -

$query = "UPDATE links SET title='".$_POST['title']."' , url='".$_POST['url']."' WHERE id=$id";

Hope this helps 😉

zingbats

THat doesn't seem to work well.

Here are the ACTUAL scripts I made. The form AND the processor:

form:

<?php
    /* Connecting, selecting database */
    $link = mysql_connect("localhost", "zingbats", "password")
        or die("Could not connect");
    mysql_select_db("tycooneden_com") or die("Could not select database");

$query = "SELECT * FROM clans WHERE clan_name = '$clan'";
$result = mysql_query($query) or die("Query failed");
$foo=mysql_fetch_array($result);

/* Start the clan defining */

$clan_url=$foo['clan_url'];
$clan_logo=$foo['clan_logo'];
$clan_admin=$foo['clan_admin'];
$clan_admin_email=$foo['clan_admin_email'];
$clan_forum=$foo['clan_forum'];
$clan_name=$foo['clan_name'];
$clan_logo_height=$foo['clan_logo_height'];
$clan_logo_width=$foo['clan_logo_width'];

mysql_close($link);
?>
<html>

<head>
<title>Edit clan</title>
</head>

<body>

<p><font face="Courier" size="1">Edit clan:</font></p>
<form method="POST" action="alter.php">
  <div align="left">
    <table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="47%" id="AutoNumber1">
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan Name</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_name" size="31" value="<?php echo ("$clan_name");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan URL</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_url" size="31" value="<?php echo ("$clan_url");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan Logo URL</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_logo" size="31" value="<?php echo ("$clan_logo");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan Admin name</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_admin" size="31" value="<?php echo ("$clan_admin");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Admin's email</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_admin_email" size="31" value="<?php echo ("$clan_admin_email");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Points (set as 0)</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_points" size="31" value="<?php echo ("$clan_points");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan Forum</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_forum" size="31" value="<?php echo ("$clan_forum");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan logo Height</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_logo_height" size="31" value="<?php echo ("$clan_logo_height");?>"></font></td>
      </tr>
      <tr>
        <td width="28%"><font face="Courier" size="1">Clan logo Width</font></td>
        <td width="72%"><font face="Courier" size="1">
        <input type="text" name="clan_logo_width" size="31" value="<?php echo ("$clan_logo_width");?>"></font></td>
      </tr>
    </table>
  </div>
  <p><font size="1" face="Courier"><br>
  <input type="submit" value="Submit" name="B1"><input type="reset" value="Reset" name="B2"></font></p>
</form>
<p>&nbsp;</p>

</body>

</html>

That posts to:

<?php
$db = mysql_connect("localhost","zingbats","password");
mysql_select_db (tycooneden_com); 
$query = "UPDATE clans SET clan_name='".$_POST['clan_name']."' , clan_url='".$_POST['clan_url']."' , clan_logo='".$_POST['clan_logo']."' , clan_admin='".$_POST['clan_admin']."', clan_admin_emain='".$_POST['clan_admin_email']."', clan_points='".$_POST['clan_points']."', clan_forum='".$_POST['clan_forum']."' , clan_logo_height='".$_POST['clan_logo_width']."' WHERE clan_name = '$clan_name'";
$result = mysql_query($query);

?> 

congrats... clan <?php echo ("$clan_name");?> altered sucessfully

xblue

Originally posted by zingbats
THat doesn't seem to work well.

not really a precise error description 😉

please always check for any mysql_error before posting and include it in your post.

$result = mysql_query($query) or die("Error: ".mysql_error()." in query: ".$query);

your are sure your field name is clan_admin_emain?

zingbats

As have altered the clan_admin_emain to clan_admin_email.

The script doesn't bring up an error.

It prints that the clan has been altered successfully even though it hasn't.

If you look at the WHERE bit of the query:

WHERE clan_name = '$clan_name'";

You'll see it uses the $clan_name variable. So the print could be getting clan_name from the form not the database.

After all, the URL to edit a clan is

http://url/index.php?clan=clan_name

I wonder if that has anything to do with it?!

xblue

echo $query to take a look.

if the url actually is
http://url/index.php?clan=clan_name
this is likely to be the problem, but your input name is clan_name, not clan, so it should read
http://url/index.php?clan_name=clan_name

<input type="text" name="clan_name" size="31" value="<?php echo ("$clan_name");?>">

zingbats

No it still doesn't work. I really have no idea why it doesn't.

Remember thought that the "?clan=whatever" comes from the query on the form page.

$query = "SELECT * FROM clans WHERE clan_name = '$clan'";

Echo which query?

Maybe it would be better if we tried doing the whole process script again?

How would you write it?

Regards;
Alex

xblue

echo the variable that contains the query. like this:
echo $query;

zingbats

SELECT * FROM clans WHERE clan_name = 'boballie'

- is from the form page.

UPDATE clans SET clan_name='boballie' , clan_url='http://www.boballie.com/' , clan_logo='http://www.boballie.com/graphics/main/logo.jpg' , clan_admin='Boballie', clan_admin_email='webmaster@boballie.com', clan_points='', clan_forum='http://www.tycooneden.com/forum/viewforum.php?f=24' , clan_logo_height='525' WHERE clan_name = 'boballie'

Is from the alter page