Simple but confusing problem

[pug]

I am trying to make a bookmark page where I can add bookmarks to a database so I can access my favorites from anywhere.

Everything works except for the display page.

I have two tables
1) Keeps all the types of Favorites Categories (Lan Party Sites, PC Sites, etc)

2) All the links

What I want it to do is get the name from the Category table and the link name and path from the Link table

Here is the code..What it does is it displays all the ones for the first category but none of the links for the next categories after that..

<?
	require_once("../includes/common.php");
	if(!db_connect())
		echo "Error connecting to database";
	$SQLTypes = mysql_query("SELECT * FROM favoriteType ORDER BY favoriteType");
	$SQLFavs = mysql_query("SELECT * FROM myFavorites ORDER BY favoriteType");

$num_Types = mysql_num_rows($SQLTypes);
$num_Favs  = mysql_num_rows($SQLFavs);

for($a=0;$a<$num_Types;$a++)
{
		$rowType = mysql_fetch_array($SQLTypes);
		$typeNumber	= $rowType["favoriteType"];	
		echo $typeNumber. ") ";
		echo $rowType["favoriteTypeName"]. "<hr>";	
		do
		{								
			$rowFavs = mysql_fetch_array($SQLFavs);
			$favType = $rowFavs["favoriteType"];
			if($favType == $typeNumber)	
			{
				echo "<a href='" .$rowFavs["linkURL"]. "'>" .$rowFavs["linkName"]. "</a><br>";			
			}
		}
		while($favType == $typeNumber);

}
?>

[edwardsbc]

Do the two tables share a common field? There are much easier ways to do this if your tables share a related field (ie category).

TableCat (category)
TableFavs (category, linkurl, linkname)

$sql1="SELECT * FROM TableCat ORDER BY category";
$rslt1=mysql_query($sql1);
while($row1=mysql_fetch_array($rslt1)) {
  echo $row1['category'].'<hr />';
  $sql2="SELECT * FROM TableFavs WHERE category={$row1['category']} ORDER BY linkname";
  $rslt2=mysql_query($sql2);
  while($row2=mysql_fetch_array($rslt2)) {
    echo '<a href="'.$row2['linkurl'].'">' .$row2['linkname'].'</a><br>';            

  }
}

This is a crude example, with no error checking but is should illustrate the basic principle. It is also possible to do this with just one query (joining the two tables), but I'll leave that exercise to the reader.

[FrozNic]

edwards post held my thoughts... but, another question... why two tables? the data completely is ideal to be in one table (no reason to be in two) unless there's something i don't know. i'd suggest throwing it in 1 table for ease of use and dumping to db. or, like he said, make it so that they link in someway (if they don't already)

good luck 🙂

[pug]

They do link by a common key