Can't figure why this isn't working?

[bike5]

I am making this password recovery script and everything works unless the name typed in is not in the database, the error message wont execute, which is an "else" after an if, if the count is not one(which means there is a name in the db there).

if(isset($login_name)){
require("include_scripts/db_mem_login.php");
//Check for matching name and password
$Result = mysql_query("SELECT count(*) from $TableName where login_name='$login_name'")or die(mysql_error()); 
$count=mysql_result($Result,0,0)or die(mysql_error()); 
if($count>0)
	{
	$Result = mysql_query("SELECT email, login_name, login_password from $TableName where login_name='$login_name'")or die(mysql_error());
	$row = mysql_fetch_array ($Result)or die(mysql_error());
	$headers = "Content-type: text/html; charset=iso-8859-1\r\n";
	$headers .= "From: Password Recovery <[e-mail]>\r\n";
	$subject = "Password Recovery Request For $login_name";
	$text = "text here";

	if(mail($row["email"], $subject, $text, $headers)){
	echo'<center>Thank you, your password has been sent to the e-mail linked to your account</center>';
	}else{
	echo'<center>There was an error when processing the mail request, please resubmit that form.</center>';
	}
//|||||||||||||||||||||||||||||
//THIS IS WHERE IT SHOULD BE EXECUTING WHEN I TYPE SOMETHING IN WRONG BUT ITS NOT		
	}else{
	echo'<center>I am sorry but that user name is not in our database, check to make sure it was correct.<br>
	If you have further problems ask for help from an administrator in the message board.</center>';
	}
//|||||||||||||||||||||||||||

}

It works when I type in a correct name but when its incorrect I get nothing. It should be printing out that error echo and I don't see why its not, any help would be great, thanks for your time.

[edwardsbc]

It doesn't work because [man]mysql_result[/man] is true (ie 1) even if the result set is empty. You should be using [man]mysql_num_rows[/man] to see if zero or 1+ rows have been returned.

[bike5]

I used mysql_num_rows and it still returns a 1 no matter what? But that doesn't make sense anyway because it should be giving me an e-mail error because it should then if it was 1 be executing the email script, and I am doing this on my local host which gives an can't connect error when sending email, which only gives me the error if I typed in a name in the DB.?? It doesn't echo either one of the email if statements which means its not going into the loop on "1". But if its not then it should give me other error which its not?

[devinemke]

mysql_num_rows won't help you since you are using a COUNT(*) in youy query. Even if the COUNT is 0 you will still get a valid result from mysql_num_rows.

my susggestion is to forget the COUNT(*) stuff. why make 2 hits to the db when you only need one? try this:

if(isset($login_name))
{
	require ('include_scripts/db_mem_login.php');

$Result = mysql_query ("SELECT email, login_name, login_password from $TableName where login_name='$login_name'") or die (mysql_error ());
if (mysql_num_rows ($Result))
{
	    $Result = mysql_query("SELECT email, login_name, login_password from $TableName where login_name='$login_name'")or die(mysql_error());
	    $row = mysql_fetch_array ($Result)or die(mysql_error());
	    $headers = "Content-type: text/html; charset=iso-8859-1\r\n";
	    $headers .= "From: Password Recovery <[e-mail]>\r\n";
	    $subject = "Password Recovery Request For $login_name";
	    $text = "text here";

		if(mail($row["email"], $subject, $text, $headers))
		{
			echo'<center>Thank you, your password has been sent to the e-mail linked to your account</center>';
		}
		else
		{
			echo'<center>There was an error when processing the mail request, please resubmit that form.</center>';
		}
}
else
{
echo'<center>I am sorry but that user name is not in our database, check to make sure it was correct.<br>
If you have further problems ask for help from an administrator in the message board.</center>';
}
}

[bike5]

Hey that worked, thanks a lot for the help.

[edwardsbc]

devinemke is correct. I missed the count(*) part. devinemke solution is actually similar to what I thought you were doing. Sorry!

Note, if you allow multiple login_name values, this could send multiple emails. You probably don't allow multiple login_names, but some systems do...

[bike5]

Yea I made it so each login name was unique and can't be the same. Thanks again for the help.