errors. Is my code outdated?

Gump

Hi,

I took an onlune tutorial that looked about 3 years old. My Sql table looks like this:

CREATE TABLE employees ( id tinyint(4) DEFAULT '0' NOT NULL AUTO_INCREMENT, first varchar(20), last varchar(20), address varchar(255), position varchar(50), PRIMARY KEY (id), UNIQUE id (id));INSERT INTO employees VALUES (1,'Bob','Smith','128 Here St, Cityname','Marketing Manager');

INSERT INTO employees VALUES (2,'John','Roberts','45 There St , Townville','Telephonist');

INSERT INTO employees VALUES (3,'Brad','Johnson','1/34 Nowhere Blvd, Snowston','Doorman');

=========================

My actual cript resembles this:

<?php

$dbh=mysql_connect ("localhost", "user_content", "content") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("user_content");

$result = mysql_query("SELECT * FROM employees",$db);

printf("First Name: %s \n", mysql_result($result,0,"first"));

printf("Last Name: %s \n", mysql_result($result,0,"last"));

printf("Address: %s \n", mysql_result($result,0,"address"));

printf("Position: %s \n", mysql_result($result,0,"position"));

===================

All I am trying to do is print these fields out on a generic web page to see if it works but I am presented with these errors:

Warning: mysql_query(): supplied argument is not a valid MySQL-Link resource in /home/user/public_html/php/index.php on line 12

Warning: mysql_result(): supplied argument is not a valid MySQL result resource in /home/user/public_html/php/index.php on line 16
First Name:

Warning: mysql_result(): supplied argument is not a valid MySQL result resource in /home/user/public_html/php/index.php on line 20
Last Name:

Warning: mysql_result(): supplied argument is not a valid MySQL result resource in /home/user/public_html/php/index.php on line 24
Address:

Warning: mysql_result(): supplied argument is not a valid MySQL result resource in /home/user/public_html/php/index.php on line 28
Position:

Are my print calls outdated or does my code need some work?

Thanks,

Matt

coditoergosum

It looks like your not calling the connection ID correctly in your mysql_query. You've set your connection ID to $dbh, but you're calling $db in your query.

Looks like 1 character is hosing the whole thing.

Gump

You da.

Thanks

😃

coditoergosum

By the way, you should consider using mysql_fetch_array rather than mysql_result. mysql_fetch_array() is more powerful (it does more for you) and it's also much quicker ironically enough (unless you're doing a very simple query that only returns one cell).

Here is some info about both of them on php.net:
http://www.php.net/manual/en/function.mysql-result.php
http://www.php.net/manual/en/function.mysql-fetch-array.php

Gump

thanks for the suggestion. This would be my first array. What do you think of it?

while ($row = mysql_fetch_array($result, MYSQL_NUM)) {
printf ("First Name: %s Last Name: %s Address: %s ", $row[1], $row[2], $row[3]);

}

That is more powerful you say?

I'll keep it in mind. Thanks for the tip. Next lesson--->how to edit the data stored in the table via web-based form......any good pointers?

🙂