Whats wrong with this code?

NuTz

Hiya all,

Wonder if someone can tell me what im doing wrong here. I think its syntax for the amount of } in the code. Basically i have a form and want to check the validation before moving on so if the users gets either field wrong it will tell them whats wrong with that field.

Any help would be much appreciated.

<?
function form ()
{
    echo '
    <form action="' . $_SERVER['PHP_SELF'] . '" method="post">
    First Name: <input type="text" size="20" name="first_name" value="'; if (isset ($_POST['first_name'])) {echo $_POST['first_name'];} echo '"><br>
    Surame: <input type="text" size="20" name="sur_name" value="'; if (isset ($_POST['sur_name'])) {echo $_POST['sur_name'];} echo '"><br>
    <input type="submit" name="submit" value="submit">
    </form>
    ';
}

if (!isset ($_POST['submit']))
{
    echo 'first run:';
    form ();
}

if (isset ($_POST['submit']))
{
 if ((!$_POST['first_name']) {echo 'You forgot to enter fill out first name!';}
 OR (!$_POST['sur_name']) {echo 'You forgot to enter fill out surname!';})
 form ();
    else {echo 'Thank you.  You submitted:<br><br>' . $_POST['first_name'] . '<br>' . $_POST['sur_name'];}
}
?>

Cheers

NuTz

EviL_CodE

Your syntax was totally wrong.

<?
function form() {
    echo '
    <form action="' . $_SERVER['PHP_SELF'] . '" method="post">
    First Name: <input type="text" size="20" name="first_name" value="'; if (isset ($_POST['first_name'])) {echo $_POST['first_name'];} echo '"><br>
    Surame: <input type="text" size="20" name="sur_name" value="'; if (isset ($_POST['sur_name'])) {echo $_POST['sur_name'];} echo '"><br>
    <input type="submit" name="submit" value="submit">
    </form>
    ';
}

if (!isset($_POST['submit'])) {
    echo 'first run:';
    form ();
}

if (isset($_POST['submit'])) {
	if (!$_POST['first_name']) {
		echo 'You forgot to enter fill out first name!';
		form();
	}
	elseif(!$_POST['sur_name']) {
		echo 'You forgot to enter fill out surname!';
		form();
	}
	else {
		echo 'Thank you.  You submitted:<br><br>' . $_POST['first_name'] . '<br>' . $_POST['sur_name'];
	}
}
?>

Get EditPlus or another text editor that can highlight or tell you that you are missing brackets or parenthesis.

If statements should be in this form: -

if($this) {
   echo "print this";
}
else {
    echo "print that";
}

NuTz

Original problem solved but due to enclosing all the form in a php echo statement im having real trouble with syntax. Can someone tell me why the echo $error1; statement isnt working on line 12?

I cant work out the format for all the ';}" items 🙂

<body>
<?
$error1 = "";
$error2 = "";

function form ()
{
    echo '
    <form action="' . $_SERVER['PHP_SELF'] . '" method="post">
    <table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" id="AutoNumber1">
  <tr>
    <td width="25%">echo $error1;</td>
    <td width="25%">First Name: <input type="text" size="20" name="first_name" value="'; if (isset ($_POST['first_name'])) {echo $_POST['first_name'];} echo '"><br></td>
    <td width="25%">   Surname: <input type="text" size="20" name="sur_name" value="'; if (isset ($_POST['sur_name'])) {echo $_POST['sur_name'];} echo '"><br></td>
    <td width="25%"></td>
  </tr>

<input type="submit" name="submit" value="submit">
</table>
</form>
';
}

if (!isset ($_POST['submit']))
{
    echo 'first run:';
    form ();
}

if (isset($_POST['submit'])) {
    if (!$_POST['first_name']) {
        $error1 = 'You forgot to fill out your firstname!';
        echo $error1;
        form();
    }
    elseif(!$_POST['sur_name']) {
        $error2 = 'You forgot to enter fill out your surname!';
        echo $error2;
        form();
    }
    else {
        echo 'Thank you.  You submitted:<br><br>' . $_POST['first_name'] . '<br>' . $_POST['sur_name'];
    }
}
?>

</body>
PHP] 

Many thanks in advance

NuTz

ohh who bumped this? 🙂

NuTz

I would really appreciate a reply if someone has the time. Again, many thanks in advance.

NuTz

vbtester

You need to use CHARACTER ESCAPE CODES. You are using the echo command which prints a string. The sting is enclosed in " ".

If your code you are making this mistake:
echo "this part is good "this part is bad" still does not work";

In the line above all goes well untill the second " mark is detected after the word good. The proper format if I wanted to have someting printed thats inclosed in a " " would be like this:

echo "this part is good \"this part is bad\" still does not work";

So the same applies in HTML. For exampe:

This is bad:
echo "<A HREF=www.mydware.com>Click Here</A>";

This is good:
echo "<A HREF="[url]www.mydware.com[/url]">Click Here</A>";

As another hint if you want your code to be eaiser to read and debug, try using echo like this:
echo ("Hello World");
Brakets make it easier to see the beginning and end of the string. Just a suggestion :o)

Hope it helps!

vbtester

You need to use CHARACTER ESCAPE CODES. You are using the echo command which prints a string. The sting is enclosed in " ".

If your code you are making this mistake:
echo "this part is good "this part is bad" still does not work";

In the line above all goes well untill the second " mark is detected after the word good. The proper format if I wanted to have someting printed thats inclosed in a " " would be like this:

echo "this part is good \"this is good now \" Yup still works!";

So the same applies in HTML. For exampe:

This is bad:
echo "<A HREF="www.mydware.com">Click Here</A>";

This is good:
echo "<A HREF=\"www.mydware.com\">Click Here</A>";

Hope it helps!

vbtester

The bottom post is correct, disregard the first one i posted, sorry about that.

NuTz

Thanks VBTESTER i understand what you are saying but im new to this and cannot get the format right and work are on my back to sort it out.

Can anyone show me the right format. It would be VERY much appreciated.

Regards

NuTz

Natty_Dreadlock

Try this:

<?php
function form () 
{ 
?>
<form action="<?php echo  $_SERVER['PHP_SELF'];?>" method="post"> 
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" id="AutoNumber1"> 
<tr> 
<td width="25%"><?php echo $error1;?></td> 
<td width="25%">First Name: <input type="text" size="20" name="first_name" value="<?php if (isset ($_POST['first_name'])) {echo $_POST['first_name'];}?>"><br></td> 
<td width="25%"> Surname: <input type="text" size="20" name="sur_name" value="<?php if (isset ($_POST['sur_name'])) {echo $_POST['sur_name'];}?>"><br></td> 
<td width="25%"></td> 
</tr> 

<input type="submit" name="submit" value="submit"> 
</table> 
</form> 
<?php
} 
?>

I guess this should work, I did not test it, so if it's still not working, notify me.
Moreover, I would strongly recommend you to read the docu at www.php.net - believe me, it could solve a lot of your programming problems.
Hasta siempre

trooper

there is another way of safely mixing php and html without having to escape all the " and all the associated problems that it causes

Use a (no sure of the real name) multiline identifier below is an example of what i mean


function form()
{
$form =<<<EOD
<form method='POST' action=''>
<input type="text" name="name"><br>
<input type="text" name="age"><br>
</form>
EOD; <- NO SPACE AFTER THE ;
return $form;
}


$my_form = form();

print $my_form;

try it yo might like it 😃

HTH

If you need an expanation then IM me