[Resolved] PHP and Javascript Error

[lobster]

I know that PHP and Javascript is a bit tricky to work together but I read all threads I could find and know it can be done. I cannot figure out where i am going wrong.

Below is the Javascript to pop open a window at a certain size. I get out of PHP mode to put the a href in plain html it is pullling the function and url just fine (I can see it in the status part of the window) it even has the right site id to pass along with it. Whick I click on the link, I get "Expected ':'"

Cannot figure out why this is not working. Please advise.

<script language="javascript"> 
//<!-- 
function sitepopup(url){ mywindow=window.open('url','popup','width=400,height=400,location=0,menubar=0,resizable=0,scrollbars=0,status=0,titlebar=1,toolbar=0'); } 
--> 
</script> 
<? 
	...dbstuff...

	iteration though sites...				?>
<a href="javascript:sitepopup(site_contact.php?siteid=<? echo $siterow["SITEID"];?>)">
	<?	
echo htmlspecialchars( stripslashes($siterow["NAME"])); 
echo "</a></td></tr>";
       ...more stuff...			

[tomhath]

Did you mean "javascript" or "java script" ?

<a href="java script:

[jayant]

You have the new line after

Try using

<a href="javascript:sitepopup('site_contact.php?siteid=<? echo $siterow["SITEID"];?>')">

this should do it.

[lobster]

I fixed it as you said putting a space in between java and script...actually copying your script from here and when I click it goes to a page not found. Not in a new window either.

http://thesite.com/admin/java%20script:sitepopup('site_contact.php?siteid=3')

???

[lobster]

Originally posted by lobster
I fixed it as you said putting a space in between java and script...actually copying your script from here and when I click it goes to a page not found. Not in a new window either.

http://thesite.com/admin/java%20script:sitepopup('site_contact.php?siteid=3')


???

Got it to work!!!

changed to this:

<a href="javascript:sitepopup('<? echo $siterow["SITEID"];?>')">

and passed the variable to the script like so:

<script language="javascript">
//<!--
function sitepopup(who){ mywindow=window. open('site_contact.php?siteid=who','popup','width=400,height=400,location= 0,menubar=0,resizable=0,scrollbars=0,status=0,titlebar=1,toolbar=0'); }
-->
</script>