newbie PHP problem.

Pellefant

Hello!

What might be the reason I got this error please?

Parse error: parse error, unexpected T_STRING in /home/user/public_html/tony/admin.php on line 20

Line 20 is: <A HREF="login.html">You are logged out, maybe beacuse the cookie expired, log in again</A>

Thanks in advance.

<HTML>
<HEAD>
<TITLE>Admin</TITLE>
</HEAD>
<BODY>

<?
if($_COOKIE["status"]=="inside"){
	$Link = mysql_connect("localhost", "user_user", "password");
	mysql_select_db("user_tonydb", $Link);
	$Query = "SELECT * FROM reviews WHERE id=1) or die (mysql_error());
	$Result = mysql_db_query($Query,$Link);

$row=mysql_fetch_array($Result);
echo $row['datum']; 
}

else{
?>
	<A HREF="login.html">You are logged out, maybe beacuse the cookie expired, log in again</A>
<?
}
?>

</BODY>
</HTML>

xblue

look at the syntax highlighting.
you forgot the closing " at the end of the query string.

Pellefant

Hi! 🙂

Thanks for finding that bug.

NowI get instead 🙁

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/user/public_html/tony/admin.php on line 14

Line 14 is: $row=mysql_fetch_array($Result);

xblue

which basically means your query fails for whatever reason.
mysql_error() should provide more details, please always run this first and include it in your post in future, okay?

then compare your syntax to the manual, the order of arguments is wrong fro mysql_db_query, and you shouldn't use it anyway, use mysql_query instead:

http://www.php.net/manual/en/function.mysql-db-query.php
http://www.php.net/manual/en/function.mysql-query.php

Pellefant

Hi!

Thanks for caring.

A stupid question...how and where should I add mysql_error() please?

xblue

when...
your query fails, especially with a similar error message.

how...
it's simple 🙂 and putting it in the or die statement the errors will only be reported if something goes wrong, so you can safely put it into all your queries while developing.

$Result = mysql_query($Query) or die("Error: ".mysql_error()." in query: ".$Query);

Pellefant

Hi!

Thanks alot for the help. 🙂 I found that the error was on this row:

$Query = "SELECT * FROM reviews" or die (mysql_error());

jpmoriarty

we knew that - we need to know what the error is.

I'm guessing that your query is returning no results - ecare you sure you have a table called reviews in that database?

Pellefant

Hi, sorry I was a bit unclear, it is solved 🙂

I had:

$Query = "SELECT * FROM reviews WHERE id=1) or die (mysql_error());

(a " was missing)