Does anyone c what is wrong with this except the messi coding

freedomclan

it seems that i always get a problem with the header...
pls help in any places you thing i must
<?php
//Start Buffering
ob_start();
require_once('Connections/Admin.php');
$check2 =0;
if ((isset($HTTP_POST_VARS["DO"])) && ($HTTP_POST_VARS["DO"] = "true")) {
{
$CHECK_SQL="select USER_ID, U_Username, U_Email from EMPLOYEE where U_Username='" . $HTTP_POST_VARS["USERNAME"] ."' OR U_Email='" . $HTTP_POST_VARS["EMAIL"] . "'";
$PASSCHECK = strcmp($HTTP_POST_VARS["PASSWORD"] , $HTTP_POST_VARS["REPASSWORD"]);
}
if ( $PASSCHECK==0)
{
mysql_select_db($database_Admin, $Admin);
$Check1 = mysql_query($CHECK_SQL, $Admin) or die(mysql_error());
if (($check2 = mysql_num_rows($Check1)) > 0)
{
$Result=1;
header("Location: register.php?USERNAME=" . $HTTP_POST_VARS["USERNAME"] . "&FIRSTNAME=" . $HTTP_POST_VARS["FIRSTNAME"] . "&MIDLENAME=" . $HTTP_POST_VARS["MIDLENAME"] . "&LASTNAME=" . $HTTP_POST_VARS["LASTNAME"] . "&EMAIL=" . $HTTP_POST_VARS["EMAIL"] . "&P=" . $Result);
}
else
{
$Insert_Sql="insert into EMPLOYEE (U_Username , U_Password, U_Fname, U_Mname, U_Lname, U_Email ,U_RegDate) values ('" . $HTTP_POST_VARS["USERNAME"] . "','" .$HTTP_POST_VARS["PASSWORD"]. "','" . $HTTP_POST_VARS["FIRSTNAME"] . "','" . $HTTP_POST_VARS["MIDLENAME"] . "','" . $HTTP_POST_VARS["LASTNAME"] . "','" . $HTTP_POST_VARS["EMAIL"] . "',NOW())";
$Result1=mysql_query($Insert_Sql,$Admin) or die(mysql_error());
//Just checking the output of the header to see what is going on dont pay any attension
/////////////////////////////////////////////////
$data = ob_get_contents();
$fp = fopen ("test/test.html", "w");
fwrite($fp, $data);
fclose($fp);
////////////////////////////////////////////////
header("Location: insertcv.php");
exit;
}
}
else
$Result=2;
}
//Flush out the output buffer to the browser
ob_end_flush();
?>

rklapwijk

You might want to change if((isset($HTTP_POST_VARS["DO"])) && ($HTTP_POST_VARS["DO"] = "true"))
to if (isset($HTTP_POST_VARS["DO"]) && ($HTTP_POST_VARS["DO"] == "true").

Need a double "=="

freedomclan

done but still getting the header error

adamgeorge

Yeah, you really need to get into the habbit of writting clear, legible code. Makes things easier for everyone, and I'm sure you'll find it easier too when you come back to edit your code.

Also when you post PHP code to the forum, make sure you enclose it in [ PHP] [/ PHP] tags so it can easily understood.

Hmm.... so you should at least tell us the error msg. you were getting? Or do you just mean the redirect wasn't working as expected? You should be clearer with you problem so people can more easily help you out.

cya
-Adam 🙂

freedomclan

thanx for be4 it just happens iam a newbie
anyway the problem is that header redirection doesnt seem to work
i tried as you see the "output buffering"
but still getting the
warning about headers have already been send
if anyone can help i would be greatfull
what am i doing wrong
pls help

freedomclan

<?php 
//Start Buffering 
ob_start(); 
require_once('Connections/Admin.php'); 
$check2 =0; 
if ((isset($HTTP_POST_VARS["DO"])) && ($HTTP_POST_VARS["DO"] = "true")) { 
{ 
$CHECK_SQL="select USER_ID, U_Username, U_Email from EMPLOYEE where U_Username='" . $HTTP_POST_VARS["USERNAME"] ."' OR U_Email='" . $HTTP_POST_VARS["EMAIL"] . "'"; 
$PASSCHECK = strcmp($HTTP_POST_VARS["PASSWORD"] , $HTTP_POST_VARS["REPASSWORD"]); 
} 
if ( $PASSCHECK==0) 
{ 
mysql_select_db($database_Admin, $Admin); 
$Check1 = mysql_query($CHECK_SQL, $Admin) or die(mysql_error()); 
if (($check2 = mysql_num_rows($Check1)) > 0) 
{ 
$Result=1; 
header("Location: register.php?USERNAME=" . $HTTP_POST_VARS["USERNAME"] . "&FIRSTNAME=" . $HTTP_POST_VARS["FIRSTNAME"] . "&MIDLENAME=" . $HTTP_POST_VARS["MIDLENAME"] . "&LASTNAME=" . $HTTP_POST_VARS["LASTNAME"] . "&EMAIL=" . $HTTP_POST_VARS["EMAIL"] . "&P=" . $Result); 
} 
else 
{ 
$Insert_Sql="insert into EMPLOYEE (U_Username , U_Password, U_Fname, U_Mname, U_Lname, U_Email ,U_RegDate) values ('" . $HTTP_POST_VARS["USERNAME"] . "','" .$HTTP_POST_VARS["PASSWORD"]. "','" . $HTTP_POST_VARS["FIRSTNAME"] . "','" . $HTTP_POST_VARS["MIDLENAME"] . "','" . $HTTP_POST_VARS["LASTNAME"] . "','" . $HTTP_POST_VARS["EMAIL"] . "',NOW())"; 
$Result1=mysql_query($Insert_Sql,$Admin) or die(mysql_error()); 
//Just checking the output of the header to see what is going on dont pay any attension 
///////////////////////////////////////////////// 
$data = ob_get_contents(); 
$fp = fopen ("test/test.html", "w"); 
fwrite($fp, $data); 
fclose($fp); 
//////////////////////////////////////////////// 
header("Location: insertcv.php"); 
exit; 
} 
} 
else 
$Result=2; 
} 
//Flush out the output buffer to the browser 
ob_end_flush(); 
?>

adamgeorge

hehe. You do need to be carefull with the [PHP ] tags though. They don't word wrap long lines, so you should put some newlines in there so you don't make the webpage look all fat.

Also, it's good coding practise to put a newlines in you code so that any code that is out of view is put on the line below indented. This'll help you when you're programming, and you won't have to scroll across to read your code which is ineffecient.

hmm.

anyway... I saw some parse errors.

$check2 =0; 
if ((isset($HTTP_POST_VARS["DO"])) && ($HTTP_POST_VARS["DO"] = "true")) { 
{

Notice the two { characters? you better remove one of them.

and here:

else 
$Result=2; 
} 
//Flush out the output buffer to the browser 
ob_end_flush();

you forgot a { at the end of 'else' too.

K, now if I assume that those errors are not the problem else you would have recieved parse errors when you ran the script... but fix them up anyway it may or maynot solve the problem.

The rest of your code looks ok... so... there must be output somewhere else in your script? whatabout before the <?PHP tag? any newline characters? that counts as output...

hmm.. but apart from that... I'm not too sure...

use the headers_sent() function to check if headers have already been sent before the ob_start(); function... if so there maybe output else where in your script.

hope that helps
-Adam 🙂

freedomclan

i will try that but if the brackets where the problem then why didnt it prompt for one
and what do you mean by a newline
this is the beggining of the page there are no html tags outside this script
well i will try the brackets and the header send thanx

adamgeorge

A newline is a 'Enter' character. I call it newline because that's what it's refered to as. (Or on Windows Newline+Linefeed 😉)

Anyway, so you need to make sure you don't have anything before the first <?php tag including any newline characters which may not be obvious at first.

hope that helps
-Adam 🙂

freedomclan

thanx adam new line but it doesnt seem to have a carriege return
in the php.ini file of the server the output buffering is off
if it was on would this make a diference ???

well any other clues cause the brackets are fine now a little bit tweaked but still the same
i have attached the php code (too bored to word wrap )😛
well if anyone can help me i would be greatfull