If Else and Elseif

[danmerk]

I am having some problems with If and Else. this is what I want to do:

If $somevariable = "foo" then echo "Foo is Good";
Else If
$somevariable = "page2" then echo "This is page 2";
End IF

And the code I am trying to use is this:

<?php if ($theme = "crashingwaves") {
    print "Crashing Waves";
} elseif ($theme = "rose") {
    print "Rose";
} elseif ($theme = "lighthouse") {
    print "Light House";	
} else {
    print "Rocking Clock Generic";
}
?>

The page is called page1.php, and I am passing the variable in the query string like this

../page1.php?theme=crashingwaves

But on the page all i get is a printout of the first argument.

Crashing Waves

Thanks!

[cgraz]

use two equal signs. one assigns a value, two checks for equality

x = y means you are assining value y to x

x == y is used to check if variable y equals x as in

if($x == $y) {

Your if statements will always return true because you assign new values within your if statements because you're only using one equal sign. Use two.

Cgraz

[danmerk]

So I do this correct?

<?php if ($theme == "crashingwaves") {
    print "Crashing Waves";
} elseif ($theme == "rose") {
    print "Rose";
} elseif ($theme == "lighthouse") {
    print "Light House";	
} else {
    print "Rocking Clock Generic";
}
?>

Thanks for the reply! 🙂

[cgraz]

yup!

Cgraz

[rpanning]

I have a suggestion for ya, just another way to write the code.

<?php
switch ($_GET['theme']) {
    case 'crashingwaves':
        print('Crashing Waves');
        break;
    case 'rose':
        print('Rose');
        break;
    case 'lighthouse':
        print('Light House');
        break;
    default:
        print('Rocking Clock Generic');
}
?>

This just uses the switch statement. If your getting the variable from the query string you'll also want to use $_GET['theme'] instead of just $theme. One other thought is if you print the value more than one time you could put the result into a variable and just print the variable everywhere. Ex: instead of using print('...') change it to $theme = '...'; Then everywhere you want to print the result just go print($theme); I just thought I'd mention that.

[danmerk]

Great thanks! This makes sense as well!

[ph8edsicness]

If you have a lot of selections it's best to use the switch case that rpanning showed you... easier to follow and edit later on