file upload script

tazgalsinh

i've just basically wrote this code from a tutorial in a book but can;t get it to work. its a file upload script and isn't uploading the file at all. anyone got any ideas?

<?
//file_upload.php
$archive_dir = "./images";
function upload_form() {
   global $PHP_SELF;
?>
<FORM METHOD="POST" ENCTYPE="MULTIPART/FORM-DATA" 
   ACTION="<? echo $PHP_SELF ?>">
   <INPUT TYPE="HIDDEN" NAME="action" VALUE="upload">
   Upload file!
   <INPUT TYPE="FILE" NAME="userfile">
   <INPUT TYPE="SUBMIT" NAME="SUBMIT" VALUE="upload">
</FORM>
<?
}

function upload_file() {
   global $userfile, $userfile_name, $userfile_size, 
         $userfile_type, $archive_dir, $WINDIR;

   if(isset($WINDIR)) $userfile = str_replace("\\\\","\\", $userfile);

   $filename = basename($userfile_name);

   if($userfile_size <= 0) die ("$filename is empty.");

   if(!@copy($userfile, "$archive_dir/$filename"))
      die("Can't copy $userfile_name to $filename.");

   if(!isset($WINDIR) && !@unlink($userfile))
      die ("Can't delete the file $userfile_name.");

   echo "$filename has been successfully uploaded.<BR>";
   echo "Filesize: " . number_format($userfile_size) . "<BR>";
   echo "Filetype: $userfile_type<BR>";
}
?>
<HTML>
<HEAD><TITLE>FILE UPLOAD</TITLE></HEAD>
<BODY>
<?
if($action == 'upload') upload_file();
else upload_form();
?>
</BODY>
</HTML>

Mordecai

Do you get an error?

I see a few possible mistakes:
1) if(isset($WINDIR)) $userfile = str_replace("\","\", $userfile);
This line is incorrect. The first set of slashes needs to be \\, and the latter \. This will turn two back-slashes into one back-slash.
2) You might not have register_globals on. If this is not on, you can only retrieve POST values through $_POST[].

tazgalsinh

changed

if(isset($WINDIR)) $userfile = str_replace("\\","\", $userfile);

still not working, now do I do step 2?

tazgalsinh

i put global registers on but now when i upload the file it says for example : Can't copy install.txt to install.txt.