Sessions Trouble

Ahren

When the user logs in, it is supposed to say Logged in as usersname. But instead it says 'Logged in as'.
Login Page:

<?
if(session_is_registered('username')){ 
    echo "<strong>You are already logged in!</strong> <a href='index.php?id=logout'>Log-Out?</a>"; 
} else { 
    echo "<form method='post' action='index.php?id=login'>Username:<br><input type='text' name='username'>
<br>Password:<br><input type='password' name='password'>
<br><input type='submit' value='Log-In'>"; 
	$username = $_POST['username'];
	$password = $_POST['password'];
	session_register('username');
	$_SESSION['username'] = $_POST['username'];
} 
?>

Display Page:

<?php
if(session_is_registered('username')){ 
    echo "Logged In as $_SESSION['username']"; 
} else { 
    echo "<a href='index.php?id=login'>Log In</a>";
} 
?>

Where did I go wrong?

keith73

1) you never called session_start() in either page.
2) you need to pass the session ID from one page to the other either in a cookie or via URL.

1 other suggestion, these 4 lines can be combined into 1.

$username = $_POST['username'];
    $password = $_POST['password'];
    session_register('username');
    $_SESSION['username'] = $_POST['username'];

should be:

$_SESSION['username'] = $_POST['username'];

if you are using $_SESSION, that means you should not be using session_register or session_is_regsitered.

put your variables into the session like this:

$_SESSION['varname'] = %VALUE%;

where %VALUE% is from POST, a database value, whatever.

and verify your session values like this:

if(isset($_SESSION['varname']))

http://www.php.net/manual/en/reserved.variables.php#reserved.variables.session

keith

xuguoxin

on top write session_start();

Ahren

I did eveything you guys said, but it is still not showing who is logged in.

This is what I have got on the Log-In Page now:

<?
session_start();
?>
<strong>Log</strong>
<?
if(isset($_SESSION['username'])){ 
    echo "<strong>Currently Logged In</strong> <a href='index.php?id=logout' style='text-decoration: none; color: #336699'>Log-Out?</a>"; 
} else { 
    echo "<form method='post' action='index.php?id=login'>Username:<br><input type='text' name='username'><br>Password:<br><input type='password' name='password'><br><input type='submit' value='Log-In'>"; 
            $_SESSION['username'] = $_POST['username'];
} 
?>

and on the other page:

<?php
if(isset($_SESSION['username'])){ 
    echo "Logged In as $_SESSION['username']"; 
} else { 
    echo "<a href='index.php?id=login'>Log In</a>";
} 
?>

And I do have session_start(); at the very top of both of those

keith73

where you have this on the login page:

echo "<form method='post' action='index.php?id=login'>Username:<br><input type='text' name='username'><br>Password:<br><input type='password' name='password'><br><input type='submit' value='Log-In'>"; 
            $_SESSION['username'] = $_POST['username'];

Why are you setting $_SESSION['username'] when the form hasn't even been submitted yet?

The form has to be submitted to a script. That script has to initialize the session then redirect to the index.php page. Initializing the session involves setting your session variables based on the form input and then passing the session ID either via the cookie or URL.

Your username doesn't exist to the script until the form is submitted.

keith

Ahren

Ok...I think I know what I did wrong now..I'm gonna do what you said and see what happens

Ahren

<?php
session_start()
$SESSION['username'] = $POST['username'];
?>

Gives me

Parse error: parse error, unexpected T_VARIABLE in /home/ahren/public_html/php/bin/logging.html on line 3

xblue

just a question: did you notice all the semicolons used in php code? it's more than decoration...