Password Mysql problem

jwswj

I have been having problems with one line of code after setting up the second database for a site I have recently created for a company.

the problem I am having is in the 4th line of this code;
<?
include "config.php";
$query = mysql_query("SELECT * FROM users WHERE username='$username'");
$pass = mysql_result($query, 0, "password")
or die('

It comes up with a "Warning" saying;
Warning: Unable to jump to row 0 on MySQL result index 2 in /usr/local/psa/home/vhosts/nemolution.com/httpdocs/admin/login.php on line 4

Can someone help me with what I am doing wrong.. it works perfectly in the other database!!!

😕 :mad: 😕 :mad: 😕

xblue

obviously your query didn't return any record for some reason.
echo it to see what it looks like:

$sql = "SELECT * FROM users WHERE username='$username'"; 
echo $sql;
$query = mysql_query($sql) or die(mysql_error());

you may need to use $GET['username'] or $POST['username'] instead of $username depending on the php settings (that's recommended anyway because of portability and security).

and you might still want to catch invalid usernames by checking the number of records returned before trying to access the password.

jwswj

I have changed the code so it looks like this

<?
include "config.php";
$sql = "SELECT * FROM users WHERE username='$username'"; 
echo $sql;
$query = mysql_query($sql);
 or die('
<HTML>
<HEAD>
<TITLE>NEMO - ADMIN</TITLE>

Now it is comming up with this error;
Parse error: parse error, unexpected T_LOGICAL_OR in /usr/local/psa/home/vhosts/nemolution.com/httpdocs/admin/login.php on line 6

It doesn't like changing the $username

😕

laserlight

The error now lies in your terminating of the $query = mysql_query($sql) statement

you should also complete the die() with an appropriate error msg

jwswj

This is my php code for the page

<?
include "config.php";
$sql = "SELECT * FROM users WHERE username='$username'"; 
echo $sql;
$query = mysql_query($sql);
 or die('
<HTML>
<HEAD>
<TITLE>NEMO - ADMIN</TITLE>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="../underline.css" type="text/css">
</HEAD>
<BODY BGCOLOR=#454444>
<p>&nbsp; </p>
<table width="624" border="0" bgcolor="#FFFFFF" align="center">
  <tr> 
    <td> 
      <p align="center"><img src="../images/sandskateTM.gif" width="602" height="89"></p>
      <table width=589 border=0 cellpadding=0 cellspacing=0 align="center">
        <tr> 
          <td width="166" height="296" valign="top" bgcolor=#FFFFFF> <p><font size="2" face="Arial, Helvetica, sans-serif"><b>MENU</b></font></p>
            <p><font size="2" face="Arial, Helvetica, sans-serif"><a href="../">consumer 
              web</a><br>
              <a href="../retailer-log.php">retailer web</a><br>
              <a href="http://webmail.nemolution.com/">webmail</a></font></p></td>
          <td width="423" valign="top">
		  <p><font face="Arial, Helvetica, sans-serif" size="2" color="#FF0000"><strong>Login 
              Unsuccessful - Please Try Again</strong></font>
            <p><font face="Arial, Helvetica, sans-serif" size="2">Welcome 
              to NEMO admin!</font></p>
            <p><font face="Arial, Helvetica, sans-serif" size="2">Please enter 
              your secure user name and password to log in.</font></p>
            <form name="Login" method="post" action="login.php">
              <p>user name<br>
                <input name="username" type="text" id="user name" style="background-color: #83B2D8; color: #454444; font-size: 10pt; font-family: Arial; border-style: solid; border-color: #454444">
                <br>
                password<br>
                <input type="password" name="passw" style="background-color: #83B2D8; color: #454444; font-size: 10pt; font-family: Arial; border-style: solid; border-color: #454444">
              </p>
              <p> 
                <input type="submit" value="log in" name="log in" style="background-color: #FFFFFF; color: #454444; font-size: 10pt; face="Arial, Helvetica, sans-serif"; border-style: solid; border-color: #454444">
            </form>
          </td>
        </tr>
        <tr> 
          <td height="27"></td>
          <td></td>
        </tr>
      </table>
    </td>
  </tr>
</table>
</BODY>
</HTML>
');
if(!$passw) {
echo '
<HTML>
<HEAD>
<TITLE>NEMO - ADMIN</TITLE>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="../underline.css" type="text/css">
</HEAD>
<BODY BGCOLOR=#454444>
<p>&nbsp; </p>
<table width="624" border="0" bgcolor="#FFFFFF" align="center">
  <tr> 
    <td> 
      <p align="center"><img src="../images/sandskateTM.gif" width="602" height="89"></p>
      <table width=589 border=0 cellpadding=0 cellspacing=0 align="center">
        <tr> 
          <td width="166" height="296" valign="top" bgcolor=#FFFFFF> <p><font size="2" face="Arial, Helvetica, sans-serif"><b>MENU</b></font></p>
            <p><font size="2" face="Arial, Helvetica, sans-serif"><a href="../">consumer 
              web</a><br>
              <a href="../retailer-log.php">retailer web</a><br>
              <a href="http://webmail.nemolution.com/">webmail</a></font></p></td>
          <td width="423" valign="top">
		  <p><font face="Arial, Helvetica, sans-serif" size="2" color="#FF0000"><strong>Login 
              Unsuccessful - Please Try Again</strong></font>
            <p><font face="Arial, Helvetica, sans-serif" size="2">Welcome 
              to NEMO admin!</font></p>
            <p><font face="Arial, Helvetica, sans-serif" size="2">Please enter 
              your secure user name and password to log in.</font></p>
            <form name="Login" method="post" action="login.php">
              <p>user name<br>
                <input name="username" type="text" id="user name" style="background-color: #83B2D8; color: #454444; font-size: 10pt; font-family: Arial; border-style: solid; border-color: #454444">
                <br>
                password<br>
                <input type="password" name="passw" style="background-color: #83B2D8; color: #454444; font-size: 10pt; font-family: Arial; border-style: solid; border-color: #454444">
              </p>
              <p> 
                <input type="submit" value="log in" name="log in" style="background-color: #FFFFFF; color: #454444; font-size: 10pt; face="Arial, Helvetica, sans-serif"; border-style: solid; border-color: #454444">
            </form>
          </td>
        </tr>
        <tr> 
          <td height="27"></td>
          <td></td>
        </tr>
      </table>
    </td>
  </tr>
</table>
</BODY>
</HTML>
';
}

elseif($passw==$pass) {
  session_start();
  session_register("login_username");
  $_SESSION['login_username'] = $username;
  echo '

<HTML>
<HEAD>
<TITLE>NEMO - ADMIN</TITLE>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META HTTP-EQUIV="Refresh" CONTENT="4;URL=memberarea.php">
<link rel="stylesheet" href="../underline.css" type="text/css">
<BODY BGCOLOR=#454444>
<p>&nbsp; </p>
<table width="624" border="0" bgcolor="#FFFFFF" align="center">
  <tr> 
    <td valign="top"> 
      <p align="center"><img src="../images/sandskateTM.gif" width="602" height="89"></p>
      <p align="center"><font face="Verdana, Arial, Helvetica, sans-serif"><b><font size="3" color="#003366" face="Arial, Helvetica, sans-serif"><br>Login 
        Successful!<br>
        <font size="1" color="#000000">You are now being redirected to the secure 
        site.<br>
        If you are not redirected within 5 seconds, <a href="admin-home.php">click 
        here</a>.</font></font></b></font></p><br>
      </td>
  </tr>
</table>
</BODY>
</HTML>

';
}
else {
  echo '
<HTML>
<HEAD>
<TITLE>NEMO - ADMIN</TITLE>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="../underline.css" type="text/css">
</HEAD>
<BODY BGCOLOR=#454444>
<p>&nbsp; </p>
<table width="624" border="0" bgcolor="#FFFFFF" align="center">
  <tr> 
    <td> 
      <p align="center"><img src="../images/sandskateTM.gif" width="602" height="89"></p>
      <table width=589 border=0 cellpadding=0 cellspacing=0 align="center">
        <tr> 
          <td width="166" height="296" valign="top" bgcolor=#FFFFFF> <p><font size="2" face="Arial, Helvetica, sans-serif"><b>MENU</b></font></p>
            <p><font size="2" face="Arial, Helvetica, sans-serif"><a href="../">consumer 
              web</a><br>
              <a href="../retailer-log.php">retailer web</a><br>
              <a href="http://webmail.nemolution.com/">webmail</a></font></p></td>
          <td width="423" valign="top">
		  <p><font face="Arial, Helvetica, sans-serif" size="2" color="#FF0000"><strong>Login 
              Unsuccessful - Please Try Again</strong></font>
            <p><font face="Arial, Helvetica, sans-serif" size="2">Welcome 
              to NEMO admin!</font></p>
            <p><font face="Arial, Helvetica, sans-serif" size="2">Please enter 
              your secure user name and password to log in.</font></p>
            <form name="Login" method="post" action="login.php">
              <p>user name<br>
                <input name="username" type="text" id="user name" style="background-color: #83B2D8; color: #454444; font-size: 10pt; font-family: Arial; border-style: solid; border-color: #454444">
                <br>
                password<br>
                <input type="password" name="passw" style="background-color: #83B2D8; color: #454444; font-size: 10pt; font-family: Arial; border-style: solid; border-color: #454444">
              </p>
              <p> 
                <input type="submit" value="log in" name="log in" style="background-color: #FFFFFF; color: #454444; font-size: 10pt; face="Arial, Helvetica, sans-serif"; border-style: solid; border-color: #454444">
            </form>
          </td>
        </tr>
        <tr> 
          <td height="27"></td>
          <td></td>
        </tr>
      </table>
    </td>
  </tr>
</table>
</BODY>
</HTML>
';
}
?>

Can you please change it where it needs to be changed.. I have had enough... I would be very grateful.. Please include contact details in the code if you wish

Cheers

xblue

Originally posted by jwswj
I have had enough...

me too, kind of :rolleyes:

this isn't some coding service really, people are trying to help you learn to help yourself rather.

maybe someone who has his or her extremely nice day is willing to fix your code for you nevertheless - best luck!

jwswj

Thanks anyhow for the information you gave me above.

laserlight

the reason for the parse error is simple: you need to remove the semi-colon before "or die('"