More syntax issues

[elskan]

Hi

I am trying to write a link that contains results from a database, I am having problems with the syntax. I am still quite new to this!

Can anyone have a look at where I am going wrong? Cheers

echo "<table width=355 cellpadding=3>\n";

for($i=0;$i<$num_results;$i++)
{
$row = mysql_fetch_array($result);
if(($i%2)==0)
echo "<tr valign=top>\n";

echo "<td><a href=\"pic.php?&alt=\"".$row['model_name'].";
echo "&berth=.$row['berth'].>\n";
echo "<img src=".$row['tn_pic']." alt=".$row['model_name']."></a></td>\n<td valign=middle class=smalltext> ".$row['model_name']."</td>\"";

if(($i%2)==2)
echo "</tr>\n";
}

?></table>

Cheers

[cahva]

You had quite many errors in your script. I changed your double quotes to single so you dont have to use \". Personally I dont use double quote in echo unless I use variables in it.

<table width=355 cellpadding=3>
<?php
for($i=0;$i<$num_results;$i++) 
{ 
$row = mysql_fetch_array($result); 
if(($i%2)==0) 
echo '<tr valign=top>\n';

echo '<td><a href="pic.php?alt='.$row['model_name'].'&berth='.$row['berth'].'">\n'; 
echo '<img src="'.$row['tn_pic'].'" alt="'.$row['model_name'].'"></a></td>\n<td valign=middle class=smalltext>'.$row['model_name'].'</td>'; 

if(($i%2)==2) 
echo '</tr>\n'; 
}
?>
</table>

[elskan]

Thanks for your help.

[elskan]

I have a little problem. I am getting an extra empty cell at the end of my database output.

$sql ="SELECT products.model_price, products.berth, products.tn_pic, products.pic, products.model_name, manufacturers.manu_name FROM products, manufacturers where products.manufacturer_id = 1 AND manufacturers.manufacturer_id=1";

$result= mysql_query($sql,$conn);
$row = mysql_fetch_array($result);
$num_results = mysql_num_rows($result);

for($i=0;$i<$num_results;$i++)
{
$row = mysql_fetch_array($result);
if(($i%2)==0)
echo '<tr valign=top>';
echo '<td colspan=2><a href="pic.php?pic='.$row['pic'].' alt='.$row['model_name'].'&berth='.$row['berth'].'">';
echo '<img src="'.$row['tn_pic'].'" alt="'.$row['model_name'].'" class="frame" border="0"></a><td align="center" class="frame" ><span class=smalltext>Model '.$row['model_name'].' <BR><BR> '.$row['model_price'].' </span></td>';

if(($i%2)==2)
echo '</tr>';
}
?>

Any ideas? I have checked the database and there are no empty records.

Thanks in advance

[laserlight]

Well $i % 2 can never be equal to 2.
It produces integer values 0 or 1.

That is probably why it produces an extra cell where you expect a closing table row.

[elskan]

Now I am lost. I followed the words in

http://www.phpbuilder.com/board/showthread.php?s=&threadid=10235038&highlight=table

I am still getting the extra cell I have tried changing the $i% but to no avail

Any ideas?

[cahva]

The bug is in your for($i=0;$i<$num_results;$i++).

You get the number of rows in $num_results. But you get the last row empty because the rows start from 0, not 1. You can fix this by 2 ways. The simpler is adding -1 in your loop.:

for($i=0;$i<$num_results-1;$i++)

or you can rewrite the whole thing like this (the better way in my opinion):

$sql ="SELECT products.model_price, products.berth, products.tn_pic, products.pic, products.model_name, manufacturers.manu_name FROM products, manufacturers where products.manufacturer_id = 1 AND manufacturers.manufacturer_id=1";

$result= mysql_query($sql,$conn);
$i=0;

while ($row = mysql_fetch_array($result))
{
if(($i%2)==0)
echo '<tr valign=top>';
echo '<td colspan=2><a href="pic.php?pic='.$row['pic'].' alt='.$row['model_name'].'&berth='.$row['berth'].'">';
echo '<img src="'.$row['tn_pic'].'" alt="'.$row['model_name'].'" class="frame" border="0"></a><td align="center" class="frame" ><span class=smalltext>Model '.$row['model_name'].' <BR><BR> '.$row['model_price'].' </span></td>';

if(($i%2)==2)
echo '</tr>';
$i++;
}

[cahva]

Little correction.. It was not the fault of 'for loop'. It was this:

$result= mysql_query($sql,$conn); 
$row = mysql_fetch_array($result); // Remove this and it will work
$num_results = mysql_num_rows($result);

That line was not necessary at all. It pushes the $row array one ahead and you propably didnt get the first row at all in your loop!

Remember, everytime you do that mysql_fetch_array($result), it moves to the next row.