delete from DB script close but not right

[Gump]

Sorry i dont know how to colorize my code or how that even helps readers but..........

My script is doing its job by deleting records in the database via a dynamic image. Problem is I need to pring things next to this image like:

The page name, not linked to anything, and idealy a portion if not all of another record in the DB that corrosponds to this row(s)

Heres the script:

<?php

if ($delete) {

// delete a record

$sql = "DELETE FROM page_data WHERE id=$id";	

$page = $myrow["page"];

echo "Page has been deleted!<p>";

} else {

if (!$id) {

echo "Please select a page to delete by clicking the delete icon <p>";   

    // print the list alphabetically

$result = mysql_query("SELECT * FROM page_data ORDER BY page ASC",$dbh);

echo ($myrow["page"]);

while ($myrow = mysql_fetch_array($result)) {

echo "<a href=\"" . $_SERVER['PHP_SELF'] . "?id=" . $myrow["id"] . "&delete=yes\"><img src=\"../images/delete.gif\" width=\"57\" height=\"19\" border=\"0\"></a><br>";

echo $page ;

echo "<hr>";

}

}

?>
<?php

}

?>

Can that be cleaned up any and why wont that baby print out the "page" column from the table?

Thanks much,

Matt

[cgraz]

first things first: to colorize your code, you have to use the boards php tags. it looks like this

[ p h p ] put your php code here [ / p h p ]

(minus the spaces).

Now onto your problem. Take a closer look at your code

echo ($myrow["page"]); 

while ($myrow = mysql_fetch_array($result)) { 

you define $myrow after you try to echo a key from it. You should call first, then echo. So in other words, put your echo within the while loop.

Cgraz

[siwis]

Lets deal with your 2 problems separately:

// print the list alphabetically 

$result = mysql_query("SELECT * FROM page_data ORDER BY page ASC",$dbh); 

echo ($myrow["page"]); 

while ($myrow = mysql_fetch_array($result)) { 

echo "<a href=\"" . $_SERVER['PHP_SELF'] . "?id=" . $myrow["id"] . "&delete=yes\"><img src=\"../images/delete.gif\" width=\"57\" height=\"19\" border=\"0\"></a><br>"; 

echo $page ; 

echo "<hr>"; 

} 

Should be:

// print the list alphabetically 

$result = mysql_query("SELECT * FROM page_data ORDER BY page ASC",$dbh); 

while ($myrow = mysql_fetch_array($result)) { 

echo $myrow['page'] . "<a href=\"" . $_SERVER['PHP_SELF'] . "?id=" . $myrow['id'] . "&delete=yes\"><img src=\"../images/delete.gif\" width=\"57\" height=\"19\" border=\"0\"></a><br>"; 

echo "<hr>"; 

} 

Next, when it comes to the actual deletion... you create the sql but never actually run it.

// delete a record 

$sql = "DELETE FROM page_data WHERE id=$id"; 
$result = mysql_query($sql, $dbh);
echo "Page has been deleted!<p>"; 

[Gump]

Thanks for the replies guys, much appreciated. I think i have a decent script up and running here, even though the code may be a bit jumbled...

Question: Id like to have the "page" that is printed in the output to be in its own cell in a table, and the image I have to be in another cell of the same row of the same table. I have it setup now with a simple horisontal rune to deliniate the firleds but it is kind of ugly.

echo "<hr>";

Is that do-able?

<?php


  //  connect to the database

$dbh=mysql_connect ("localhost", "transitc_demo", "demo") 
or die ('I cannot connect to the database because: ' . mysql_error()); 
mysql_select_db ("transitc_demo"); 

if ($delete) {

// delete a record

$sql = "DELETE FROM page_data WHERE id=$id";

$result = mysql_query($sql, $dbh);

$page = $myrow["page"];

echo "Page has been deleted!<p>";

echo "<a href=$PHP_SELF>[Go Back]</a><p>";

} else {

  if (!$id) {

echo "Please select a page to delete by clicking the delete icon <p>";   

 // print the list alphabetically 

$result = mysql_query("SELECT * FROM page_data ORDER BY page ASC",$dbh); 

while ($myrow = mysql_fetch_array($result)) { 

echo $myrow['page'] . "<a href=\"" . $_SERVER['PHP_SELF'] . "?id=" . $myrow['id'] . "&delete=yes\"><img src=\"../images/delete.gif\" width=\"57\" height=\"19\" border=\"0\"></a><br>"; 

echo "<hr>"; 

}

  }

  ?>
<?php

}

?>

Thanks!

[siwis]

Yep

start your table BEFORE the loop, then build each table row inside the loop, then finally close the table after the loop terminates:

echo "<table>";
while ($myrow = mysql_fetch_array($result)) { 
echo "<tr>\n\t<td>" . $myrow['page'] . "</td>\n\t<td><a href=\"" . $_SERVER['PHP_SELF'] . "?id=" . $myrow['id'] . "&delete=yes\"><img src=\"../images/delete.gif\" width=\"57\" height=\"19\" border=\"0\"></a></td>\n</tr>"; 
}
echo "</table>";

Hint: When structuring your script place any actions at the start of your script, not at the end. In other words check for any actions that need to be done (ie deletion) prior to sending out the base page. As you've structured your script, the list of pages will be displayed including the one you are deleting even though the script subsequently deletes it. If yoy place your "if ($delete) at the start, the deltion will take place and the list of pages will NOT show the one you've deleted as it will be a fresh query.

[Gump]

Hi thanks again. I actually was revising the code when your reply came in as i realized that my script wasnt doing what i wanted exactly.

Can you site an example for me of the new code that might need some helpin?

Im trying your code out now but its not working on the new script.

Ill have to play a bit.

Thanks agin 😉

BTW way why would I get parse errors inserting standard html table attributes into the opening table tag?

ie

echo "<table width="75%" border="1" cellspacing="1">";

[siwis]

You get parse errors because each time you include a double quote, php expects it t be the end of a literal string section.

You need to either leave out the double quotes OR escape them with a backslash

echo "<table width=\"75%\" border=\"1\" cellspacing=\"1\">";

[siwis]

Give this a go:

<?php
//  connect to the database

$dbh=mysql_connect ("localhost", "transitc_demo", "demo") 
or die ('I cannot connect to the database because: ' . mysql_error()); 
mysql_select_db ("transitc_demo"); 

if (isset($delete)) {

// delete a record

$sql = "DELETE FROM page_data WHERE id=$id";

$result = mysql_query($sql, $dbh);

echo "Selected Page has been deleted!";

}

echo "Please select a page to delete by clicking the delete icon";   

 // print the list alphabetically 

$result = mysql_query("SELECT * FROM page_data ORDER BY page ASC",$dbh); 

?>
<table width="75%" border="1" cellspacing="1">
<?PHP

while ($myrow = mysql_fetch_array($result)) { 
?><tr>
	<td><?PHP echo $myrow['page']; ?></td>
	<td><a href="<?PHP echo $_SERVER['PHP_SELF']; ?>?id=<?PHP echo $myrow['id']; ?>&delete=yes"><img src="../images/delete.gif" width="57" height="19" border="0"></a></td>
</tr>
<?PHP
	};
?>
</table>

[Gump]

Siwis,

You are the man.

Thanks very much. Thats pretty much what I was going for.

I owe.

😃