More, I want more!!!

Rayman3_tk

Hi!

I've got the following script that's used to display one picture out of a mysql database. The point is that I want it to display more than one, but what I've tried didn't work so far. Maybe someone can help? Here's the script:

<?php
@MYSQL_CONNECT("localhost","name","password");

@mysql_select_db("binary_data");

$query = "select id,bin_data,filetype from binary_data";
$result = @MYSQL_QUERY($query);

$data = @MYSQL_RESULT($result,0,"bin_data");
$type = @MYSQL_RESULT($result,0,"filetype");

Header( "Content-type: $type");
echo $data;

?>

Thanks on forehand!

jclout

You need to do a loop like this:

$num = mysql_numrows($result); //count the number of rows


while($i < $num) {

echo MYSQL_RESULT($result,$i,"bin_data");

$i++;}	//adds 1 to i

Frederick

seems like a lot of extra code.

<?php
$dblink = mysql_connect("localhost","username","password")
or die(mysql_error());
mysql_select_db("dbname",$dblink)
or die(mysql_error());

$sql = mysql_query("SELECT * FROM binary_data",$dblink)
or die(mysql_error());
while ($row = mysql_fetch_array($sql)) {

echo "".$row["bin_data"]."<br>";

}
?>

[deleted]

You cannot display more than one image at a time like this.

HTML works with one image per IMG tag.

This is exactly why you should not put the image data itself in a database, because if you want to display 10 images you will need 10 IMG tags that start 10 scripts that open 10 connections to the database and run 10 queries.

If such a page is requested by ten users ad the same time, your database is swamped with 100 queries all demanding many kilobytes of image data. If your database is not up to the job, it will die (especially crappy old mysql which has never liked many concurrent queries)

Instead, store the image data as a normal file and store only the location of that file in the database. THen you can put the location of the file into the IMG tag and the webserver can open it and process it, which is many time faster than reading the data from the database.

csn

Nah, just combine all the images into one db record - like an array! ;P ;P

Rayman3_tk

Thanks for all the code and info guys. I know that it's not ideal to deal with pictures using a database, but my server (lycos...) just doesn't support php ftp functions, and since my users have to be able to upload pictures one way or the other, I'll have to go with this. I didn;t get it to work yet however, but I'll puzzle a little further, you've given me enough material to think about. (And you'll certainly hear it soon enough if I'm stuck 😉 )

Thanks!

xblue

Hi, I think you've got something mixed up - the ftp functions are to transfer files between servers.

Normal http upload is working fine, even with lycos 😉 (I actually highjacked my friend's old lycos account for a few minutes to make sure it does).